Skip to contentSkip to conversation

ath10k: Fix an && vs || typo

PATCH In review Dan Carpenter 2 participants 3 messages Oct 7, 2019 – Oct 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: Fix an && vs || typo

The kernel will Oops later in the function if either of these pointers is NULL so clearly || was intended instead of &&.

Fixes 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")
---
 drivers/net/wireless/ath/ath10k/snoc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/snoc.c +1 -1
index cd22c8654aa9..16177497bba7 100644
@@ -1400,7 +1400,7 @@ static void ath10k_msa_dump_memory(struct ath10k *ar,
 	size_t buf_len;
 	u8 *buf;
 
-	if (!crash_data && !crash_data->ramdump_buf)
+	if (!crash_data || !crash_data->ramdump_buf)
 		return;
 
 	mem_layout = ath10k_coredump_get_mem_layout(ar);
Signature · 1 line
2.20.1
#1 lore raw
Quoted 5 lines · Dan Carpenter

The kernel will Oops later in the function if either of these pointers is NULL so clearly || was intended instead of &&.

Fixes 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")

Sorry, Colin was faster :)

https://patchwork.kernel.org/patch/11174955/

Patch set to Rejected.

Signature · 3 lines
https://patchwork.kernel.org/patch/11176991/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
In reply to Dan Carpenter
Quoted 5 lines · Dan Carpenter

The kernel will Oops later in the function if either of these pointers is NULL so clearly || was intended instead of &&.

Fixes 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990")

Sorry, Colin was faster :)

https://patchwork.kernel.org/patch/11174955/

Patch set to Rejected.

Signature · 9 lines
https://patchwork.kernel.org/patch/11176991/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k