ARM: zx: Use devm_platform_ioremap_resource() in zx296702_pd_probe()
Subsystems (3)
PATCH 1/1 ARM: zx: Use devm_platform_ioremap_resource() in zx296702_pd_probe()
From: Markus Elfring <[email protected]>
Date: Wed, 18 Sep 2019 07:40:26 +0200
Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>
--- arch/arm/mach-zx/zx296702-pm-domain.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)
arch/arm/mach-zx/zx296702-pm-domain.c +1 -9
@@ -152,7 +152,6 @@ static struct generic_pm_domain *zx296702_pm_domains[] = {static int zx296702_pd_probe (struct platform_device *pdev) {struct genpd_onecell_data *genpd_data; -struct resource *res;int i; genpd_data =devm_kzalloc (&pdev->dev,sizeof (*genpd_data),GFP_KERNEL );
@@ -161,14 +160,7 @@ static int zx296702_pd_probe(struct platform_device *pdev) genpd_data->domains = zx296702_pm_domains; genpd_data->num_domains =ARRAY_SIZE (zx296702_pm_domains); - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -if (!res) { -dev_err (&pdev->dev,"no memory resource defined\n" ); -return -ENODEV ; - } - - pcubase =devm_ioremap_resource (&pdev->dev, res); + pcubase =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (pcubase)) {dev_err (&pdev->dev,"ioremap fail.\n" );return -EIO ;
--
2.23.0
Quoted 8 lines · Markus Elfring
From: Markus Elfring <[email protected]>
Date: Wed, 18 Sep 2019 07:40:26 +0200Simplify this function implementation by using a known wrapper function.
This issue was detected by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>
Acked-by Shawn Guo <[email protected]>
@Arnd, can you please help apply it to arm-soc tree?
Shawn
Quoted 40 lines
--- arch/arm/mach-zx/zx296702-pm-domain.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)arch/arm/mach-zx/zx296702-pm-domain.c +1
-10@@ -152,7 +152,6 @@ static struct generic_pm_domain *zx296702_pm_domains[] = {static int zx296702_pd_probe (struct platform_device *pdev) {struct genpd_onecell_data *genpd_data; -struct resource *res;int i; genpd_data =devm_kzalloc (&pdev->dev,sizeof (*genpd_data),GFP_KERNEL );@@ -161,14 +160,7 @@ static int zx296702_pd_probe(struct platform_device *pdev) genpd_data->domains = zx296702_pm_domains; genpd_data->num_domains =ARRAY_SIZE (zx296702_pm_domains); - - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -if (!res) { -dev_err (&pdev->dev,"no memory resource defined\n" ); -return -ENODEV ; - } - - pcubase =devm_ioremap_resource (&pdev->dev, res); + pcubase =devm_platform_ioremap_resource (pdev,0 );if (IS_ERR (pcubase)) {dev_err (&pdev->dev,"ioremap fail.\n" );return -EIO ; --2.23.0
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel