Skip to contentSkip to conversation

ARM: dts: stm32: Add fixes to be compliant with DT validation tool

PATCH New Alexandre Torgue 1 participant 5 messages Oct 7, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: dts: stm32: Add fixes to be compliant with DT validation tool

This series updates STM32 DT files in order to clean some issues seen during STM32 device trees validation ("make dtbs_check").

Regards
Alex

Alexandre Torgue (4):
ARM: dts: stm32: fix memory nodes to match with DT validation tool
ARM: dts: stm32: fix joystick node on stm32f746 and stm32mp157c eval
boards
ARM: dts: stm32: remove usb phy-names entries on stm32mp157c-ev1
ARM: dts: stm32: fix regulator-sd_switch node on stm32mp157c-ed1 board

 arch/arm/boot/dts/stm32429i-eval.dts   | 2 +-
 arch/arm/boot/dts/stm32746g-eval.dts   | 3 +--
 arch/arm/boot/dts/stm32f429-disco.dts  | 2 +-
 arch/arm/boot/dts/stm32f469-disco.dts  | 2 +-
 arch/arm/boot/dts/stm32f746-disco.dts  | 2 +-
 arch/arm/boot/dts/stm32f769-disco.dts  | 2 +-
 arch/arm/boot/dts/stm32h743i-disco.dts | 2 +-
 arch/arm/boot/dts/stm32h743i-eval.dts  | 2 +-
 arch/arm/boot/dts/stm32mp157a-dk1.dts  | 1 +
 arch/arm/boot/dts/stm32mp157c-ed1.dts  | 3 ++-
 arch/arm/boot/dts/stm32mp157c-ev1.dts  | 3 ---
 11 files changed, 11 insertions(+), 13 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/4 ARM: dts: stm32: fix memory nodes to match with DT validation tool

DT validation ("make dtbs_check") has shown that some memory nodes were not correctly written. This commit fixes this kind of issue:

"stm32f746-disco.dt.yaml: /: memory: False schema does not allow {'device_type': ['memory'], 'reg': [[3221225472, 8388608]]}"

arch/arm/boot/dts/stm32429i-eval.dts +1 -1
index ba08624c6237..36ac61d0828c 100644
@@ -60,7 +60,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@00000000 {
 		device_type = "memory";
 		reg = <0x00000000 0x2000000>;
 	};
arch/arm/boot/dts/stm32746g-eval.dts +1 -1
index 2b1664884ae7..d7bb2027cfaa 100644
@@ -55,7 +55,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xc0000000 0x2000000>;
 	};
arch/arm/boot/dts/stm32f429-disco.dts +1 -1
index e19d0fe7dbda..30c0f6717871 100644
@@ -59,7 +59,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@90000000 {
 		device_type = "memory";
 		reg = <0x90000000 0x800000>;
 	};
arch/arm/boot/dts/stm32f469-disco.dts +1 -1
index a3ff04940aec..539aa5903fdd 100644
@@ -60,7 +60,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@00000000 {
 		device_type = "memory";
 		reg = <0x00000000 0x1000000>;
 	};
arch/arm/boot/dts/stm32f746-disco.dts +1 -1
index 0ba9c5b08ab9..569d23cc61e5 100644
@@ -55,7 +55,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xC0000000 0x800000>;
 	};
arch/arm/boot/dts/stm32f769-disco.dts +1 -1
index 6f1d0ac8c31c..1626e00bb2cb 100644
@@ -55,7 +55,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@c0000000 {
 		device_type = "memory";
 		reg = <0xC0000000 0x1000000>;
 	};
arch/arm/boot/dts/stm32h743i-disco.dts +1 -1
index 3acd2e9c434e..e446d311c520 100644
@@ -53,7 +53,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@d0000000 {
 		device_type = "memory";
 		reg = <0xd0000000 0x2000000>;
 	};
arch/arm/boot/dts/stm32h743i-eval.dts +1 -1
index e4d3c58f3d97..8f398178f5e5 100644
@@ -53,7 +53,7 @@
 		stdout-path = "serial0:115200n8";
 	};
 
-	memory {
+	memory@d0000000 {
 		device_type = "memory";
 		reg = <0xd0000000 0x2000000>;
 	};
arch/arm/boot/dts/stm32mp157a-dk1.dts +1 -0
index 0615d1c8a6fc..e2aa45e9ba57 100644
@@ -25,6 +25,7 @@
 	};
 
 	memory@c0000000 {
+		device_type = "memory";
 		reg = <0xc0000000 0x20000000>;
 	};
 
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/4 ARM: dts: stm32: fix joystick node on stm32f746 and stm32mp157c eval boards

In reply to Alexandre Torgue

"#size-cells" entry is not needed for "gpio-keys" driver. Indeed "reg" entry is not used. This commit will fix a warnings seen by DT validation tool.

arch/arm/boot/dts/stm32746g-eval.dts +0 -1
index d7bb2027cfaa..fcc804e3c158 100644
@@ -95,7 +95,6 @@
 
 	joystick {
 		compatible = "gpio-keys";
-		#size-cells = <0>;
 		pinctrl-0 = <&joystick_pins>;
 		pinctrl-names = "default";
 		button-0 {
arch/arm/boot/dts/stm32mp157c-ev1.dts +0 -1
index 89d29b50c3f4..6287db532e7d 100644
@@ -32,7 +32,6 @@
 
 	joystick {
 		compatible = "gpio-keys";
-		#size-cells = <0>;
 		pinctrl-0 = <&joystick_pins>;
 		pinctrl-names = "default";
 		button-0 {
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/4 ARM: dts: stm32: remove usb phy-names entries on stm32mp157c-ev1

In reply to Alexandre Torgue

"phy-names" entries are not used. To be compliant with DT validation tool, those entries have to be remove.

arch/arm/boot/dts/stm32mp157c-ev1.dts +0 -2
index 6287db532e7d..2baae5f25e2c 100644
@@ -343,14 +343,12 @@
 
 &usbh_ehci {
 	phys = <&usbphyc_port0>;
-	phy-names = "usb";
 	status = "okay";
 };
 
 &usbotg_hs {
 	dr_mode = "peripheral";
 	phys = <&usbphyc_port1 0>;
-	phy-names = "usb2-phy";
 	status = "okay";
 };
 
Signature · 1 line
2.17.1
#4 lore raw

PATCH 4/4 ARM: dts: stm32: fix regulator-sd_switch node on stm32mp157c-ed1 board

In reply to Alexandre Torgue

This commit fixes regulator-sd_switch node in order to be compliant to DT validation schema.

arch/arm/boot/dts/stm32mp157c-ed1.dts +2 -1
index 1d426ea8bdaf..329853d9b1de 100644
@@ -100,7 +100,8 @@
 
 		gpios = <&gpiof 14 GPIO_ACTIVE_HIGH>;
 		gpios-states = <0>;
-		states = <1800000 0x1 2900000 0x0>;
+		states = <1800000 0x1>,
+			 <2900000 0x0>;
 	};
 };
 
Signature · 1 line
2.17.1