Skip to contentSkip to conversation

NET: DW: fix regression for ARC boards

PATCH New Eugeniy Paltsev 2 participants 2 messages Oct 7, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NET: DW: fix regression for ARC boards

The commit
642b80d256e ("net: designware: drop compatible altr, socfpga-stmmac") breaks designware ethernet for all ARC boards. It removes "altr, socfpga-stmmac" compatible from "drivers/net/designware.c" without changing compatible in the boards which use it.

Fix that by adding "snps,arc-dwmac-3.70a" compatible string to "drivers/net/designware.c" and using it in ARC boards device tree.

---
Tom, could you please pick this patch to 2019.10?

 arch/arc/dts/axs10x_mb.dtsi | 2 +-
 arch/arc/dts/hsdk.dts       | 2 +-
 drivers/net/designware.c    | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)
arch/arc/dts/axs10x_mb.dtsi +1 -1
index 6d97de9fd8c..5b77642b8d7 100644
@@ -53,7 +53,7 @@
 		};
 
 		ethernet at 18000 {
-			compatible = "altr,socfpga-stmmac";
+			compatible = "snps,arc-dwmac-3.70a";
 			reg = < 0x18000 0x2000 >;
 			phy-mode = "gmii";
 			snps,pbl = < 32 >;
arch/arc/dts/hsdk.dts +1 -1
index 7028050447b..34ef3a620a3 100644
@@ -71,7 +71,7 @@
 
 	ethernet at f0008000 {
 		#interrupt-cells = <1>;
-		compatible = "altr,socfpga-stmmac";
+		compatible = "snps,arc-dwmac-3.70a";
 		reg = <0xf0008000 0x2000>;
 		phy-mode = "gmii";
 	};
drivers/net/designware.c +1 -0
index 145eeac45fd..00313700858 100644
@@ -852,6 +852,7 @@ static const struct udevice_id designware_eth_ids[] = {
 	{ .compatible = "amlogic,meson-gxbb-dwmac" },
 	{ .compatible = "amlogic,meson-axg-dwmac" },
 	{ .compatible = "st,stm32-dwmac" },
+	{ .compatible = "snps,arc-dwmac-3.70a" },
 	{ }
 };
 
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 NET: DW: fix regression for ARC boards

Quoted 10 lines · Eugeniy Paltsev

The commit
642b80d256e ("net: designware: drop compatible altr, socfpga-stmmac") breaks designware ethernet for all ARC boards. It removes "altr, socfpga-stmmac" compatible from "drivers/net/designware.c" without changing compatible in the boards which use it.

Fix that by adding "snps,arc-dwmac-3.70a" compatible string to "drivers/net/designware.c" and using it in ARC boards device tree.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191007/54158040/attachment.sig>