Skip to contentSkip to conversation

package/ytree: fix static build with readline

PATCH New Fabrice Fontaine 3 participants 3 messages Sep 25, 2019 – Oct 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/ytree: fix static build with readline

Fixes:
- http://autobuild.buildroot.org/results/b1a1392636467f8c07504fa6cfb17962764820ae

---
 package/ytree/ytree.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/ytree/ytree.mk +2 -2
index 2d2a6946f7..824ace7155 100644
@@ -14,9 +14,9 @@ YTREE_CFLAGS = -DCOLOR_SUPPORT $(TARGET_CFLAGS)
 YTREE_LDFLAGS = -lncurses $(TARGET_LDFLAGS)
 
 ifeq ($(BR2_PACKAGE_READLINE),y)
-YTREE_DEPENDENCIES += readline
+YTREE_DEPENDENCIES += host-pkgconf readline
 YTREE_CFLAGS += -DREADLINE_SUPPORT
-YTREE_LDFLAGS += -lreadline
+YTREE_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --libs readline`
 endif
 
 define YTREE_BUILD_CMDS
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/ytree: fix static build with readline

Hi Fabrice,

Quoted 4 lines · Fabrice Fontaine

Fixes:
- http://autobuild.buildroot.org/results/b1a1392636467f8c07504fa6cfb17962764820ae

Quoted 21 lines
---
  package/ytree/ytree.mk | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
package/ytree/ytree.mk +2 -2
index 2d2a6946f7..824ace7155 100644
@@ -14,9 +14,9 @@ YTREE_CFLAGS = -DCOLOR_SUPPORT $(TARGET_CFLAGS)
  YTREE_LDFLAGS = -lncurses $(TARGET_LDFLAGS)
 
  ifeq ($(BR2_PACKAGE_READLINE),y)
-YTREE_DEPENDENCIES += readline
+YTREE_DEPENDENCIES += host-pkgconf readline
  YTREE_CFLAGS += -DREADLINE_SUPPORT
-YTREE_LDFLAGS += -lreadline
+YTREE_LDFLAGS += `$(PKG_CONFIG_HOST_BINARY) --libs readline`
  endif
 
  define YTREE_BUILD_CMDS
Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#2 lore raw

PATCH 1/1 package/ytree: fix static build with readline

In reply to Fabrice Fontaine
Quoted 7 lines · On Wed, 25 Sep 2019 18:52:48 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/b1a1392636467f8c07504fa6cfb17962764820ae

---
 package/ytree/ytree.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com