Skip to contentSkip to conversation

PCI: Fix missing bridge dma_ranges resource list cleanup

PATCH Applied Rob Herring 2 participants 2 messages Oct 8, 2019 – Oct 14, 2019 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI: Fix missing bridge dma_ranges resource list cleanup

Commit e80a91ad302b ("PCI: Add dma_ranges window list") added a dma_ranges resource list, but failed to correctly free the list when devm_pci_alloc_host_bridge() is used.

Only the iproc host bridge driver is using the dma_ranges list.

Fixes e80a91ad302b ("PCI: Add dma_ranges window list")
Cc Srinath Mannam <[email protected]>
Cc Bjorn Helgaas <[email protected]>
---
 drivers/pci/probe.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/probe.c +1 -0
index 3d5271a7a849..bdbc8490f962 100644
@@ -572,6 +572,7 @@ static void devm_pci_release_host_bridge_dev(struct device *dev)
 		bridge->release_fn(bridge);
 
 	pci_free_resource_list(&bridge->windows);
+	pci_free_resource_list(&bridge->dma_ranges);
 }
 
 static void pci_release_host_bridge_dev(struct device *dev)
Signature · 1 line
2.20.1
#1 lore raw
Quoted 10 lines · Rob Herring

Commit e80a91ad302b ("PCI: Add dma_ranges window list") added a dma_ranges resource list, but failed to correctly free the list when devm_pci_alloc_host_bridge() is used.

Only the iproc host bridge driver is using the dma_ranges list.

Fixes e80a91ad302b ("PCI: Add dma_ranges window list")
Cc Srinath Mannam <[email protected]>
Cc Bjorn Helgaas <[email protected]>

Applied to pci/resource for v5.5, thanks!

Quoted 19 lines
---
 drivers/pci/probe.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pci/probe.c +1 -0
index 3d5271a7a849..bdbc8490f962 100644
@@ -572,6 +572,7 @@ static void devm_pci_release_host_bridge_dev(struct device *dev)
 		bridge->release_fn(bridge);
 
 	pci_free_resource_list(&bridge->windows);
+	pci_free_resource_list(&bridge->dma_ranges);
 }
 
 static void pci_release_host_bridge_dev(struct device *dev)
Signature · 1 line
2.20.1