staging: vchiq: don't leak kernel address
Subsystems (2)
PATCH 1/1 staging: vchiq: don't leak kernel address
Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), an obfuscated kernel pointer is printed at boot:
vchiq: vchiq_init_state: slot_zero = (____ptrval____)
Remove the the print completely, as it's useless without the address.
--- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +0 -3
@@ -2132,9 +2132,6 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero)char threadname[16 ];int i; -vchiq_log_warning (vchiq_core_log_level, -"%s: slot_zero = %pK" , __func__, slot_zero); -if (vchiq_states[0 ]) {pr_err ("%s: VCHIQ state already initialized\n" , __func__);return VCHIQ_ERROR ;
Signature · 1 line
2.21.0
The subject doesn't match the patch. It should just be "remove useless printk".
regards,
dan carpenter
Quoted 7 lines · Dan Carpenter
The subject doesn't match the patch. It should just be "remove useless printk".
regards,
dan carpenter
Well, it avoids leaking an address by removing an useless printk. It seems that GKH already picked the patch in his staging tree, but I'm fine with both subjects, really,
Greg?
Signature · 2 lines
Matteo Croce per aspera ad upstream
Quoted 5 lines · Matteo Croce
Quoted 4 lines · Dan Carpenter
The subject doesn't match the patch. It should just be "remove useless printk".
Quoted 7 lines
Quoted 3 lines
regards,
dan carpenterWell, it avoids leaking an address by removing an useless printk. It seems that GKH already picked the patch in his staging tree, but I'm fine with both subjects, really,
The address wasn't leaked because it was already %pK. The subject says there is an info leak security problem, when the opposite is true.
regards,
dan carpenter
Greg Kroah-Hartman
maintainerQuoted 10 lines · Dan Carpenter
Quoted 9 lines · Matteo Croce
Quoted 7 lines · Dan Carpenter
The subject doesn't match the patch. It should just be "remove useless printk".
regards,
dan carpenter
Quoted 6 lines
Quoted 3 lines
Well, it avoids leaking an address by removing an useless printk. It seems that GKH already picked the patch in his staging tree, but I'm fine with both subjects, really,
The address wasn't leaked because it was already %pK. The subject says there is an info leak security problem, when the opposite is true.
I've edited the subject line now.
thanks,
greg k-h