Skip to contentSkip to conversation

staging: mt7621-dma: add a blank line to fix checkpatch warning

PATCH In review Jules Irenge 3 participants 3 messages Oct 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: mt7621-dma: add a blank line to fix checkpatch warning

Add blank line to fix missed blank line warning. Warning issued by checkpatch.pl tool:
"WARNING: Missing a blank line after declarations".

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
index d964642d95a3..e309923aed2c 100644
@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
 	struct device_dma_parameters dma_parms;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 
 	struct mtk_hsdma_chan chan[1];
Signature · 1 line
2.21.0
#1 lore raw
Quoted 14 lines · Jules Irenge

Add blank line to fix missed blank line warning. Warning issued by checkpatch.pl tool:
"WARNING: Missing a blank line after declarations".

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -0
index d964642d95a3..e309923aed2c 100644

drivers/staging/mt7621-dma/mtk-hsdma.c struct mtk_hsdam_engine { · line 161

Quoted 5 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
 	struct device_dma_parameters dma_parms;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;

This is also a declaration, so there should not be a blank line before it.

julia

Quoted 10 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -1
 	struct mtk_hsdma_chan chan[1];
--

2.21.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191008140552.25639-1-jbi.octave%40gmail.com.

maintainer
#2 lore raw
In reply to Jules Irenge
Quoted 14 lines · Jules Irenge

Add blank line to fix missed blank line warning. Warning issued by checkpatch.pl tool:
"WARNING: Missing a blank line after declarations".

---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -0
index d964642d95a3..e309923aed2c 100644

drivers/staging/mt7621-dma/mtk-hsdma.c struct mtk_hsdam_engine { · line 161

Quoted 5 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
 	struct device_dma_parameters dma_parms;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;

Look at the code, does this look correct? :)

thanks,

greg k-h