Skip to contentSkip to conversation

package/collectd: needs host-bison

PATCH New Peter Seiderer 3 participants 6 messages Oct 3, 2019 – Oct 8, 2019 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/collectd: needs host-bison

Since 5.9.1 the file src/liboconfig/parser.c is missing from the tar download file, triggering the need for host-bison.

Fixes [1]:

configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison

[1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0

---
 package/collectd/collectd.mk | 3 +++
 1 file changed, 3 insertions(+)
package/collectd/collectd.mk +3 -0
index c409a391c3..4c65ae2832 100644
@@ -143,7 +143,10 @@ COLLECTD_CONF_OPTS += \
 	$(if $(BR2_PACKAGE_COLLECTD_WRITETSDB),--enable-write_tsdb,--disable-write_tsdb) \
 	$(if $(BR2_PACKAGE_COLLECTD_ZOOKEEPER),--enable-zookeeper,--disable-zookeeper)
 
+# since 5.9.1 the file src/liboconfig/parser.c is missing from the tar
+# download file, triggering the need for host-bison
 COLLECTD_DEPENDENCIES = \
+	host-bison \
 	host-pkgconf \
 	$(if $(BR2_PACKAGE_COLLECTD_AMQP),rabbitmq-c) \
 	$(if $(BR2_PACKAGE_COLLECTD_APACHE),libcurl) \

--
2.23.0

#1 lore raw

PATCH 1/1 package/collectd: needs host-bison

Quoted 5 lines · On Thu, 3 Oct 2019 17:29:22 +0200 Peter Seiderer <[email protected]> wrote:

Since 5.9.1 the file src/liboconfig/parser.c is missing from the tar download file, triggering the need for host-bison.

Fixes [1]:

Quoted 8 lines

configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison

[1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0

---
 package/collectd/collectd.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks. Could you report this issue to upstream, and see if they consider this as a bug of their tarball, or if they want users to install bison to build collectd?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 package/collectd: needs host-bison

Re-add: CC: buildroot at buildroot.org

Regards,
Peter

Quoted 40 lines · Peter Seiderer

Hello Thomas,

Quoted 12 lines · Thomas Petazzoni
Quoted 9 lines · On Thu, 3 Oct 2019 17:29:22 +0200 Peter Seiderer <[email protected]> wrote:

Since 5.9.1 the file src/liboconfig/parser.c is missing from the tar download file, triggering the need for host-bison.

Fixes [1]:

configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison

[1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0

Quoted 8 lines
Quoted 4 lines
---
 package/collectd/collectd.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks. Could you report this issue to upstream, and see if they consider this as a bug of their tarball, or if they want users to install bison to build collectd?

The seems to be more problems with the tarball generation (xz archive in tar.bz file, misnamed version string, etc., see [1]), added another comment about the missing file ([2])...

Regards,
Peter

[1] https://github.com/collectd/collectd/issues/3293
[2] https://github.com/collectd/collectd/issues/3293#issuecomment-538746116

Quoted 4 lines

Thanks!

Thomas

#4 lore raw

PATCH 1/1 package/collectd: needs host-bison

Quoted 35 lines · Peter Seiderer

Re-add: CC: buildroot at buildroot.org

Regards,
Peter

Quoted 28 lines · Peter Seiderer

Hello Thomas,

Quoted 12 lines · Thomas Petazzoni
Quoted 9 lines · On Thu, 3 Oct 2019 17:29:22 +0200 Peter Seiderer <[email protected]> wrote:

Since 5.9.1 the file src/liboconfig/parser.c is missing from the tar download file, triggering the need for host-bison.

Fixes [1]:

configure: error: bison is missing and you do not have ./src/liboconfig/parser.c. Please install bison

[1] http://autobuild.buildroot.net/results/4e6f3e5fd0e64f166ae4f7db4832b37ae1fa99e0

Quoted 8 lines
Quoted 4 lines
---
 package/collectd/collectd.mk | 3 +++
 1 file changed, 3 insertions(+)

Applied to master, thanks. Could you report this issue to upstream, and see if they consider this as a bug of their tarball, or if they want users to install bison to build collectd?

The seems to be more problems with the tarball generation (xz archive in tar.bz file, misnamed version string, etc., see [1]), added another comment about the missing file ([2])...

Given the following comment [3] I think it might be better to revert collectd
to 5.9.0:

"All these issues are bugs, because release process done by another person than before. All that is done w/o explicit permission from project "owner", so results are expected."

Or, of course, we can wait a bit to see if a proper 5.9.3 gets released...

Regards,
Arnout

[3] https://github.com/collectd/collectd/issues/3293#issuecomment-538746431

Quoted 18 lines
Quoted 12 lines

Regards,
Peter

[1] https://github.com/collectd/collectd/issues/3293
[2] https://github.com/collectd/collectd/issues/3293#issuecomment-538746116

Quoted 4 lines

Thanks!

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

PATCH 1/1 package/collectd: needs host-bison

Quoted 8 lines · On Mon, 7 Oct 2019 22:55:11 +0200 Arnout Vandecappelle <[email protected]> wrote:

Given the following comment [3] I think it might be better to revert collectd
to 5.9.0:

"All these issues are bugs, because release process done by another person than before. All that is done w/o explicit permission from project "owner", so results are expected."

Or, of course, we can wait a bit to see if a proper 5.9.3 gets released...

Let's do a revert for now ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/1 package/collectd: needs host-bison

Hello Thomas,

Quoted 10 lines · Thomas Petazzoni
Quoted 7 lines · On Mon, 7 Oct 2019 22:55:11 +0200 Arnout Vandecappelle <[email protected]> wrote:

Given the following comment [3] I think it might be better to revert collectd
to 5.9.0:

"All these issues are bugs, because release process done by another person than before. All that is done w/o explicit permission from project "owner", so results are expected."

Quoted 5 lines
Quoted 1 line

Or, of course, we can wait a bit to see if a proper 5.9.3 gets released...

Let's do a revert for now ?

Thomas

According to [4] 'So, I've updated the tarball on the release page here on github.' but I believe only the collectd-5.9.2.tar.bz2 one (and not the collectd-5.9.2.tar.gz one used by buildroot), but the bz2 one contains now the missing parser.c file...

Regards,
Peter

[4] https://github.com/collectd/collectd/issues/3293#issuecomment-539468049