Skip to contentSkip to conversation

net/appletalk: restore success case for atalk_proc_init()

PATCH Superseded Christopher KOBAYASHI 3 participants 4 messages Oct 9, 2019 – Jul 6, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/appletalk: restore success case for atalk_proc_init()

Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to net/appletalk/atalk_proc.c removed the success case, rendering appletalk.ko inoperable. This one-liner restores correct operation.

---

net/appletalk/atalk_proc.c +2 -0
index 550c6ca007cc..9c1241292d1d 100644
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
 
+	return 0;
+
 out:
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;
#1 lore raw
Quoted 5 lines · Christopher KOBAYASHI

Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to net/appletalk/atalk_proc.c removed the success case, rendering appletalk.ko inoperable. This one-liner restores correct operation.

Thank you, the code looks correct!

Could you improve the commit message a little bit?
Could you add a Fixes tag and use the standard way of quoting commits?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes

Once done could you send the patch again indicating this is the second revision in the subject?

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

Quoted 13 lines
net/appletalk/atalk_proc.c +2 -0
index 550c6ca007cc..9c1241292d1d 100644
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
 
+	return 0;
+
 out:
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;
author
#2 lore raw

PATCH v2 1/1 net/appletalk: restore success case for atalk_proc_init()

Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to net/appletalk/atalk_proc.c removed the success case, rendering appletalk.ko inoperable. This one-liner restores correct operation.

Fixes e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 ("appletalk: use remove_proc_subtree to simplify procfs code")

---

Apologies for the delay in revising this patch, life got a bit busy.

net/appletalk/atalk_proc.c +2 -0
index 550c6ca007cc..9c1241292d1d 100644
@@ -229,6 +229,8 @@ int __init atalk_proc_init(void)
 				     sizeof(struct aarp_iter_state), NULL))
 		goto out;
 
+	return 0;
+
 out:
 	remove_proc_subtree("atalk", init_net.proc_net);
 	return -ENOMEM;
maintainer
#3 lore raw

From: Chris <[email protected]>
Date: Mon, 6 Jul 2020 20:11:30 +0900

Quoted 1 line
Fixes e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 ("appletalk: use remove_proc_subtree to simplify procfs code")

12-digits of significance in SHA1 IDs in Fixes: tags please.

Also, if you mention the SHA1 ID in the Fixes tag you can elide it from the commit message.