Skip to contentSkip to conversation

kernel/cred.c: make init_groups static

PATCH New Rasmus Villemoes 1 participant 1 message Oct 9, 2019 Credentials

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel/cred.c: make init_groups static

init_groups is declared in both cred.h and init_task.h, but it is not actually referenced anywhere outside of cred.c where it is defined. So make it static and remove the declarations.

---
 include/linux/cred.h      | 1 -
 include/linux/init_task.h | 1 -
 kernel/cred.c             | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)
include/linux/cred.h +0 -1
index 18639c069263..4f4af62fe8f9 100644
@@ -53,7 +53,6 @@ do {							\
 		groups_free(group_info);		\
 } while (0)
 
-extern struct group_info init_groups;
 #ifdef CONFIG_MULTIUSER
 extern struct group_info *groups_alloc(int);
 extern void groups_free(struct group_info *);
include/linux/init_task.h +0 -1
index 2c620d7ac432..6a046030ffad 100644
@@ -25,7 +25,6 @@
 extern struct files_struct init_files;
 extern struct fs_struct init_fs;
 extern struct nsproxy init_nsproxy;
-extern struct group_info init_groups;
 extern struct cred init_cred;
 
 #ifndef CONFIG_VIRT_CPU_ACCOUNTING_NATIVE
kernel/cred.c +1 -1
index c0a4c12d38b2..87983c9f82e9 100644
@@ -33,7 +33,7 @@ do {									\
 static struct kmem_cache *cred_jar;
 
 /* init to 2 - one for init_task, one to ensure it is never freed */
-struct group_info init_groups = { .usage = ATOMIC_INIT(2) };
+static struct group_info init_groups = { .usage = ATOMIC_INIT(2) };
 
 /*
  * The initial credentials for the initial task
Signature · 1 line
2.20.1