Skip to contentSkip to conversation

drm/fb-helper: include drm/drm_fb_cma_helper.h for missing declarations

PATCH New Ben Dooks 1 participant 2 messages Oct 9, 2019

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/2 drm/fb-helper: include drm/drm_fb_cma_helper.h for missing declarations

Include <drm/drm_fb_cma_helper.h> to fix the following warnings from missing declarations:

drivers/gpu/drm/drm_fb_cma_helper.c:38:27: warning: symbol 'drm_fb_cma_get_gem_obj' was not declared. Should it be static? drivers/gpu/drm/drm_fb_cma_helper.c:62:12: warning: symbol 'drm_fb_cma_get_gem_addr' was not declared. Should it be static?

---
 drivers/gpu/drm/drm_fb_helper.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_fb_helper.c +1 -0
index a7ba5b4902d6..23e10075619f 100644
@@ -45,6 +45,7 @@
 #include <drm/drm_fourcc.h>
 #include <drm/drm_print.h>
 #include <drm/drm_vblank.h>
+#include <drm/drm_fb_cma_helper.h>
 
 #include "drm_internal.h"
 
Signature · 1 line
2.23.0
author
#1 lore raw

PATCH 2/2 drm/fb-helper: include drm_crtc_helper_internal.h for drm_fb_helper_modinit

Include drm_crtc_helper_internal.h for drm_fb_helper_modinit definition to fix the following warning:

drivers/gpu/drm/drm_fb_helper.c:2410:12: warning: symbol 'drm_fb_helper_modinit' was not declared. Should it be static?

---
 drivers/gpu/drm/drm_fb_helper.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_fb_helper.c +1 -0
index 23e10075619f..f1359e3e676c 100644
@@ -48,6 +48,7 @@
 #include <drm/drm_fb_cma_helper.h>
 
 #include "drm_internal.h"
+#include "drm_crtc_helper_internal.h"
 
 static bool drm_fbdev_emulation = true;
 module_param_named(fbdev_emulation, drm_fbdev_emulation, bool, 0600);
Signature · 1 line
2.23.0