drm/msm: make a5xx_show and a5xx_gpu_state_put static
Subsystems (4)
PATCH 1/1 drm/msm: make a5xx_show and a5xx_gpu_state_put static
The a5xx_show and a5xx_gpu_state_put objects are not exported outside of the file, so make them static to avoid the following warnings from sparse:
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1292:5: warning: symbol 'a5xx_gpu_state_put' was not declared. Should it be static? drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was not declared. Should it be static?
---
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
--- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/msm/adreno/a5xx_gpu.c +3 -3
@@ -1289,7 +1289,7 @@ static void a5xx_gpu_state_destroy(struct kref *kref)kfree (a5xx_state); } -int a5xx_gpu_state_put (struct msm_gpu_state *state) +static int a5xx_gpu_state_put (struct msm_gpu_state *state) {if (IS_ERR_OR_NULL (state))return 1 ;
@@ -1299,8 +1299,8 @@ int a5xx_gpu_state_put(struct msm_gpu_state *state)#if defined(CONFIG_DEBUG_FS ) || defined(CONFIG_DEV_COREDUMP ) -void a5xx_show (struct msm_gpu *gpu,struct msm_gpu_state *state, -struct drm_printer *p) +static void a5xx_show (struct msm_gpu *gpu,struct msm_gpu_state *state, +struct drm_printer *p) {int i, j;u32 pos =0 ;
Signature · 6 lines
2.23.0 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
A message that is not in the archive (sent off-list or not yet received): 20191009114607.701-1-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org
Jordan Crouse
Reviewed-byQuoted 6 lines · Ben Dooks
The
a5xx_showanda5xx_gpu_state_putobjects are not exported outside of the file, so make them static to avoid the following warnings from sparse:
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1292:5: warning: symbol 'a5xx_gpu_state_put' was not declared. Should it be static?drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was not declared. Should it be static?
Quoted 40 lines
Signed-off-by Ben Dooks <[email protected]>---
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/msm/adreno/a5xx_gpu.c +3
-3@@ -1289,7 +1289,7 @@ static void a5xx_gpu_state_destroy(struct kref *kref)kfree (a5xx_state); } -int a5xx_gpu_state_put (struct msm_gpu_state *state) +static int a5xx_gpu_state_put (struct msm_gpu_state *state) {if (IS_ERR_OR_NULL (state))return 1 ;@@ -1299,8 +1299,8 @@ int a5xx_gpu_state_put(struct msm_gpu_state *state)#if defined(CONFIG_DEBUG_FS ) || defined(CONFIG_DEV_COREDUMP ) -void a5xx_show (struct msm_gpu *gpu,struct msm_gpu_state *state, -struct drm_printer *p) +static void a5xx_show (struct msm_gpu *gpu,struct msm_gpu_state *state, +struct drm_printer *p) {int i, j;u32 pos =0 ;Signature · 1 line
2.23.0
Signature · 6 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
A message that is not in the archive (sent off-list or not yet received): 20191009154406.GB13386-p/[email protected]
Sean Paul
AppliedQuoted 10 lines · Jordan Crouse
Quoted 6 lines · Ben Dooks
The
a5xx_showanda5xx_gpu_state_putobjects are not exported outside of the file, so make them static to avoid the following warnings from sparse:
drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1292:5: warning: symbol 'a5xx_gpu_state_put' was not declared. Should it be static?drivers/gpu/drm/msm/adreno/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was not declared. Should it be static?Reviewed-by Jordan Crouse <[email protected]>
Applied to msm-next, thanks for the review and patch!
Sean
Quoted 44 lines
Quoted 40 lines
Signed-off-by Ben Dooks <[email protected]>---
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]--- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/msm/adreno/a5xx_gpu.c +3
-3@@ -1289,7 +1289,7 @@ static void a5xx_gpu_state_destroy(struct kref *kref)kfree (a5xx_state); } -int a5xx_gpu_state_put (struct msm_gpu_state *state) +static int a5xx_gpu_state_put (struct msm_gpu_state *state) {if (IS_ERR_OR_NULL (state))return 1 ;@@ -1299,8 +1299,8 @@ int a5xx_gpu_state_put(struct msm_gpu_state *state)#if defined(CONFIG_DEBUG_FS ) || defined(CONFIG_DEV_COREDUMP ) -void a5xx_show (struct msm_gpu *gpu,struct msm_gpu_state *state, -struct drm_printer *p) +static void a5xx_show (struct msm_gpu *gpu,struct msm_gpu_state *state, +struct drm_printer *p) {int i, j;u32 pos =0 ;Signature · 1 line
2.23.0Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno