Skip to contentSkip to conversation

trace: add --group=all to tracing.txt

PATCH Applied Stefan Hajnoczi 3 participants 4 messages Oct 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trace: add --group=all to tracing.txt

tracetool needs to know the group name ("all", "root", or a specific subdirectory). Also remove the stdin redirection because tracetool.py needs the path to the trace-events file. Update the documentation.

Fixes 2098c56a9bc5901e145fa5d4759f075808811685

("trace: move setting of group name into Makefiles")
Launchpad: https://bugs.launchpad.net/bugs/1844814

---
 docs/devel/tracing.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
docs/devel/tracing.txt +2 -1
index 8231bbf5d1..8c0376fefa 100644
@@ -317,7 +317,8 @@ probes:
                          --binary path/to/qemu-binary \
                          --target-type system \
                          --target-name x86_64 \
-                         <trace-events-all >qemu.stp
+                         --group=all \
+                         trace-events-all >qemu.stp
 
 To facilitate simple usage of systemtap where there merely needs to be printf
 logging of certain probes, a helper script "qemu-trace-stap" is provided.
Signature · 1 line
2.21.0
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 3 lines · Stefan Hajnoczi

tracetool needs to know the group name ("all", "root", or a specific subdirectory). Also remove the stdin redirection because tracetool.py needs the path to the trace-events file. Update the documentation.

Thanks!

Quoted 17 lines
Fixes 2098c56a9bc5901e145fa5d4759f075808811685

("trace: move setting of group name into Makefiles")
Launchpad: https://bugs.launchpad.net/bugs/1844814

---
  docs/devel/tracing.txt | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
docs/devel/tracing.txt +0 -0
index 8231bbf5d1..8c0376fefa 100644

docs/devel/tracing.txt probes: · line 324

Quoted 9 lines
docs/devel/tracing.txt +2 -1
@@ -317,7 +317,8 @@ probes:
                           --binary path/to/qemu-binary \
                           --target-type system \
                           --target-name x86_64 \
-                         <trace-events-all >qemu.stp
+                         --group=all \
+                         trace-events-all >qemu.stp
 
  To facilitate simple usage of systemtap where there merely needs to be printf
  logging of certain probes, a helper script "qemu-trace-stap" is provided.
Reviewed-by on v1 1/1
#2 lore raw
In reply to Stefan Hajnoczi
Quoted 5 lines · Stefan Hajnoczi

tracetool needs to know the group name ("all", "root", or a specific subdirectory). Also remove the stdin redirection because tracetool.py needs the path to the trace-events file. Update the documentation.

Fixes 2098c56a9bc5901e145fa5d4759f075808811685
Quoted 8 lines

("trace: move setting of group name into Makefiles")
Launchpad: https://bugs.launchpad.net/bugs/1844814

---
 docs/devel/tracing.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
author Applied
#3 lore raw
In reply to Stefan Hajnoczi
Quoted 5 lines · Stefan Hajnoczi

tracetool needs to know the group name ("all", "root", or a specific subdirectory). Also remove the stdin redirection because tracetool.py needs the path to the trace-events file. Update the documentation.

Fixes 2098c56a9bc5901e145fa5d4759f075808811685
Quoted 8 lines

("trace: move setting of group name into Makefiles")
Launchpad: https://bugs.launchpad.net/bugs/1844814

---
 docs/devel/tracing.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan