Skip to contentSkip to conversation

fs/namespace: make to_mnt_ns static

PATCH In review Ben Dooks 2 participants 2 messages Oct 9, 2019 VFS

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 fs/namespace: make to_mnt_ns static

The to_mnt_ns() is not exported outside the file so make it static to fix the following sparse warning:

fs/namespace.c:1731:22: warning: symbol 'to_mnt_ns' was not declared. Should it be static?

---
Cc: Alexander Viro <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
index fe0e9e1410fe..b87b127fdce4 100644
@@ -1728,7 +1728,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
Signature · 1 line
2.23.0
#1 lore raw
Quoted 30 lines · Ben Dooks

The to_mnt_ns() is not exported outside the file so make it static to fix the following sparse warning:

fs/namespace.c:1731:22: warning: symbol 'to_mnt_ns' was not declared. Should it be static?

---
Cc: Alexander Viro <[email protected]>
Cc: [email protected]
Cc: [email protected]

---
 fs/namespace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/namespace.c +1 -1
index fe0e9e1410fe..b87b127fdce4 100644
@@ -1728,7 +1728,7 @@ static bool is_mnt_ns_file(struct dentry *dentry)
 	       dentry->d_fsdata == &mntns_operations;
 }
 
-struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
+static struct mnt_namespace *to_mnt_ns(struct ns_common *ns)
 {
 	return container_of(ns, struct mnt_namespace, ns);
 }
Signature · 1 line
2.23.0

Al, this patch has been sent to you 11 times by 8 different people over 2 years:

https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/20190414191913.GA11798@bharath12345-Inspiron-5559/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/[email protected]/
https://lore.kernel.org/linux-fsdevel/a2cc7bd9cd4cd5be54303090c7ba6654d7b04b4f.1443364195.git.geliangtang@163.com/

No response from you to any of them. I guess this means you're just not taking these types of obvious cleanups? Should people be sending them to Andrew Morton instead?

- Eric