Skip to contentSkip to conversation

package/python-pysnmp-apps: remove package

PATCH New Asaf Kahlon 2 participants 4 messages Oct 9, 2019 – Oct 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 package/python-pysnmp-apps: remove package

The package was renamed to snmpclient and is no longer maintained.

---
v1->v2: add legacy option in Config.in.legacy

---
 Config.in.legacy                                  |  8 ++++++++
 package/Config.in                                 |  1 -
 package/python-pysnmp-apps/Config.in              | 12 ------------
 .../python-pysnmp-apps/python-pysnmp-apps.hash    |  5 -----
 package/python-pysnmp-apps/python-pysnmp-apps.mk  | 15 ---------------
 5 files changed, 8 insertions(+), 33 deletions(-)
 delete mode 100644 package/python-pysnmp-apps/Config.in
 delete mode 100644 package/python-pysnmp-apps/python-pysnmp-apps.hash
 delete mode 100644 package/python-pysnmp-apps/python-pysnmp-apps.mk
Config.in.legacy +8 -0
index 4a670f0f0e..e53327803c 100644
@@ -146,6 +146,14 @@ endif
 
 comment "Legacy options removed in 2019.11"
 
+config BR2_PACKAGE_PYTHON_PYSNMP_APPS
+	bool "python-pysnmp-apps projcet was moved"
+	select BR2_LEGACY
+	select BR2_PACKAGE_SNMPCLITOOLS
+	help
+	  Upstream moved the pysnmp-apps project to snmpclitools.
+	  Use it instead.
+
 config BR2_PACKAGE_SQLITE_STAT3
 	bool "sqlite stat3 support was removed"
 	select BR2_LEGACY
package/Config.in +0 -1
index 47b602c547..d8d0824c71 100644
@@ -1037,7 +1037,6 @@ menu "External python modules"
 	source "package/python-pysmb/Config.in"
 	source "package/python-pysmi/Config.in"
 	source "package/python-pysnmp/Config.in"
-	source "package/python-pysnmp-apps/Config.in"
 	source "package/python-pysnmp-mibs/Config.in"
 	source "package/python-pysocks/Config.in"
 	source "package/python-pytablereader/Config.in"
package/python-pysnmp-apps/Config.in deleted +0 -12
deleted file mode 100644
index 32e3269946..0000000000
@@ -1,12 +0,0 @@
-config BR2_PACKAGE_PYTHON_PYSNMP_APPS
-	bool "python-pysnmp-apps"
-	depends on BR2_INSTALL_LIBSTDCPP # pysnmp -> pyasn
-	select BR2_PACKAGE_PYTHON_PYSNMP
-	help
-	  A collection of command-line tools for SNMP management
-	  purposes built on top of the PySNMP package.
-
-	  http://pysnmp.sf.net
-
-comment "python-pysnmp-apps needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
package/python-pysnmp-apps/python-pysnmp-apps.hash deleted +0 -5
deleted file mode 100644
index 42120486d9..0000000000
@@ -1,5 +0,0 @@
-# md5, sha256 from https://pypi.org/pypi/pysnmp-apps/json
-md5	ed3e4d421bb0e1806298120313efccc2  pysnmp-apps-0.5.3.tar.gz
-sha256	bf4ea6f3054a25b05e255d29e0b57a8aa8102f509048e3a9c0d93ddc86aff570  pysnmp-apps-0.5.3.tar.gz
-# Locally computed sha256 checksums
-sha256	f82128f64d567c333936a12b99a21d0e8cd66ce628d51ce0a7770cc38dc7fe43  LICENSE.txt
package/python-pysnmp-apps/python-pysnmp-apps.mk deleted +0 -15
deleted file mode 100644
index 70d63834cb..0000000000
@@ -1,15 +0,0 @@
-################################################################################
-#
-# python-pysnmp-apps
-#
-################################################################################
-
-PYTHON_PYSNMP_APPS_VERSION = 0.5.3
-PYTHON_PYSNMP_APPS_SOURCE = pysnmp-apps-$(PYTHON_PYSNMP_APPS_VERSION).tar.gz
-PYTHON_PYSNMP_APPS_SITE = https://files.pythonhosted.org/packages/c2/1a/26f5f3732df2c7d34663a7f2fa6534b5b4ffae73a4a440b75864ec826ba6
-PYTHON_PYSNMP_APPS_SETUP_TYPE = setuptools
-PYTHON_PYSNMP_APPS_LICENSE = BSD-2-Clause
-PYTHON_PYSNMP_APPS_LICENSE_FILES = LICENSE.txt
-PYTHON_PYSNMP_APPS_DEPENDENCIES = python-pysnmp
-
-$(eval $(python-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 2/2 package/snmpclitools: new package

For now, we use PKG-INFO as license file, since LICENSE.rst isn't provided with the tarball.
A pull request was sent upstream:
https://github.com/etingof/snmpclitools/pull/11

---
v1->v2: rename to snmpclitools (instead of python-snmpclitools)

---
 DEVELOPERS                             |  1 +
 package/Config.in                      |  1 +
 package/snmpclitools/Config.in         |  9 +++++++++
 package/snmpclitools/snmpclitools.hash |  5 +++++
 package/snmpclitools/snmpclitools.mk   | 14 ++++++++++++++
 5 files changed, 30 insertions(+)
 create mode 100644 package/snmpclitools/Config.in
 create mode 100644 package/snmpclitools/snmpclitools.hash
 create mode 100644 package/snmpclitools/snmpclitools.mk
DEVELOPERS +1 -0
index 05f33eb2c3..37af071500 100644
@@ -234,6 +234,7 @@ N:	Asaf Kahlon <[email protected]>
 F:	package/collectd/
 F:	package/libuv/
 F:	package/python*
+F:	package/snmpclitools/
 F:	package/spdlog/
 F:	package/uftp/
 F:	package/zeromq/
package/Config.in +1 -0
index d8d0824c71..5574e2f6d0 100644
@@ -2069,6 +2069,7 @@ endif
 	source "package/shellinabox/Config.in"
 	source "package/smcroute/Config.in"
 	source "package/sngrep/Config.in"
+	source "package/snmpclitools/Config.in"
 	source "package/snort/Config.in"
 	source "package/socat/Config.in"
 	source "package/socketcand/Config.in"
package/snmpclitools/Config.in new file +9 -0
new file mode 100644
index 0000000000..00bf5994d1
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_SNMPCLITOOLS
+	bool "snmpclitools"
+	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
+	select BR2_PACKAGE_PYTHON_PYSMI # runtime
+	select BR2_PACKAGE_PYTHON_PYSNMP # runtime
+	help
+	  SNMP command-line tools.
+
+	  https://github.com/etingof/snmpclitools
package/snmpclitools/snmpclitools.hash new file +5 -0
new file mode 100644
index 0000000000..4dcbdcb6e0
@@ -0,0 +1,5 @@
+# md5, sha256 from https://pypi.org/pypi/snmpclitools/json
+md5	132b100f5e7b80715e6c1d424e89687c  snmpclitools-0.6.4.tar.gz
+sha256	820c45de419bf355c845a96610a395ec18a15176ac0362d388da7740266ea1ac  snmpclitools-0.6.4.tar.gz
+# Locally computed sha256 checksums
+sha256	ed5561a0f5b75e93aa026c1b9fdef58e7ccbf6b2e9a2458be732afc288209d23  PKG-INFO
package/snmpclitools/snmpclitools.mk new file +14 -0
new file mode 100644
index 0000000000..68cb6206fe
@@ -0,0 +1,14 @@
+################################################################################
+#
+# snmpclitools
+#
+################################################################################
+
+SNMPCLITOOLS_VERSION = 0.6.4
+SNMPCLITOOLS_SOURCE = snmpclitools-$(SNMPCLITOOLS_VERSION).tar.gz
+SNMPCLITOOLS_SITE = https://files.pythonhosted.org/packages/03/2a/8488828e92a82c5416e33fba6089283162937b0f73e5b15205fb6ec3bbea
+SNMPCLITOOLS_SETUP_TYPE = setuptools
+SNMPCLITOOLS_LICENSE = BSD-2-Clause
+SNMPCLITOOLS_LICENSE_FILES = PKG-INFO
+
+$(eval $(python-package))
Signature · 1 line
2.20.1
#2 lore raw

PATCH v2 2/2 package/snmpclitools: new package

package/snmpclitools/snmpclitools.mk line 8

Quoted 2 lines · On Wed, 9 Oct 2019 20:24:21 +0300 Asaf Kahlon <[email protected]> wrote:
package/snmpclitools/snmpclitools.mk new file +2 -0
+SNMPCLITOOLS_VERSION = 0.6.4
+SNMPCLITOOLS_SOURCE = snmpclitools-$(SNMPCLITOOLS_VERSION).tar.gz

This is the default value for the _SOURCE variable, so it is not needed. check-package triggers a warning for this.

I fixed this, and applied. I actually applied this one before the removal of python-pysnmp-apps.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH v2 1/2 package/python-pysnmp-apps: remove package

In reply to Asaf Kahlon
Quoted 1 line · On Wed, 9 Oct 2019 20:24:20 +0300 Asaf Kahlon <[email protected]> wrote:

The package was renamed to snmpclient and is no longer maintained.

The package was renamed to snmpclitools, not snmpclient.

Config.in.legacy endif · line 155

Quoted 7 lines
Config.in.legacy +7 -0
+config BR2_PACKAGE_PYTHON_PYSNMP_APPS
+	bool "python-pysnmp-apps projcet was moved"
+	select BR2_LEGACY
+	select BR2_PACKAGE_SNMPCLITOOLS
+	help
+	  Upstream moved the pysnmp-apps project to snmpclitools.
+	  Use it instead.

I slightly improved the wording here, and applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com