Skip to contentSkip to conversation

sound/soc/ti/j721e-evm.c:399 j721e_audio_hw_params() warn: inconsistent returns 'mutex:&priv->mutex'.

PATCH New Dan Carpenter 1 participant 1 message Oct 9, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 40/47 sound/soc/ti/j721e-evm.c:399 j721e_audio_hw_params() warn: inconsistent returns 'mutex:&priv->mutex'.

tree:   https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip
head:   0288109696d1bb4b24553465fdb779256148618e
commit: 098c67f22952c25146488c9adafeb18ae6d32ef4 [40/47] ASoC: ti: j721e-evm: Add support for Infotainment Expansion Board

If you fix the issue, kindly add following tag

smatch warnings:
sound/soc/ti/j721e-evm.c:399 j721e_audio_hw_params() warn: inconsistent returns 'mutex:&priv->mutex'.
Locked on: line 367
Unlocked on: line 399

# https://github.com/omap-audio/linux-audio/commit/098c67f22952c25146488c9adafeb18ae6d32ef4
git remote add omap-audio https://github.com/omap-audio/linux-audio
git remote update omap-audio
git checkout 098c67f22952c25146488c9adafeb18ae6d32ef4
vim +399 sound/soc/ti/j721e-evm.c

457eebe1cf0729 Peter Ujfalusi 2019-08-09  338  static int j721e_audio_hw_params(struct snd_pcm_substream *substream,
457eebe1cf0729 Peter Ujfalusi 2019-08-09  339  				 struct snd_pcm_hw_params *params)
457eebe1cf0729 Peter Ujfalusi 2019-08-09  340  {
457eebe1cf0729 Peter Ujfalusi 2019-08-09  341  	struct 	snd_soc_pcm_runtime *rtd = substream->private_data;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  342  	struct snd_soc_card *card = rtd->card;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  343  	struct j721e_priv *priv = snd_soc_card_get_drvdata(card);
098c67f22952c2 Peter Ujfalusi 2019-08-23  344  	unsigned int domain_id = J721E_DAI_LINK_ID_TO_DOMAIN(rtd->dai_link->id);
098c67f22952c2 Peter Ujfalusi 2019-08-23  345  	struct j721e_audio_domain *domain = &priv->audio_domains[domain_id];
457eebe1cf0729 Peter Ujfalusi 2019-08-09  346  	int slot_width = 32;
098c67f22952c2 Peter Ujfalusi 2019-08-23  347  	int ret, i;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  348  
457eebe1cf0729 Peter Ujfalusi 2019-08-09  349  	mutex_lock(&priv->mutex);
                                                ^^^^^^^^^^^^^^^^^^^^^^^
457eebe1cf0729 Peter Ujfalusi 2019-08-09  350  
098c67f22952c2 Peter Ujfalusi 2019-08-23  351  	if (domain->rate && domain->rate != params_rate(params)) {
457eebe1cf0729 Peter Ujfalusi 2019-08-09  352  		ret = -EINVAL;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  353  		goto out;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  354  	}
457eebe1cf0729 Peter Ujfalusi 2019-08-09  355  
457eebe1cf0729 Peter Ujfalusi 2019-08-09  356  	if (params_width(params) == 16)
457eebe1cf0729 Peter Ujfalusi 2019-08-09  357  		slot_width = 16;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  358  
457eebe1cf0729 Peter Ujfalusi 2019-08-09  359  	ret = snd_soc_dai_set_tdm_slot(rtd->cpu_dai, 0x3, 0x3, 2, slot_width);
098c67f22952c2 Peter Ujfalusi 2019-08-23  360  	if (ret && ret != -ENOTSUPP)
457eebe1cf0729 Peter Ujfalusi 2019-08-09  361  		goto out;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  362  
098c67f22952c2 Peter Ujfalusi 2019-08-23  363  	for (i = 0; i < rtd->num_codecs; i++) {
098c67f22952c2 Peter Ujfalusi 2019-08-23  364  		ret = snd_soc_dai_set_tdm_slot(rtd->codec_dais[i], 0x3, 0x3, 2,
098c67f22952c2 Peter Ujfalusi 2019-08-23  365  					       slot_width);
098c67f22952c2 Peter Ujfalusi 2019-08-23  366  		if (ret && ret != -ENOTSUPP)
098c67f22952c2 Peter Ujfalusi 2019-08-23  367  			return ret;

goto out;

098c67f22952c2 Peter Ujfalusi 2019-08-23  368  	}
457eebe1cf0729 Peter Ujfalusi 2019-08-09  369  
098c67f22952c2 Peter Ujfalusi 2019-08-23  370  	ret = j721e_configure_refclk(priv, domain_id, params_rate(params));
457eebe1cf0729 Peter Ujfalusi 2019-08-09  371  	if (ret)
457eebe1cf0729 Peter Ujfalusi 2019-08-09  372  		goto out;
457eebe1cf0729 Peter Ujfalusi 2019-08-09  373  
098c67f22952c2 Peter Ujfalusi 2019-08-23  374  	for (i = 0; i < rtd->num_codecs; i++) {
098c67f22952c2 Peter Ujfalusi 2019-08-23  375  		ret = snd_soc_dai_set_sysclk(rtd->codec_dais[i], 0,
098c67f22952c2 Peter Ujfalusi 2019-08-23  376  				priv->hsdiv_rates[domain->parent_clk_id],
457eebe1cf0729 Peter Ujfalusi 2019-08-09  377  				SND_SOC_CLOCK_IN);
098c67f22952c2 Peter Ujfalusi 2019-08-23  378  		if (ret && ret != -ENOTSUPP) {
098c67f22952c2 Peter Ujfalusi 2019-08-23  379  			dev_err(priv->dev, "codec set_sysclk failed for %u Hz\n",
098c67f22952c2 Peter Ujfalusi 2019-08-23  380  				priv->hsdiv_rates[domain->parent_clk_id]);
457eebe1cf0729 Peter Ujfalusi 2019-08-09  381  			goto out;
098c67f22952c2 Peter Ujfalusi 2019-08-23  382  		}
098c67f22952c2 Peter Ujfalusi 2019-08-23  383  	}
457eebe1cf0729 Peter Ujfalusi 2019-08-09  384  
457eebe1cf0729 Peter Ujfalusi 2019-08-09  385  	ret = snd_soc_dai_set_sysclk(rtd->cpu_dai, MCASP_CLK_HCLK_AUXCLK,
098c67f22952c2 Peter Ujfalusi 2019-08-23  386  				     priv->hsdiv_rates[domain->parent_clk_id],
457eebe1cf0729 Peter Ujfalusi 2019-08-09  387  				     SND_SOC_CLOCK_IN);
457eebe1cf0729 Peter Ujfalusi 2019-08-09  388  
098c67f22952c2 Peter Ujfalusi 2019-08-23  389  	if (ret && ret != -ENOTSUPP) {
098c67f22952c2 Peter Ujfalusi 2019-08-23  390  		dev_err(priv->dev, "mcasp set_sysclk failed for %u Hz\n",
098c67f22952c2 Peter Ujfalusi 2019-08-23  391  			priv->hsdiv_rates[domain->parent_clk_id]);
098c67f22952c2 Peter Ujfalusi 2019-08-23  392  	} else {
098c67f22952c2 Peter Ujfalusi 2019-08-23  393  		domain->rate = params_rate(params);
098c67f22952c2 Peter Ujfalusi 2019-08-23  394  		ret = 0;
098c67f22952c2 Peter Ujfalusi 2019-08-23  395  	}
457eebe1cf0729 Peter Ujfalusi 2019-08-09  396  
457eebe1cf0729 Peter Ujfalusi 2019-08-09  397  out:
457eebe1cf0729 Peter Ujfalusi 2019-08-09  398  	mutex_unlock(&priv->mutex);

457eebe1cf0729 Peter Ujfalusi 2019-08-09 @399 return ret;
457eebe1cf0729 Peter Ujfalusi 2019-08-09 400 }
457eebe1cf0729 Peter Ujfalusi 2019-08-09 401

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation