tcp: annotate lockless access to tcp_memory_pressure
Subsystems (3)
PATCH 1/1 tcp: annotate lockless access to tcp_memory_pressure
tcp_memory_pressure is read without holding any lock, and its value could be changed on other cpus.
Use READ_ONCE() to annotate these lockless reads.
The write side is already using atomic ops.
Fixes b8da51ebb1aa ("tcp: introduce tcp_under_memory_pressure()")
Signed-off-by Eric Dumazet <[email protected]>
--- include/net/tcp.h | 2 +- net/ipv4/tcp.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
include/net/tcp.h +1 -1
@@ -258,7 +258,7 @@ static inline bool tcp_under_memory_pressure(const struct sock *sk) mem_cgroup_under_socket_pressure(sk->sk_memcg))return true; -return tcp_memory_pressure; +return READ_ONCE (tcp_memory_pressure); }/* * The next routines deal with comparing 32 bit unsigned ints
net/ipv4/tcp.c +2 -2
@@ -326,7 +326,7 @@ void tcp_enter_memory_pressure(struct sock *sk) {unsigned long val; -if (tcp_memory_pressure) +if (READ_ONCE (tcp_memory_pressure))return ; val = jiffies;
@@ -341,7 +341,7 @@ void tcp_leave_memory_pressure(struct sock *sk) {unsigned long val; -if (!tcp_memory_pressure) +if (!READ_ONCE (tcp_memory_pressure))return ; val =xchg (&tcp_memory_pressure,0 );if (val)
Signature · 1 line
2.23.0.581.g78d2f28ef7-goog
Jakub Kicinski
AppliedQuoted 9 lines · Eric Dumazet
tcp_memory_pressureis read without holding any lock, and its value could be changed on other cpus.Use
READ_ONCE()to annotate these lockless reads.The write side is already using atomic ops.
Fixes b8da51ebb1aa ("tcp: introduce tcp_under_memory_pressure()")Signed-off-by Eric Dumazet <[email protected]>
Applied, thanks!