drm/plane: Clarify our expectations for src/dst rectangles
Subsystems (2)
Maarten Lankhorst
maintainerPATCH 1/1 drm/plane: Clarify our expectations for src/dst rectangles
The rectangles are usually clipped, but it can be useful to have them unclipped, for example for cursor planes.
--- include/drm/drm_plane.h | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)
include/drm/drm_plane.h +20 -2
@@ -183,8 +183,26 @@ struct drm_plane_state {*/ struct drm_property_blob *fb_damage_clips; -/** @src: clipped source coordinates of the plane (in 16.16) */ -/** @dst: clipped destination coordinates of the plane */ +/** +* @src: +* +* source coordinates of the plane (in 16.16). +* +* When using drm_atomic_helper_check_plane_state(), +* the coordinates are clipped, but the driver may choose +* to use unclipped coordinates instead. +* +* This can be useful when using a hardcoded size in a cursor plane. +*/ +/** +* @dst: +* +* When using drm_atomic_helper_check_plane_state(), +* the coordinates are clipped, but the driver may choose +* to use unclipped coordinates instead. +* +* This can be useful when using a hardcoded size in a cursor plane. +*/ struct drm_rect src, dst;/**
Signature · 6 lines
2.23.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 18 lines · Maarten Lankhorst
The rectangles are usually clipped, but it can be useful to have them unclipped, for example for cursor planes.
Signed-off-by Maarten Lankhorst <[email protected]>--- include/drm/drm_plane.h | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)include/drm/drm_plane.h +0
-2@@ -183,8 +183,26 @@ struct drm_plane_state {*/ struct drm_property_blob *fb_damage_clips; -/** @src: clipped source coordinates of the plane (in 16.16) */ -/** @dst: clipped destination coordinates of the plane */
include/drm/drm_plane.h struct drm_plane_state { · line 195
Quoted 10 lines
include/drm/drm_plane.h +10
-0+/** +* @src: +* +* source coordinates of the plane (in 16.16). +* +* When using drm_atomic_helper_check_plane_state(), +* the coordinates are clipped, but the driver may choose +* to use unclipped coordinates instead. +* +* This can be useful when using a hardcoded size in a cursor plane.
I would instead say something like "when the hardware performs the clipping automagically".
Quoted 20 lines
include/drm/drm_plane.h +10
-0+*/ +/** +* @dst: +* +* When using drm_atomic_helper_check_plane_state(), +* the coordinates are clipped, but the driver may choose +* to use unclipped coordinates instead. +* +* This can be useful when using a hardcoded size in a cursor plane. +*/ struct drm_rect src, dst;/** Signature · 6 lines
2.23.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maarten Lankhorst
maintainerOp 10-10-2019 om 14:36 schreef Ville Syrjälä:
Quoted 17 lines · Maarten Lankhorst
Quoted 16 lines
The rectangles are usually clipped, but it can be useful to have them unclipped, for example for cursor planes.
Signed-off-by Maarten Lankhorst <[email protected]>--- include/drm/drm_plane.h | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)include/drm/drm_plane.h +0
-0@@ -183,8 +183,26 @@ struct drm_plane_state {*/ struct drm_property_blob *fb_damage_clips;
Quoted 14 lines
include/drm/drm_plane.h struct drm_plane_state { · line 195
Quoted 12 lines
include/drm/drm_plane.h +10
-2-/** @src: clipped source coordinates of the plane (in 16.16) */ -/** @dst: clipped destination coordinates of the plane */ +/** +* @src: +* +* source coordinates of the plane (in 16.16). +* +* When using drm_atomic_helper_check_plane_state(), +* the coordinates are clipped, but the driver may choose +* to use unclipped coordinates instead. +* +* This can be useful when using a hardcoded size in a cursor plane. I would instead say something like "when the hardware performs the clipping automagically".
With that fixed, r-b?
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Ville Syrjälä
Reviewed-byQuoted 34 lines · Maarten Lankhorst
Op 10-10-2019 om 14:36 schreef Ville Syrjälä:
Quoted 17 lines · Maarten Lankhorst
Quoted 16 lines
The rectangles are usually clipped, but it can be useful to have them unclipped, for example for cursor planes.
Signed-off-by Maarten Lankhorst <[email protected]>--- include/drm/drm_plane.h | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)include/drm/drm_plane.h +0
-0@@ -183,8 +183,26 @@ struct drm_plane_state {*/ struct drm_property_blob *fb_damage_clips;Quoted 14 lines
include/drm/drm_plane.h struct drm_plane_state { · line 195
Quoted 12 lines
include/drm/drm_plane.h +10
-2-/** @src: clipped source coordinates of the plane (in 16.16) */ -/** @dst: clipped destination coordinates of the plane */ +/** +* @src: +* +* source coordinates of the plane (in 16.16). +* +* When using drm_atomic_helper_check_plane_state(), +* the coordinates are clipped, but the driver may choose +* to use unclipped coordinates instead. +* +* This can be useful when using a hardcoded size in a cursor plane. I would instead say something like "when the hardware performs the clipping automagically".
Quoted 1 line
With that fixed, r-b?
Aye
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maarten Lankhorst
maintainerOp 10-10-2019 om 15:07 schreef Ville Syrjälä:
Quoted 34 lines · Maarten Lankhorst
Quoted 33 lines
Op 10-10-2019 om 14:36 schreef Ville Syrjälä:
Quoted 31 lines · Maarten Lankhorst
Quoted 18 lines
The rectangles are usually clipped, but it can be useful to have them unclipped, for example for cursor planes.
Signed-off-by Maarten Lankhorst <[email protected]>--- include/drm/drm_plane.h | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)include/drm/drm_plane.h +0
-2@@ -183,8 +183,26 @@ struct drm_plane_state {*/ struct drm_property_blob *fb_damage_clips; -/** @src: clipped source coordinates of the plane (in 16.16) */ -/** @dst: clipped destination coordinates of the plane */ include/drm/drm_plane.h struct drm_plane_state { · line 195
Quoted 10 lines
include/drm/drm_plane.h +10
-0+/** +* @src: +* +* source coordinates of the plane (in 16.16). +* +* When using drm_atomic_helper_check_plane_state(), +* the coordinates are clipped, but the driver may choose +* to use unclipped coordinates instead. +* +* This can be useful when using a hardcoded size in a cursor plane. I would instead say something like "when the hardware performs the clipping automagically".
Quoted 5 lines
Quoted 1 line
With that fixed, r-b?
Aye
Reviewed-by Ville Syrjälä <[email protected]>
Noticed I dropped the explanation for dst when checking docbook output, fixed and pushed. :)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel