tests: fix counting typo error
PATCH 1/1 tests: fix counting typo error
Instead of global variables, local variables should be incrementing, This is a typo fix.
Signed-off-by Tianjia Zhang <[email protected]>
--- tests/test-rcu-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/test-rcu-list.c +1 -1
@@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg) j++;if (target_el == j) { struct list_element *new_el = g_new(struct list_element, 1); - n_nodes += n_nodes_local; + n_nodes_local++;TEST_LIST_INSERT_AFTER_RCU (el, new_el, entry);break ; }
Signature · 1 line
2.17.1
Quoted 7 lines · Tianjia Zhang
Instead of global variables, local variables should be incrementing, This is a typo fix.
Signed-off-by Tianjia Zhang <[email protected]>--- tests/test-rcu-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
CCing Paolo Bonzini, author of the RCU code.
Quoted 18 lines
tests/test-rcu-list.c +1
-1@@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg) j++;if (target_el == j) { struct list_element *new_el = g_new(struct list_element, 1); - n_nodes += n_nodes_local; + n_nodes_local++;TEST_LIST_INSERT_AFTER_RCU (el, new_el, entry);break ; }Signature · 1 line
2.17.1
Quoted 2 lines · Tianjia Zhang
Instead of global variables, local variables should be incrementing, This is a typo fix.
Impact?
The commit message calls it a "typo", which suggests there is none. The patch makes me suspect the bug is more serious than that.
Quoted 19 lines
Signed-off-by Tianjia Zhang <[email protected]>--- tests/test-rcu-list.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/test-rcu-list.c +1
-1@@ -219,7 +219,7 @@ static void *rcu_q_updater(void *arg) j++;if (target_el == j) { struct list_element *new_el = g_new(struct list_element, 1); - n_nodes += n_nodes_local; + n_nodes_local++;TEST_LIST_INSERT_AFTER_RCU (el, new_el, entry);break ; }