drm/i915: Shrink eDRAM ways/sets arrays
Subsystems (3)
PATCH 1/5 drm/i915: Shrink eDRAM ways/sets arrays
From: Ville Syrjälä <[email protected]>
Make the ways/sets arrays static cosnt u8 to shrink things a bit.
text data bss dec hex filename - 23935 629 128 24692 6074 i915_drv.o + 23818 629 128 24575 5fff i915_drv.o
--- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_drv.c +2 -2
@@ -1073,8 +1073,8 @@ intel_get_dram_info(struct drm_i915_private *dev_priv)static u32 gen9_edram_size_mb (struct drm_i915_private *dev_priv,u32 cap) { -const unsigned int ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; -const unsigned int sets[4 ] = {1 ,1 ,2 ,2 }; +static const u8 ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; +static const u8 sets[4 ] = {1 ,1 ,2 ,2 };return EDRAM_NUM_BANKS (cap) * ways[EDRAM_WAYS_IDX(cap)] *
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/5 drm/i915: s/hdcp2_hdmi_msg_data/hdcp2_hdmi_msg_timeout/
From: Ville Syrjälä <[email protected]>
The array is there only for timeout, "data" doesn't mean anything so let's rename the thing to be more descriptive.
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/display/intel_hdmi.c +7 -7
@@ -1527,13 +1527,13 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)return true; } -struct hdcp2_hdmi_msg_data { +struct hdcp2_hdmi_msg_timeout {u8 msg_id;u32 timeout;u32 timeout2; }; -static const struct hdcp2_hdmi_msg_data hdcp2_msg_data[] = { +static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = { {HDCP_2_2_AKE_INIT ,0 ,0 }, {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, {HDCP_2_2_AKE_NO_STORED_KM ,0 ,0 },
@@ -1564,12 +1564,12 @@ static int get_hdcp2_msg_timeout(u8 msg_id, bool is_paired) {int i; -for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_data); i++) -if (hdcp2_msg_data[i].msg_id == msg_id && +for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_timeout); i++) +if (hdcp2_msg_timeout[i].msg_id == msg_id && (msg_id !=HDCP_2_2_AKE_SEND_HPRIME || is_paired)) -return hdcp2_msg_data[i].timeout; -else if (hdcp2_msg_data[i].msg_id == msg_id) -return hdcp2_msg_data[i].timeout2; +return hdcp2_msg_timeout[i].timeout; +else if (hdcp2_msg_timeout[i].msg_id == msg_id) +return hdcp2_msg_timeout[i].timeout2;return -EINVAL ; }
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/5] drm/i915: s/hdcp2_hdmi_msg_data/hdcp2_hdmi_msg_timeout/
Quoted 6 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
The array is there only for timeout, "data" doesn't mean anything so let's rename the thing to be more descriptive.
Signed-off-by Ville Syrjälä <[email protected]>
Looks good to me.
Quoted 49 lines
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)drivers/gpu/drm/i915/display/intel_hdmi.c +7
-7@@ -1527,13 +1527,13 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)return true; } -struct hdcp2_hdmi_msg_data { +struct hdcp2_hdmi_msg_timeout {u8 msg_id;u32 timeout;u32 timeout2; }; -static const struct hdcp2_hdmi_msg_data hdcp2_msg_data[] = { +static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = { {HDCP_2_2_AKE_INIT ,0 ,0 }, {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, {HDCP_2_2_AKE_NO_STORED_KM ,0 ,0 },@@ -1564,12 +1564,12 @@ static int get_hdcp2_msg_timeout(u8 msg_id, bool is_paired) {int i; -for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_data); i++) -if (hdcp2_msg_data[i].msg_id == msg_id && +for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_timeout); i++) +if (hdcp2_msg_timeout[i].msg_id == msg_id && (msg_id !=HDCP_2_2_AKE_SEND_HPRIME || is_paired)) -return hdcp2_msg_data[i].timeout; -else if (hdcp2_msg_data[i].msg_id == msg_id) -return hdcp2_msg_data[i].timeout2; +return hdcp2_msg_timeout[i].timeout; +else if (hdcp2_msg_timeout[i].msg_id == msg_id) +return hdcp2_msg_timeout[i].timeout2;return -EINVAL ; }Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/5 drm/i915: Remove dead weight from hdcp2_msg_timeout[]
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
The .read_2_2() hooks is never called for any of the message types with a zero timeout. So it's all just dead weight which we can chuck.
text data bss dec hex filename
- 34701 360 0 35061 88f5 intel_hdmi.o + 34633 360 0 34993 88b1 intel_hdmi.o
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/gpu/drm/i915/display/intel_hdmi.c +0 -7
@@ -1534,19 +1534,12 @@ struct hdcp2_hdmi_msg_timeout { };static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = { - {HDCP_2_2_AKE_INIT ,0 ,0 }, {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, - {HDCP_2_2_AKE_NO_STORED_KM ,0 ,0 }, - {HDCP_2_2_AKE_STORED_KM ,0 ,0 }, {HDCP_2_2_AKE_SEND_HPRIME ,HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS ,HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS }, {HDCP_2_2_AKE_SEND_PAIRING_INFO ,HDCP_2_2_PAIRING_TIMEOUT_MS ,0 }, - {HDCP_2_2_LC_INIT ,0 ,0 }, {HDCP_2_2_LC_SEND_LPRIME ,HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS ,0 }, - {HDCP_2_2_SKE_SEND_EKS ,0 ,0 }, {HDCP_2_2_REP_SEND_RECVID_LIST ,HDCP_2_2_RECVID_LIST_TIMEOUT_MS ,0 }, - {HDCP_2_2_REP_SEND_ACK ,0 ,0 }, - {HDCP_2_2_REP_STREAM_MANAGE ,0 ,0 }, {HDCP_2_2_REP_STREAM_READY ,HDCP_2_2_STREAM_READY_TIMEOUT_MS ,0 }, };
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/5] drm/i915: Remove dead weight from hdcp2_msg_timeout[]
Quoted 11 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
The .read_2_2() hooks is never called for any of the message types with a zero timeout. So it's all just dead weight which we can chuck.
text data bss dec hex filename
(quoted diff) +1
-1- 34701 360 0 35061 88f5 intel_hdmi.o + 34633 360 0 34993 88b1 intel_hdmi.oSigned-off-by Ville Syrjälä <[email protected]>
Timeout is added for supporting msgs read. These msgs with 0 timeout are only written. Hence can be removed from the timeout table.
Quoted 35 lines
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 7 ------- 1 file changed, 7 deletions(-)drivers/gpu/drm/i915/display/intel_hdmi.c +0
-7@@ -1534,19 +1534,12 @@ struct hdcp2_hdmi_msg_timeout { };static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = { - {HDCP_2_2_AKE_INIT ,0 ,0 }, {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, - {HDCP_2_2_AKE_NO_STORED_KM ,0 ,0 }, - {HDCP_2_2_AKE_STORED_KM ,0 ,0 }, {HDCP_2_2_AKE_SEND_HPRIME ,HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS ,HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS }, {HDCP_2_2_AKE_SEND_PAIRING_INFO ,HDCP_2_2_PAIRING_TIMEOUT_MS ,0 }, - {HDCP_2_2_LC_INIT ,0 ,0 }, {HDCP_2_2_LC_SEND_LPRIME ,HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS ,0 }, - {HDCP_2_2_SKE_SEND_EKS ,0 ,0 }, {HDCP_2_2_REP_SEND_RECVID_LIST ,HDCP_2_2_RECVID_LIST_TIMEOUT_MS ,0 }, - {HDCP_2_2_REP_SEND_ACK ,0 ,0 }, - {HDCP_2_2_REP_STREAM_MANAGE ,0 ,0 }, {HDCP_2_2_REP_STREAM_READY ,HDCP_2_2_STREAM_READY_TIMEOUT_MS ,0 }, };Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/5 drm/i915: Remove hdcp2_hdmi_msg_timeout.timeout2
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
The only reason for the timeout2 value in the array is the HDCP_2_2_AKE_SEND_HPRIME message. But that one still needs special casing inside the loop, and so just ends up making the code harder to read. Let's just remove this leaky timeout2 abstraction and special case that one command in a way that is easy to understand. We can then remove the timeout2 member from struct entirely.
text data bss dec hex filename
- 34633 360 0 34993 88b1 intel_hdmi.o + 34521 360 0 34881 8841 intel_hdmi.o
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 28 ++++++++++++----------- 1 file changed, 15 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/display/intel_hdmi.c +15 -13
@@ -1530,17 +1530,14 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)struct hdcp2_hdmi_msg_timeout {u8 msg_id;u32 timeout; -u32 timeout2; };static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = { - {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, - {HDCP_2_2_AKE_SEND_HPRIME ,HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS , -HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS }, - {HDCP_2_2_AKE_SEND_PAIRING_INFO ,HDCP_2_2_PAIRING_TIMEOUT_MS ,0 }, - {HDCP_2_2_LC_SEND_LPRIME ,HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS ,0 }, - {HDCP_2_2_REP_SEND_RECVID_LIST ,HDCP_2_2_RECVID_LIST_TIMEOUT_MS ,0 }, - {HDCP_2_2_REP_STREAM_READY ,HDCP_2_2_STREAM_READY_TIMEOUT_MS ,0 }, + {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS , }, + {HDCP_2_2_AKE_SEND_PAIRING_INFO ,HDCP_2_2_PAIRING_TIMEOUT_MS , }, + {HDCP_2_2_LC_SEND_LPRIME ,HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS , }, + {HDCP_2_2_REP_SEND_RECVID_LIST ,HDCP_2_2_RECVID_LIST_TIMEOUT_MS , }, + {HDCP_2_2_REP_STREAM_READY ,HDCP_2_2_STREAM_READY_TIMEOUT_MS , }, }; static
@@ -1557,12 +1554,17 @@ static int get_hdcp2_msg_timeout(u8 msg_id, bool is_paired) {int i; -for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_timeout); i++) -if (hdcp2_msg_timeout[i].msg_id == msg_id && - (msg_id !=HDCP_2_2_AKE_SEND_HPRIME || is_paired)) +if (msg_id ==HDCP_2_2_AKE_SEND_HPRIME ) { +if (is_paired) +return HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS ; +else +return HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS ; + } + +for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_timeout); i++) { +if (hdcp2_msg_timeout[i].msg_id == msg_id)return hdcp2_msg_timeout[i].timeout; -else if (hdcp2_msg_timeout[i].msg_id == msg_id) -return hdcp2_msg_timeout[i].timeout2; + }return -EINVAL ; }
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 4/5] drm/i915: Remove hdcp2_hdmi_msg_timeout.timeout2
Quoted 9 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
The only reason for the timeout2 value in the array is the
HDCP_2_2_AKE_SEND_HPRIMEmessage. But that one still needs special casing inside the loop, and so just ends up making the code harder to read. Let's just remove this leaky timeout2 abstraction and special case that one command in a way that is easy to understand. We can then remove the timeout2 member from struct entirely.
Looks good to me.
Quoted 67 lines
text data bss dec hex filename
(quoted diff) +1
-1- 34633 360 0 34993 88b1 intel_hdmi.o + 34521 360 0 34881 8841 intel_hdmi.oSigned-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/display/intel_hdmi.c | 28 ++++++++++++----------- 1 file changed, 15 insertions(+), 13 deletions(-)drivers/gpu/drm/i915/display/intel_hdmi.c +15
-13@@ -1530,17 +1530,14 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)struct hdcp2_hdmi_msg_timeout {u8 msg_id;u32 timeout; -u32 timeout2; };static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = { - {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS ,0 }, - {HDCP_2_2_AKE_SEND_HPRIME ,HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS , -HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS }, - {HDCP_2_2_AKE_SEND_PAIRING_INFO ,HDCP_2_2_PAIRING_TIMEOUT_MS ,0 }, - {HDCP_2_2_LC_SEND_LPRIME ,HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS ,0 }, - {HDCP_2_2_REP_SEND_RECVID_LIST ,HDCP_2_2_RECVID_LIST_TIMEOUT_MS ,0 }, - {HDCP_2_2_REP_STREAM_READY ,HDCP_2_2_STREAM_READY_TIMEOUT_MS ,0 }, + {HDCP_2_2_AKE_SEND_CERT ,HDCP_2_2_CERT_TIMEOUT_MS , }, + {HDCP_2_2_AKE_SEND_PAIRING_INFO ,HDCP_2_2_PAIRING_TIMEOUT_MS , }, + {HDCP_2_2_LC_SEND_LPRIME ,HDCP_2_2_HDMI_LPRIME_TIMEOUT_MS , }, + {HDCP_2_2_REP_SEND_RECVID_LIST ,HDCP_2_2_RECVID_LIST_TIMEOUT_MS , }, + {HDCP_2_2_REP_STREAM_READY ,HDCP_2_2_STREAM_READY_TIMEOUT_MS , }, }; static@@ -1557,12 +1554,17 @@ static int get_hdcp2_msg_timeout(u8 msg_id, bool is_paired) {int i; -for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_timeout); i++) -if (hdcp2_msg_timeout[i].msg_id == msg_id && - (msg_id !=HDCP_2_2_AKE_SEND_HPRIME || is_paired)) +if (msg_id ==HDCP_2_2_AKE_SEND_HPRIME ) { +if (is_paired) +return HDCP_2_2_HPRIME_PAIRED_TIMEOUT_MS ; +else +return HDCP_2_2_HPRIME_NO_PAIRED_TIMEOUT_MS ; + } + +for (i =0 ; i <ARRAY_SIZE (hdcp2_msg_timeout); i++) { +if (hdcp2_msg_timeout[i].msg_id == msg_id)return hdcp2_msg_timeout[i].timeout; -else if (hdcp2_msg_timeout[i].msg_id == msg_id) -return hdcp2_msg_timeout[i].timeout2; + }return -EINVAL ; }Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/5 drm/i915: Make hdcp2_msg_timeout.timeout u16
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
All the timeout values fit in u16, so let's shrink the structure a bit.
This ends up actually increasing the .text size a bit due to some changes in instructions (constant imul+small jmps replaced with mov+bigger jmpqs). Seems pretty arbitrary to me so I'll just pretend I didn't see it.
text data bss dec hex filename
- 34521 360 0 34881 8841 intel_hdmi.o + 34537 360 0 34897 8851 intel_hdmi.o
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_hdmi.c +1 -1
@@ -1529,7 +1529,7 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)struct hdcp2_hdmi_msg_timeout {u8 msg_id; -u32 timeout; +u16 timeout; };static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = {
Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/5] drm/i915: Make hdcp2_msg_timeout.timeout u16
Quoted 14 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
All the timeout values fit in u16, so let's shrink the structure a bit.
This ends up actually increasing the .text size a bit due to some changes in instructions (constant imul+small jmps replaced with mov+bigger jmpqs). Seems pretty arbitrary to me so I'll just pretend I didn't see it.
text data bss dec hex filename
(quoted diff) +1
-1- 34521 360 0 34881 8841 intel_hdmi.o + 34537 360 0 34897 8851 intel_hdmi.o
Quoted 1 line
Signed-off-by Ville Syrjälä <[email protected]>
Looks Good to me.
Quoted 24 lines
--- drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_hdmi.c +1
-1@@ -1529,7 +1529,7 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)struct hdcp2_hdmi_msg_timeout {u8 msg_id; -u32 timeout; +u16 timeout; };static const struct hdcp2_hdmi_msg_timeout hdcp2_msg_timeout[] = {Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Shrink eDRAM ways/sets arrays
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Shrink eDRAM ways/sets arrays
URL : https://patchwork.freedesktop.org/series/67853/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7056 -> Patchwork_14752
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14752 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_14752, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14752:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_hangcheck:
- fi-hsw-4770r: [PASS][1] -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7056/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
Known issues
------------
Here are the changes found in Patchwork_14752 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-bxt-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7056/fi-bxt-dsi/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/fi-bxt-dsi/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][5] -> [INCOMPLETE][6] ([fdo#107718])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7056/fi-blb-e6850/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/fi-blb-e6850/igt@[email protected]
* igt@gem_mmap_gtt@basic-write-read-distinct:
- fi-icl-u3: [PASS][7] -> [DMESG-WARN][8] ([fdo#107724]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7056/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- {fi-icl-dsi}: [INCOMPLETE][9] ([fdo#107713]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7056/fi-icl-dsi/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/fi-icl-dsi/igt@[email protected]
* igt@i915_selftest@live_execlists:
- {fi-icl-guc}: [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7056/fi-icl-guc/igt@i915_selftest@live_execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/fi-icl-guc/igt@i915_selftest@live_execlists.html
* igt@kms_addfb_basic@unused-modifier:
- fi-icl-u3: [DMESG-WARN][13] ([fdo#107724]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7056/fi-icl-u3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/fi-icl-u3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
Participating hosts (54 -> 47)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7056 -> Patchwork_14752
CI-20190529: 20190529
CI_DRM_7056: 589ed9c309ff4c26532bbc7ac6dcce9514bbd1e9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5220: 1e38e32d721210a780198c8293a6b8c8e881df68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14752: 770d7f9be1dc476e8774a91addc34b7099ff1772 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
770d7f9be1dc drm/i915: Make hdcp2_msg_timeout.timeout u16 24c9ff1cca7e drm/i915: Remove hdcp2_hdmi_msg_timeout.timeout2 7e072255546e drm/i915: Remove dead weight from hdcp2_msg_timeout[] d958cb47d4ac drm/i915: s/hdcp2_hdmi_msg_data/hdcp2_hdmi_msg_timeout/ 64800ed28892 drm/i915: Shrink eDRAM ways/sets arrays
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14752/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 18 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Make the ways/sets arrays static cosnt u8 to shrink things a bit.
text data bss dec hex filename
(quoted diff) +1
-1- 23935 629 128 24692 6074 i915_drv.o + 23818 629 128 24575 5fff i915_drv.oSigned-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_drv.c +0
-0
drivers/gpu/drm/i915/i915_drv.c intel_get_dram_info(struct drm_i915_private *dev_priv) · line 1077
Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.c +2
-2@@ -1073,8 +1073,8 @@ intel_get_dram_info(struct drm_i915_private *dev_priv)static u32 gen9_edram_size_mb (struct drm_i915_private *dev_priv,u32 cap) { -const unsigned int ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; -const unsigned int sets[4 ] = {1 ,1 ,2 ,2 }; +static const u8 ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; +static const u8 sets[4 ] = {1 ,1 ,2 ,2 };
Asking for my understanding. unsigned int -> u8 make sense to shrink the size. Could you please add reasoning for adding static? moving it into data segment hence reducing the stack?
-Ram
Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.c +0
-0return EDRAM_NUM_BANKS (cap) * ways[EDRAM_WAYS_IDX(cap)] *Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 20 lines · Ramalingam C
Quoted 19 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Make the ways/sets arrays static cosnt u8 to shrink things a bit.
text data bss dec hex filename
(quoted diff) +1
-1- 23935 629 128 24692 6074 i915_drv.o + 23818 629 128 24575 5fff i915_drv.oSigned-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_drv.c +0
-0@@ -1073,8 +1073,8 @@ intel_get_dram_info(struct drm_i915_private *dev_priv)
Quoted 9 lines
drivers/gpu/drm/i915/i915_drv.c intel_get_dram_info(struct drm_i915_private *dev_priv) · line 1077
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.c +2
-2static u32 gen9_edram_size_mb (struct drm_i915_private *dev_priv,u32 cap) { -const unsigned int ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; -const unsigned int sets[4 ] = {1 ,1 ,2 ,2 }; +static const u8 ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; +static const u8 sets[4 ] = {1 ,1 ,2 ,2 };Asking for my understanding. unsigned int -> u8 make sense to shrink the size. Could you please add reasoning for adding static? moving it into data segment hence reducing the stack?
Possibly. My usual approach is to just make all such things static const unless there is a real reason not to.
Quoted 12 lines
-Ram
Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.c +0
-0return EDRAM_NUM_BANKS (cap) * ways[EDRAM_WAYS_IDX(cap)] *Signature · 6 lines
2.21.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Ramalingam C
Reviewed-byQuoted 11 lines · Ville Syrjälä
Quoted 10 lines · Ramalingam C
Quoted 9 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Make the ways/sets arrays static cosnt u8 to shrink things a bit.
text data bss dec hex filename
(quoted diff) +1
-1- 23935 629 128 24692 6074 i915_drv.o + 23818 629 128 24575 5fff i915_drv.oSigned-off-by Ville Syrjälä <[email protected]>
Looks good to me.
Quoted 20 lines
Quoted 10 lines
Quoted 10 lines
--- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/i915_drv.c +0
-0@@ -1073,8 +1073,8 @@ intel_get_dram_info(struct drm_i915_private *dev_priv)Quoted 9 lines
drivers/gpu/drm/i915/i915_drv.c intel_get_dram_info(struct drm_i915_private *dev_priv) · line 1077
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.c +2
-2static u32 gen9_edram_size_mb (struct drm_i915_private *dev_priv,u32 cap) { -const unsigned int ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; -const unsigned int sets[4 ] = {1 ,1 ,2 ,2 }; +static const u8 ways[8 ] = {4 ,8 ,12 ,16 ,16 ,16 ,16 ,16 }; +static const u8 sets[4 ] = {1 ,1 ,2 ,2 };Asking for my understanding. unsigned int -> u8 make sense to shrink the size. Could you please add reasoning for adding static? moving it into data segment hence reducing the stack?
Quoted 2 lines
Possibly. My usual approach is to just make all such things static const unless there is a real reason not to.
Ok. Thanks.
-Ram
Quoted 9 lines
Quoted 9 lines
-Ram
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.c +0
-0return EDRAM_NUM_BANKS (cap) * ways[EDRAM_WAYS_IDX(cap)] *Signature · 1 line
2.21.0
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx