Skip to contentSkip to conversation

package/vtun: fix static linking with atomic

PATCH New Fabrice Fontaine 3 participants 3 messages Oct 10, 2019 – Oct 28, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/vtun: fix static linking with atomic

Fixes:
- http://autobuild.buildroot.org/results/908707cdd16c5b89197c226a3e259f8943a5474e

---
 package/vtun/vtun.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
package/vtun/vtun.mk +5 -1
index 86d452c0c2..35b0ddedbb 100644
@@ -8,7 +8,7 @@ VTUN_VERSION = 3.0.4
 VTUN_SITE = http://downloads.sourceforge.net/project/vtun/vtun/$(VTUN_VERSION)
 VTUN_LICENSE = GPL-2.0+ with OpenSSL exception
 VTUN_LICENSE_FILES = README.OpenSSL
-VTUN_DEPENDENCIES = host-bison host-flex zlib lzo openssl
+VTUN_DEPENDENCIES = host-bison host-flex host-pkgconf zlib lzo openssl
 VTUN_AUTORECONF = YES
 
 VTUN_CONF_OPTS = \
@@ -19,4 +19,8 @@ VTUN_CONF_OPTS = \
 # Assumes old-style gcc inline symbol visibility rules
 VTUN_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -std=gnu89"
 
+# configure.in forgets to link to dependent libraries of openssl breaking static
+# linking
+VTUN_CONF_ENV += LIBS=`$(PKG_CONFIG_HOST_BINARY) --libs openssl`
+
 $(eval $(autotools-package))
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/vtun: fix static linking with atomic

Quoted 7 lines · On Thu, 10 Oct 2019 19:56:28 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/908707cdd16c5b89197c226a3e259f8943a5474e

---
 package/vtun/vtun.mk | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Applied to master, thanks. However, it would really be nicer for the upstream configure.in to use pkg-config if available, not just for OpenSSL, but also for its other dependencies.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com