Skip to contentSkip to conversation

drm/dp: Remove the unused drm_device to get rid of build warning

PATCH In review Manasi Navare 3 participants 4 messages Oct 10, 2019 – Oct 11, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/dp: Remove the unused drm_device to get rid of build warning

We no longer use the connection mutex and hence no need to define drm_device *dev, it causes a unused variable build warning

Fixes 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
Cc Sean Paul <[email protected]>
Cc Lyude Paul <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/drm_dp_mst_topology.c +0 -2
index 9364e4f42975..9cccc5e63309 100644
@@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
 struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
 								    struct drm_dp_mst_topology_mgr *mgr)
 {
-	struct drm_device *dev = mgr->dev;
-
 	return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
 }
 EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
Signature · 6 lines
2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.SPARSE: warning for drm/dp: Remove the unused drm_device to get rid of build warning

== Series Details ==

== Series Details ==

Series: drm/dp: Remove the unused drm_device to get rid of build warning
URL : https://patchwork.freedesktop.org/series/67879/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/dp: Remove the unused drm_device to get rid of build warning
-                     ^~~
-drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_atomic_get_mst_topology_state’:
-O:drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable ‘dev’ [-Wunused-variable]
-  struct drm_device *dev = mgr->dev;
+

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✗ Fi.CI.BAT: failure for drm/dp: Remove the unused drm_device to get rid of build warning

In reply to Manasi Navare
== Series Details ==

== Series Details ==

Series: drm/dp: Remove the unused drm_device to get rid of build warning
URL : https://patchwork.freedesktop.org/series/67879/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7058 -> Patchwork_14760
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_14760 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_14760, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_14760:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live_hugepages:
- fi-snb-2520m: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-snb-2520m/igt@i915_selftest@live_hugepages.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-snb-2520m/igt@i915_selftest@live_hugepages.html

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live_coherency:
- {fi-kbl-soraka}: [INCOMPLETE][3] -> [TIMEOUT][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-kbl-soraka/igt@i915_selftest@live_coherency.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-kbl-soraka/igt@i915_selftest@live_coherency.html

* igt@runner@aborted:
- {fi-cml-s}: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-cml-s/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_14760 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_switch@rcs0:
- fi-bxt-dsi: [PASS][6] -> [INCOMPLETE][7] ([fdo#103927])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-bxt-dsi/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-bxt-dsi/igt@[email protected]

* igt@gem_mmap_gtt@basic-copy:
- fi-icl-u3: [PASS][8] -> [DMESG-WARN][9] ([fdo#107724])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-icl-u3/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_hangcheck:
- fi-icl-u2: [PASS][10] -> [INCOMPLETE][11] ([fdo#107713] / [fdo#108569])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-icl-u2/igt@i915_selftest@live_hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-icl-u2/igt@i915_selftest@live_hangcheck.html

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][12] -> [DMESG-WARN][13] ([fdo#102614])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-hsw-peppy/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-hsw-peppy/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic:
- {fi-icl-guc}: [FAIL][14] ([fdo#111699]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-icl-guc/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-icl-guc/igt@[email protected]

* igt@gem_mmap_gtt@basic-small-bo-tiledy:
- {fi-icl-dsi}: [DMESG-WARN][16] ([fdo#106107]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-icl-dsi/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-icl-dsi/igt@[email protected]

* igt@gem_mmap_gtt@basic-write-cpu-read-gtt:
- fi-icl-u3: [DMESG-WARN][18] ([fdo#107724]) -> [PASS][19] +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7058/fi-icl-u3/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/fi-icl-u3/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#111699]: https://bugs.freedesktop.org/show_bug.cgi?id=111699
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764

Participating hosts (54 -> 47)
------------------------------

Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7058 -> Patchwork_14760

CI-20190529: 20190529
CI_DRM_7058: ec85c0501ada08c2aea8adb7da74931a6d0ae39b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5220: 1e38e32d721210a780198c8293a6b8c8e881df68 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14760: fbfc59d0d6e54813d18df1ce921ebdaffbbd1944 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

fbfc59d0d6e5 drm/dp: Remove the unused drm_device to get rid of build warning

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14760/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#3 lore raw
In reply to Manasi Navare
Quoted 5 lines · Manasi Navare

We no longer use the connection mutex and hence no need to define drm_device *dev, it causes a unused variable build warning

Fixes 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")
Cc Sean Paul <[email protected]>
Quoted 23 lines
Cc Lyude Paul <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 drivers/gpu/drm/drm_dp_mst_topology.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/drm_dp_mst_topology.c +0 -2
index 9364e4f42975..9cccc5e63309 100644
@@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);
 struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state(struct drm_atomic_state *state,
 								    struct drm_dp_mst_topology_mgr *mgr)
 {
-	struct drm_device *dev = mgr->dev;
-
 	return to_dp_mst_topology_state(drm_atomic_get_private_obj_state(state, &mgr->base));
 }
 EXPORT_SYMBOL(drm_atomic_get_mst_topology_state);
Signature · 1 line
2.19.1
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx