Skip to contentSkip to conversation

libbpf: handle invalid typedef emitted by old GCC

PATCH Applied Andrii Nakryiko 4 participants 4 messages Oct 11, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libbpf: handle invalid typedef emitted by old GCC

Old GCC versions are producing invalid typedef for __gnuc_va_list pointing to void. Special-case this and emit valid:

typedef __builtin_va_list __gnuc_va_list;

---
 tools/lib/bpf/btf_dump.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
tools/lib/bpf/btf_dump.c +11 -0
index 87f27e2664c5..139812b46c7b 100644
@@ -975,6 +975,17 @@ static void btf_dump_emit_typedef_def(struct btf_dump *d, __u32 id,
 {
 	const char *name = btf_dump_ident_name(d, id);
 
+	/*
+	 * Old GCC versions are emitting invalid typedef for __gnuc_va_list
+	 * pointing to VOID. This generates warnings from btf_dump() and
+	 * results in uncompilable header file, so we are fixing it up here
+	 * with valid typedef into __builtin_va_list.
+	 */
+	if (t->type == 0 && strcmp(name, "__gnuc_va_list") == 0) {
+		btf_dump_printf(d, "typedef __builtin_va_list __gnuc_va_list");
+		return;
+	}
+
 	btf_dump_printf(d, "typedef ");
 	btf_dump_emit_type_decl(d, t->type, name, lvl);
 }
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Andrii Nakryiko

Old GCC versions are producing invalid typedef for __gnuc_va_list pointing to void. Special-case this and emit valid:

typedef __builtin_va_list __gnuc_va_list;