Skip to contentSkip to conversation

libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping

PATCH Applied Petr Lautrbach 3 participants 4 messages Oct 11, 2019 – Oct 17, 2019 SELinux security module

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping

There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize kernel policy") which added new function sepol_policydb_optimize(), but there's sepol_optimize_policy in libsepol.map.

LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0

---
 libsepol/src/libsepol.map.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
libsepol/src/libsepol.map.in +2 -2
index 6358e51f..f4946a79 100644
@@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
 	sepol_polcap_getname;
 } LIBSEPOL_1.0;
 
-LIBSEPOL_1.2 {
+LIBSEPOL_3.0 {
   global:
-	sepol_optimize_policy;
+	sepol_policydb_optimize;
 } LIBSEPOL_1.1;
Signature · 1 line
2.23.0
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Petr Lautrbach

There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize kernel policy") which added new function sepol_policydb_optimize(), but there's sepol_optimize_policy in libsepol.map.

LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0

Thanks for spotting it!

Quoted 21 lines
---
 libsepol/src/libsepol.map.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
libsepol/src/libsepol.map.in +2 -3
index 6358e51f..f4946a79 100644
@@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
        sepol_polcap_getname;
 } LIBSEPOL_1.0;
 
-LIBSEPOL_1.2 {
+LIBSEPOL_3.0 {
   global:
-       sepol_optimize_policy;
+       sepol_policydb_optimize;
 } LIBSEPOL_1.1;
--

2.23.0

Signature · 3 lines
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.
Acked-by on v1 1/1
#2 lore raw
In reply to Petr Lautrbach
Quoted 7 lines · Petr Lautrbach

There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize kernel policy") which added new function sepol_policydb_optimize(), but there's sepol_optimize_policy in libsepol.map.

LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0

Quoted 19 lines
---
  libsepol/src/libsepol.map.in | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
libsepol/src/libsepol.map.in +2 -2
index 6358e51f..f4946a79 100644
@@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
  	sepol_polcap_getname;
  } LIBSEPOL_1.0;
 
-LIBSEPOL_1.2 {
+LIBSEPOL_3.0 {
    global:
-	sepol_optimize_policy;
+	sepol_policydb_optimize;
  } LIBSEPOL_1.1;
#3 lore raw
Quoted 10 lines · Stephen Smalley
Quoted 7 lines · Petr Lautrbach

There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize kernel policy") which added new function sepol_policydb_optimize(), but there's sepol_optimize_policy in libsepol.map.

LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0

Thanks, applied.

Quoted 20 lines
Quoted 19 lines

---
  libsepol/src/libsepol.map.in | 4 ++--

  1 file changed, 2 insertions(+), 2 deletions(-)
libsepol/src/libsepol.map.in +1 -1
index 6358e51f..f4946a79 100644
@@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
       sepol_polcap_getname;
   } LIBSEPOL_1.0;
-LIBSEPOL_1.2 {
+LIBSEPOL_3.0 {

    global:
-    sepol_optimize_policy;
+    sepol_policydb_optimize;
  } LIBSEPOL_1.1;