serial: 8250_exar: Move Exar pieces to custom ->startup()
PATCH 1/1 serial: 8250_exar: Move Exar pieces to custom ->startup()
There is a one more step to consolidate Exar bits under 8250_exar umbrella. This time we introduce a custom ->startup() callback where the Exar specific settings are applied.
Cc Robert Middleton <[email protected]>
Cc Sudip Mukherjee <[email protected]>
Cc Aaron Sierra <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/tty/serial/8250/8250_exar.c | 19 +++++++++++++++++++ drivers/tty/serial/8250/8250_port.c | 14 -------------- 2 files changed, 19 insertions(+), 14 deletions(-)
drivers/tty/serial/8250/8250_exar.c +19 -0
@@ -166,6 +166,23 @@ static void xr17v35x_set_divisor(struct uart_port *p, unsigned int baud,serial_port_out (p,0x2 , quot_frac); } +static int xr17v35x_startup (struct uart_port *port) +{ +/* +* First enable access to IER [7:5], ISR [5:4], FCR [5:4], +* MCR [7:5] and MSR [7:0] +*/ +serial_port_out (port,UART_XR_EFR ,UART_EFR_ECB ); + +/* +* Make sure all interrups are masked until initialization is +* complete and the FIFOs are cleared +*/ +serial_port_out (port,UART_IER ,0 ); + +return serial8250_do_startup (port); +} +static void exar_shutdown (struct uart_port *port) {unsigned char lsr;
@@ -212,6 +229,8 @@ static int default_setup(struct exar8250 *priv, struct pci_dev *pcidev, port->port.get_divisor = xr17v35x_get_divisor; port->port.set_divisor = xr17v35x_set_divisor; + + port->port.startup = xr17v35x_startup; }else { port->port.type =PORT_XR17D15X ; }
drivers/tty/serial/8250/8250_port.c +0 -14
@@ -2114,20 +2114,6 @@ int serial8250_do_startup(struct uart_port *port)enable_rsa (up);#endif -if (port->type ==PORT_XR17V35X ) { -/* -* First enable access to IER [7:5], ISR [5:4], FCR [5:4], -* MCR [7:5] and MSR [7:0] -*/ -serial_port_out (port,UART_XR_EFR ,UART_EFR_ECB ); - -/* -* Make sure all interrups are masked until initialization is -* complete and the FIFOs are cleared -*/ -serial_port_out (port,UART_IER ,0 ); - } -/* * Clear the FIFO buffers and disable them. * (they will be reenabled in set_termios())
Signature · 1 line
2.23.0