Skip to contentSkip to conversation

virtio_fs: Change module name to virtiofs.ko

PATCH Applied Vivek Goyal 4 participants 4 messages Oct 11, 2019 – Oct 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio_fs: Change module name to virtiofs.ko

We have been calling it virtio_fs and even file name is virtio_fs.c. Module name is virtio_fs.ko but when registering file system user is supposed to specify filesystem type as "virtiofs".

Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and got this warning on console.

  ------------[ cut here ]------------
  request_module fs-virtio_fs succeeded, but still no fs?
  WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
  Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
  CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1

So looks like kernel could find the module virtio_fs.ko but could not find filesystem type after that.

It probably is better to rename module name to virtiofs.ko so that above warning goes away in case user ends up specifying wrong fs name.

---
 fs/fuse/Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/fuse/Makefile +2 -1
Index: rhvgoyal-linux/fs/fuse/Makefile
===================================================================
@@ -5,6 +5,7 @@
 
 obj-$(CONFIG_FUSE_FS) += fuse.o
 obj-$(CONFIG_CUSE) += cuse.o
-obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o
+obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
 
 fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o
+virtiofs-y += virtio_fs.o
Tested-by on v1 1/1
#1 lore raw

Hi Vivek,

Quoted 13 lines · Vivek Goyal

We have been calling it virtio_fs and even file name is virtio_fs.c. Module name is virtio_fs.ko but when registering file system user is supposed to specify filesystem type as "virtiofs".

Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and got this warning on console.

  ------------[ cut here ]------------
  request_module fs-virtio_fs succeeded, but still no fs?
  WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
  Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
  CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1
Quoted 5 lines

So looks like kernel could find the module virtio_fs.ko but could not find filesystem type after that.

It probably is better to rename module name to virtiofs.ko so that above warning goes away in case user ends up specifying wrong fs name.

The warning is gone after applied this patch, thanks! Please feel free to add:

- Masa

Quoted 21 lines
---
 fs/fuse/Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: rhvgoyal-linux/fs/fuse/Makefile
===================================================================

fs/fuse/Makefile +2 -1
@@ -5,6 +5,7 @@
 
 obj-$(CONFIG_FUSE_FS) += fuse.o
 obj-$(CONFIG_CUSE) += cuse.o
-obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o
+obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
 
 fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o
+virtiofs-y += virtio_fs.o
Reviewed-by on v1 1/1
#2 lore raw
In reply to Vivek Goyal
Quoted 31 lines · Vivek Goyal

We have been calling it virtio_fs and even file name is virtio_fs.c. Module name is virtio_fs.ko but when registering file system user is supposed to specify filesystem type as "virtiofs".

Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and got this warning on console.

  ------------[ cut here ]------------
  request_module fs-virtio_fs succeeded, but still no fs?
  WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
  Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
  CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1

So looks like kernel could find the module virtio_fs.ko but could not find filesystem type after that.

It probably is better to rename module name to virtiofs.ko so that above warning goes away in case user ends up specifying wrong fs name.

---
 fs/fuse/Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: rhvgoyal-linux/fs/fuse/Makefile
===================================================================

fs/fuse/Makefile line 11

Quoted 8 lines
fs/fuse/Makefile +2 -1
@@ -5,6 +5,7 @@
 
 obj-$(CONFIG_FUSE_FS) += fuse.o
 obj-$(CONFIG_CUSE) += cuse.o
-obj-$(CONFIG_VIRTIO_FS) += virtio_fs.o
+obj-$(CONFIG_VIRTIO_FS) += virtiofs.o
 
 fuse-objs := dev.o dir.o file.o inode.o control.o xattr.o acl.o readdir.o
+virtiofs-y += virtio_fs.o
maintainer Applied
#3 lore raw
In reply to Vivek Goyal
Quoted 17 lines · Vivek Goyal

We have been calling it virtio_fs and even file name is virtio_fs.c. Module name is virtio_fs.ko but when registering file system user is supposed to specify filesystem type as "virtiofs".

Masayoshi Mizuma reported that he specified filesytem type as "virtio_fs" and got this warning on console.

  ------------[ cut here ]------------
  request_module fs-virtio_fs succeeded, but still no fs?
  WARNING: CPU: 1 PID: 1234 at fs/filesystems.c:274 get_fs_type+0x12c/0x138
  Modules linked in: ... virtio_fs fuse virtio_net net_failover ...
  CPU: 1 PID: 1234 Comm: mount Not tainted 5.4.0-rc1 #1

So looks like kernel could find the module virtio_fs.ko but could not find filesystem type after that.

Quoted 6 lines

It probably is better to rename module name to virtiofs.ko so that above warning goes away in case user ends up specifying wrong fs name.

Thanks, applied.

Miklos