sandbox: Remove sandbox_noblk build
PATCH 1/1 sandbox: Remove sandbox_noblk build
At this point, all drivers that do not use CONFIG_BLK are past their migration deadlines, so remove this config as it's no longer helpful and hinders enhancing block drivers.
---
This is required for Faiz's series that adds UFS support to SCSI as that breaks the non-BLK case. This path seems the most reasonable at this point in time.
--- board/sandbox/MAINTAINERS | 7 -- configs/sandbox_noblk_defconfig | 178 -------------------------------- doc/arch/sandbox.rst | 7 +- 3 files changed, 1 insertion(+), 191 deletions(-) delete mode 100644 configs/sandbox_noblk_defconfig
board/sandbox/MAINTAINERS +0 -7
@@ -13,13 +13,6 @@ F: board/sandbox/ F: include/configs/sandbox.h F: configs/sandbox64_defconfig -SANDBOX_NOBLK BOARD -M: Simon Glass <[email protected]> -S: Maintained -F: board/sandbox/ -F: include/configs/sandbox.h -F: configs/sandbox_noblk_defconfig - SANDBOX SPL BOARD M: Simon Glass <[email protected]> S: Maintained
configs/sandbox_noblk_defconfig deleted +0 -178
178 lines not on this page · raw message
doc/arch/sandbox.rst +1 -6
@@ -209,17 +209,12 @@ sandbox_flattree: We need this build so that we can test those inline functions, and we cannot build with both the inline functions and the non-inline functions since they are named the same. -sandbox_noblk: - builds without CONFIG_BLK, which means the legacy block - drivers are used. We cannot use both the legacy and driver-model block - drivers since they implement the same functions sandbox_spl: builds sandbox with SPL support, so you can run spl/u-boot-spl and it will start up and then load ./u-boot. It is also possible to run ./u-boot directly. -Of these sandbox_noblk can be removed once CONFIG_BLK is used everwhere, and -sandbox_spl can probably be removed since it is a superset of sandbox. +Of these sandbox_spl can probably be removed since it is a superset of sandbox. Most of the config options should be identical between these variants.
Signature · 1 line
2.17.1
PATCH 1/1 sandbox: Remove sandbox_noblk build
Quoted 12 lines · Tom Rini
At this point, all drivers that do not use
CONFIG_BLKare past their migration deadlines, so remove this config as it's no longer helpful and hinders enhancing block drivers.Cc Simon Glass <[email protected]>Cc Faiz Abbas <[email protected]>Signed-off-by Tom Rini <[email protected]>---
This is required for Faiz's series that adds UFS support to SCSI as that breaks the non-BLK case. This path seems the most reasonable at this point in time.
Quoted 6 lines
--- board/sandbox/MAINTAINERS | 7 -- configs/sandbox_noblk_defconfig | 178 -------------------------------- doc/arch/sandbox.rst | 7 +- 3 files changed, 1 insertion(+), 191 deletions(-) delete mode 100644 configs/sandbox_noblk_defconfig
I wonder if we can assume that if block drivers are needed in SPL, then SPL_BLK will always be enabled? If not, we might have a problem.
+Marek Vasut
- Simon
PATCH 1/1 sandbox: Remove sandbox_noblk build
Quoted 20 lines · Simon Glass
Quoted 12 lines · Tom Rini
At this point, all drivers that do not use
CONFIG_BLKare past their migration deadlines, so remove this config as it's no longer helpful and hinders enhancing block drivers.Cc Simon Glass <[email protected]>Cc Faiz Abbas <[email protected]>Signed-off-by Tom Rini <[email protected]>---
This is required for Faiz's series that adds UFS support to SCSI as that breaks the non-BLK case. This path seems the most reasonable at this point in time.Quoted 6 lines
--- board/sandbox/MAINTAINERS | 7 -- configs/sandbox_noblk_defconfig | 178 -------------------------------- doc/arch/sandbox.rst | 7 +- 3 files changed, 1 insertion(+), 191 deletions(-) delete mode 100644 configs/sandbox_noblk_defconfig
Quoted 6 lines
Reviewed-by Simon Glass <[email protected]>I wonder if we can assume that if block drivers are needed in SPL, then
SPL_BLKwill always be enabled? If not, we might have a problem.+Marek Vasut
Perhaps? Unfortunately doing this showed another set of problems on PowerPC so I'm going to put the UFS aside for this batch of patches as I think I saw something from Peng that will help PowerPC.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191011/db56c54c/attachment.sig>