Skip to contentSkip to conversation

staging: media: omap4iss: Fix lines ending with open parenthesis

PATCH Superseded Jamal Shareef 2 participants 2 messages Oct 12, 2019

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: media: omap4iss: Fix lines ending with open parenthesis

Fix lines ending with open parenthesis. Issue
found by checkpatch.

---
 drivers/staging/media/omap4iss/iss_csi2.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/staging/media/omap4iss/iss_csi2.c +10 -6
index a6dc2d2b1228..738eb8b07430 100644
@@ -495,9 +495,11 @@ int omap4iss_csi2_reset(struct iss_csi2_device *csi2)
 	iss_reg_set(csi2->iss, csi2->regs1, CSI2_SYSCONFIG,
 		    CSI2_SYSCONFIG_SOFT_RESET);
 
-	timeout = iss_poll_condition_timeout(
-		iss_reg_read(csi2->iss, csi2->regs1, CSI2_SYSSTATUS) &
-		CSI2_SYSSTATUS_RESET_DONE, 500, 100, 200);
+	timeout = iss_poll_condition_timeout(iss_reg_read(csi2->iss,
+							  csi2->regs1,
+							  CSI2_SYSSTATUS) &
+					     CSI2_SYSSTATUS_RESET_DONE,
+					     500, 100, 200);
 	if (timeout) {
 		dev_err(csi2->iss->dev, "CSI2: Soft reset timeout!\n");
 		return -EBUSY;
@@ -506,9 +508,11 @@ int omap4iss_csi2_reset(struct iss_csi2_device *csi2)
 	iss_reg_set(csi2->iss, csi2->regs1, CSI2_COMPLEXIO_CFG,
 		    CSI2_COMPLEXIO_CFG_RESET_CTRL);
 
-	timeout = iss_poll_condition_timeout(
-		iss_reg_read(csi2->iss, csi2->phy->phy_regs, REGISTER1) &
-		REGISTER1_RESET_DONE_CTRLCLK, 10000, 100, 500);
+	timeout = iss_poll_condition_timeout(iss_reg_read(csi2->iss,
+							  csi2->phy->phy_regs,
+							  REGISTER1) &
+					     REGISTER1_RESET_DONE_CTRLCLK,
+					     10000, 100, 500);
 	if (timeout) {
 		dev_err(csi2->iss->dev, "CSI2: CSI2_96M_FCLK reset timeout!\n");
 		return -EBUSY;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 2 lines · Jamal Shareef

Fix lines ending with open parenthesis. Issue
found by checkpatch.

This has the same subject line as the other patch you sent on a different file. Each patch has to have a unique subject line. If you can't find one, it would seem that the patches should be merged into one.

The comments I made on the other patch apply to this one as well.

julia

Quoted 48 lines
---
 drivers/staging/media/omap4iss/iss_csi2.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/staging/media/omap4iss/iss_csi2.c +10 -7
index a6dc2d2b1228..738eb8b07430 100644
@@ -495,9 +495,11 @@ int omap4iss_csi2_reset(struct iss_csi2_device *csi2)
 	iss_reg_set(csi2->iss, csi2->regs1, CSI2_SYSCONFIG,
 		    CSI2_SYSCONFIG_SOFT_RESET);
 
-	timeout = iss_poll_condition_timeout(
-		iss_reg_read(csi2->iss, csi2->regs1, CSI2_SYSSTATUS) &
-		CSI2_SYSSTATUS_RESET_DONE, 500, 100, 200);
+	timeout = iss_poll_condition_timeout(iss_reg_read(csi2->iss,
+							  csi2->regs1,
+							  CSI2_SYSSTATUS) &
+					     CSI2_SYSSTATUS_RESET_DONE,
+					     500, 100, 200);
 	if (timeout) {
 		dev_err(csi2->iss->dev, "CSI2: Soft reset timeout!\n");
 		return -EBUSY;
@@ -506,9 +508,11 @@ int omap4iss_csi2_reset(struct iss_csi2_device *csi2)
 	iss_reg_set(csi2->iss, csi2->regs1, CSI2_COMPLEXIO_CFG,
 		    CSI2_COMPLEXIO_CFG_RESET_CTRL);
 
-	timeout = iss_poll_condition_timeout(
-		iss_reg_read(csi2->iss, csi2->phy->phy_regs, REGISTER1) &
-		REGISTER1_RESET_DONE_CTRLCLK, 10000, 100, 500);
+	timeout = iss_poll_condition_timeout(iss_reg_read(csi2->iss,
+							  csi2->phy->phy_regs,
+							  REGISTER1) &
+					     REGISTER1_RESET_DONE_CTRLCLK,
+					     10000, 100, 500);
 	if (timeout) {
 		dev_err(csi2->iss->dev, "CSI2: CSI2_96M_FCLK reset timeout!\n");
 		return -EBUSY;
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191012014637.2655-1-jamal.k.shareef%40gmail.com.