Skip to contentSkip to conversation

MAINTAINERS: Add a TILE-Gx section

PATCH In review Philippe Mathieu-Daudé 2 participants 4 messages Oct 12, 2019 – Nov 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add a TILE-Gx section

The TILE-Gx architecture was missing its section, add it.

---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)
MAINTAINERS +5 -0
index 3ca814850e..a3be0a4a31 100644
@@ -299,6 +299,11 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
+TILE-Gx CPUs
+M: Chen Gang <[email protected]>
+S: Maintained
+F: target/tilegx/
+
 UniCore32 TCG CPUs
 M: Guan Xuetao <[email protected]>
 S: Maintained
Signature · 1 line
2.21.0
#1 lore raw

12.10.2019. 09.12, "Philippe Mathieu-Daudé" <[email protected]> је написао/ла:

Quoted 8 lines

The TILE-Gx architecture was missing its section, add it.

---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

It is certainly good that there is a maintainer for each QEMU component. But:

- is Chen Gang available and willing to assume the role?

- sadly, tilegx arch support was recently removed from kernel upstream. That does not mean (in my understanding) automatic removal from QEMU, but certainly raises some eyebrows. Should we continue supporting tilegx? Isthete any feedback from users, or the company that owns tilegx?

Sincerely,
Aleksandar

Quoted 20 lines
MAINTAINERS +5 -1
index 3ca814850e..a3be0a4a31 100644
@@ -299,6 +299,11 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
+TILE-Gx CPUs
+M: Chen Gang <[email protected]>
+S: Maintained
+F: target/tilegx/
+
 UniCore32 TCG CPUs
 M: Guan Xuetao <[email protected]>
 S: Maintained
--

2.21.0

#2 lore raw
Quoted 7 lines · Aleksandar Markovic

12.10.2019. 09.12, "Philippe Mathieu-Daudé" <[email protected] <mailto:[email protected]>> је написао/ла:

Quoted 4 lines

The TILE-Gx architecture was missing its section, add it.

<mailto:[email protected]>>

Quoted 8 lines
Quoted 4 lines

---
 MAINTAINERS | 5 +++++

 1 file changed, 5 insertions(+)

It is certainly good that there is a maintainer for each QEMU component. But:

- is Chen Gang available and willing to assume the role?

One month passed, so we can assume this architecture is orphan. I'll prepare a patch.

Quoted 2 lines

- sadly, tilegx arch support was recently removed from kernel upstream.
That does not mean (in my understanding) automatic removal from QEMU, but certainly raises some eyebrows. Should we continue supporting tilegx? Isthete any feedback from users, or the company that owns tilegx?

We should properly deprecate it, to give any users a chance to notice it and tell us. I'll prepare another patch.

Quoted 25 lines

Sincerely,
Aleksandar

MAINTAINERS

Quoted 10 lines
MAINTAINERS +0 -0
index 3ca814850e..a3be0a4a31 100644
@@ -299,6 +299,11 @@ F: hw/sparc64/

 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c

MAINTAINERS +2 -0
+TILE-Gx CPUs
+M: Chen Gang <[email protected] 

<mailto:[email protected]>>

Quoted 10 lines
MAINTAINERS +3 -0
+S: Maintained
+F: target/tilegx/
+

 UniCore32 TCG CPUs
 M: Guan Xuetao <[email protected] <mailto:[email protected]>>
 S: Maintained
--
2.21.0

#3 lore raw

ū

Quoted 24 lines · Philippe Mathieu-Daudé
Quoted 13 lines · Aleksandar Markovic

12.10.2019. 09.12, "Philippe Mathieu-Daudé" <[email protected] <mailto:
[email protected]>> је написао/ла:

Quoted 4 lines

The TILE-Gx architecture was missing its section, add it.

[email protected]>>

Quoted 4 lines
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)
Quoted 5 lines

It is certainly good that there is a maintainer for each QEMU component. But:

- is Chen Gang available and willing to assume the role?

One month passed, so we can assume this architecture is orphan. I'll prepare a patch.

Quoted 10 lines

- sadly, tilegx arch support was recently removed from kernel upstream.

Quoted 4 lines

That does not mean (in my understanding) automatic removal from QEMU, but certainly raises some eyebrows. Should we continue supporting tilegx? Isthete any feedback from users, or the company that owns tilegx?

We should properly deprecate it, to give any users a chance to notice it and tell us. I'll prepare another patch.

Philippe, all what you said here sounds reasonable and appropriate to me. Thanks for readiness to follow up.

A.

Quoted 27 lines

Sincerely,

Quoted 25 lines

Aleksandar

MAINTAINERS F: hw/sparc64/ · line 303

Quoted 10 lines
MAINTAINERS +2 -0
index 3ca814850e..a3be0a4a31 100644
@@ -299,6 +299,11 @@ F: hw/sparc64/
 F: include/hw/sparc/sparc64.h
 F: disas/sparc.c
 
+TILE-Gx CPUs
+M: Chen Gang <[email protected] <mailto:gang.chen.5i5j@gmail.

com>>

Quoted 10 lines
MAINTAINERS +3 -1
+S: Maintained
+F: target/tilegx/
+
 UniCore32 TCG CPUs
 M: Guan Xuetao <[email protected] <mailto:[email protected]>>
 S: Maintained
--

2.21.0