configs/minnowboard_max-graphical: fix build due to missing glxproto.h
PATCH 1/1 configs/minnowboard_max-graphical: fix build due to missing glxproto.h
From: Carlos Santos <[email protected]>
Commit 5cb821d5635 added a new option to enable GLX support in mesa3d. Update the defconfig accordingly.
---
The defconfig was edited by hand to reduce the turmoild that would result from using "make savedefconfig"
--- configs/minnowboard_max-graphical_defconfig | 1 + 1 file changed, 1 insertion(+)
configs/minnowboard_max-graphical_defconfig +1 -0
@@ -41,6 +41,7 @@ BR2_PACKAGE_MESA3D_DEMOS=y BR2_PACKAGE_MESA3D=y BR2_PACKAGE_MESA3D_DRI_DRIVER_SWRAST=y BR2_PACKAGE_MESA3D_DRI_DRIVER_I965=y +BR2_PACKAGE_MESA3D_OPENGL_GLX=y # Framebuffer (just for testing purposes) BR2_PACKAGE_FB_TEST_APP=y
Signature · 1 line
2.18.1
PATCH 1/1 configs/minnowboard_max-graphical: fix build due to missing glxproto.h
Hello Carlos,
Quoted 11 lines · On Sat, 12 Oct 2019 10:51:05 -0300 unixmania at gmail.com wrote:
From: Carlos Santos <[email protected]>
Commit
5cb821d5635added a new option to enable GLX support in mesa3d. Update the defconfig accordingly.Signed-off-by Carlos Santos <[email protected]>---
The defconfig was edited by hand to reduce the turmoild that would result from using "make savedefconfig"
Fixing the defconfig is not the way to go: if a given configuration causes a build failure, then Buildroot needs to be fixed, as it means that the mesa3d package itself is broken: it lets users create configurations that fail to build.
For example, it means the random configuration testing from the autobuilders could still fall into this build failure.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 configs/minnowboard_max-graphical: fix build due to missing glxproto.h
Quoted 23 lines · Thomas Petazzoni
Hello Carlos,
Quoted 11 lines · On Sat, 12 Oct 2019 10:51:05 -0300 unixmania at gmail.com wrote:
From: Carlos Santos <[email protected]>
Commit
5cb821d5635added a new option to enable GLX support in mesa3d. Update the defconfig accordingly.Signed-off-by Carlos Santos <[email protected]>---
The defconfig was edited by hand to reduce the turmoild that would result from using "make savedefconfig"Fixing the defconfig is not the way to go: if a given configuration causes a build failure, then Buildroot needs to be fixed, as it means that the mesa3d package itself is broken: it lets users create configurations that fail to build.
Quoted 8 lines
For example, it means the random configuration testing from the autobuilders could still fall into this build failure.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
The board requires BR2_PACKAGE_MESA3D_OPENGL_GLX to take advantage of the embedded graphics chip.
The other problem is solved by replacing the test for BR2_PACKAGE_MESA3D_DRI_DRIVER by a test for BR2_PACKAGE_MESA3D_OPENGL_GLX in package/x11r7/xserver_xorg-server/xserver_xorg-server.mk.
Signature · 1 line
Carlos Santos <[email protected]>