Skip to contentSkip to conversation

regulator: fixed: Modify enable-active-high behavior

PATCH Superseded Patrice Chotard 2 participants 3 messages Aug 26, 2019 – Oct 12, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 regulator: fixed: Modify enable-active-high behavior

Regulator should not be enabled at probe time if regulator-boot-on property is not in the dt node.

"enable-active-high" property is only used to indicate the GPIO polarity.

See kernel documentation :
- Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
- Documentation/devicetree/bindings/regulator/gpio-regulator.yaml

---

Changes in v2:
- fix build issue

 drivers/power/regulator/regulator_common.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/power/regulator/regulator_common.c +6 -1
index 3dabbe2a85..2041086567 100644
@@ -12,10 +12,15 @@ int regulator_common_ofdata_to_platdata(struct udevice *dev,
 	struct regulator_common_platdata *dev_pdata, const char *enable_gpio_name)
 {
 	struct gpio_desc *gpio;
+	struct dm_regulator_uclass_platdata *uc_pdata;
 	int flags = GPIOD_IS_OUT;
 	int ret;
 
-	if (dev_read_bool(dev, "enable-active-high"))
+	uc_pdata = dev_get_uclass_platdata(dev);
+
+	if (!dev_read_bool(dev, "enable-active-high"))
+		flags |= GPIOD_ACTIVE_LOW;
+	if (uc_pdata->boot_on)
 		flags |= GPIOD_IS_OUT_ACTIVE;
 
 	/* Get optional enable GPIO desc */
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 regulator: fixed: Modify enable-active-high behavior

Hi,

It's a gentle reminder to not forgot this patch.

Thanks

Patrice

Quoted 41 lines · Patrice Chotard

Regulator should not be enabled at probe time if regulator-boot-on property is not in the dt node.

"enable-active-high" property is only used to indicate the GPIO polarity.

See kernel documentation :
- Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
- Documentation/devicetree/bindings/regulator/gpio-regulator.yaml

---

Changes in v2:
- fix build issue

 drivers/power/regulator/regulator_common.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/power/regulator/regulator_common.c +6 -1
index 3dabbe2a85..2041086567 100644
@@ -12,10 +12,15 @@ int regulator_common_ofdata_to_platdata(struct udevice *dev,
 	struct regulator_common_platdata *dev_pdata, const char *enable_gpio_name)
 {
 	struct gpio_desc *gpio;
+	struct dm_regulator_uclass_platdata *uc_pdata;
 	int flags = GPIOD_IS_OUT;
 	int ret;
 
-	if (dev_read_bool(dev, "enable-active-high"))
+	uc_pdata = dev_get_uclass_platdata(dev);
+
+	if (!dev_read_bool(dev, "enable-active-high"))
+		flags |= GPIOD_ACTIVE_LOW;
+	if (uc_pdata->boot_on)
 		flags |= GPIOD_IS_OUT_ACTIVE;
 
 	/* Get optional enable GPIO desc */
#2 lore raw

PATCH v2 1/1 regulator: fixed: Modify enable-active-high behavior

In reply to Patrice Chotard
Quoted 6 lines · Patrice Chotard

Regulator should not be enabled at probe time if regulator-boot-on property is not in the dt node.

"enable-active-high" property is only used to indicate the GPIO polarity.

Quoted 6 lines

See kernel documentation :
- Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
- Documentation/devicetree/bindings/regulator/gpio-regulator.yaml

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191012/52e76c53/attachment.sig>