Skip to contentSkip to conversation

mmc: am654_sdhci: Drop a redundant power_domain_on in probe

PATCH New Lokesh Vutla 3 participants 3 messages Sep 24, 2019 – Oct 12, 2019 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: am654_sdhci: Drop a redundant power_domain_on in probe

Power-domain is enabled by default in device_probe. am654 mmc driver is enabling power-domain again in probe. As the second call is redundant, drop power_domain_on from probe.

---
 drivers/mmc/am654_sdhci.c | 13 -------------
 1 file changed, 13 deletions(-)
drivers/mmc/am654_sdhci.c +0 -13
index 1793a3f99a..7cd5516197 100644
@@ -219,23 +219,10 @@ static int am654_sdhci_probe(struct udevice *dev)
 	struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);
 	struct sdhci_host *host = dev_get_priv(dev);
 	struct mmc_config *cfg = &plat->cfg;
-	struct power_domain sdhci_pwrdmn;
 	struct clk clk;
 	unsigned long clock;
 	int ret;
 
-	ret = power_domain_get_by_index(dev, &sdhci_pwrdmn, 0);
-	if (!ret) {
-		ret = power_domain_on(&sdhci_pwrdmn);
-		if (ret) {
-			dev_err(dev, "Power domain on failed (%d)\n", ret);
-			return ret;
-		}
-	} else if (ret != -ENOENT && ret != -ENODEV && ret != -ENOSYS) {
-		dev_err(dev, "failed to get power domain (%d)\n", ret);
-		return ret;
-	}
-
 	ret = clk_get_by_index(dev, 0, &clk);
 	if (ret) {
 		dev_err(dev, "failed to get clock\n");
Signature · 1 line
2.22.0
#1 lore raw

PATCH 1/1 mmc: am654_sdhci: Drop a redundant power_domain_on in probe

Quoted 31 lines

Subject: [PATCH] mmc: am654_sdhci: Drop a redundant power_domain_on in probe

Power-domain is enabled by default in device_probe. am654 mmc driver is enabling power-domain again in probe. As the second call is redundant, drop power_domain_on from probe.

---
 drivers/mmc/am654_sdhci.c | 13 -------------
 1 file changed, 13 deletions(-)
drivers/mmc/am654_sdhci.c index renamed from drivers/mmc/am654_sdhci.c +0 -0

1793a3f99a..7cd5516197 100644

drivers/mmc/am654_sdhci.c +0 -6
@@ -219,23 +219,10 @@ static int am654_sdhci_probe(struct udevice *dev)
 	struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);
 	struct sdhci_host *host = dev_get_priv(dev);
 	struct mmc_config *cfg = &plat->cfg;
-	struct power_domain sdhci_pwrdmn;
 	struct clk clk;
 	unsigned long clock;
 	int ret;
 
-	ret = power_domain_get_by_index(dev, &sdhci_pwrdmn, 0);
-	if (!ret) {
-		ret = power_domain_on(&sdhci_pwrdmn);
-		if (ret) {
-			dev_err(dev, "Power domain on failed (%d)\n", ret);

drivers/mmc/am654_sdhci.c static int am654_sdhci_probe(struct udevice *dev) · line 228

Quoted 10 lines
drivers/mmc/am654_sdhci.c +0 -7
-			return ret;
-		}
-	} else if (ret != -ENOENT && ret != -ENODEV && ret != -ENOSYS) {
-		dev_err(dev, "failed to get power domain (%d)\n", ret);
-		return ret;
-	}
-
 	ret = clk_get_by_index(dev, 0, &clk);
 	if (ret) {
 		dev_err(dev, "failed to get clock\n");
Quoted 2 lines

--
2.22.0

#2 lore raw

PATCH 1/1 mmc: am654_sdhci: Drop a redundant power_domain_on in probe

In reply to Lokesh Vutla
Quoted 7 lines · Lokesh Vutla

Power-domain is enabled by default in device_probe. am654 mmc driver is enabling power-domain again in probe. As the second call is redundant, drop power_domain_on from probe.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191012/a138f359/attachment.sig>