Skip to contentSkip to conversation

package/libva: switch to virtual opengl provider

PATCH New Bernd Kuhls 2 participants 4 messages Oct 12, 2019 – Oct 22, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libva: switch to virtual opengl provider

This allows to use libva without mesa3d.

---
 package/libva/libva.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/libva/libva.mk +2 -2
index 6c8243da90..176f971128 100644
@@ -20,8 +20,8 @@ LIBVA_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_XORG7),y)
 LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
 LIBVA_CONF_OPTS += --enable-x11
-ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
-LIBVA_DEPENDENCIES += mesa3d
+ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
+LIBVA_DEPENDENCIES += libgl
 LIBVA_CONF_OPTS += --enable-glx
 endif
 else
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/libva: switch to virtual opengl provider

package/libva/libva.mk LIBVA_CONF_OPTS = \ · line 25

Quoted 13 lines · On Sat, 12 Oct 2019 17:39:31 +0200 Bernd Kuhls <[email protected]> wrote:
package/libva/libva.mk +2 -2
index 6c8243da90..176f971128 100644
@@ -20,8 +20,8 @@ LIBVA_CONF_OPTS = \
 ifeq ($(BR2_PACKAGE_XORG7),y)
 LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
 LIBVA_CONF_OPTS += --enable-x11
-ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
-LIBVA_DEPENDENCIES += mesa3d
+ifeq ($(BR2_PACKAGE_HAS_LIBGL),y)
+LIBVA_DEPENDENCIES += libgl
 LIBVA_CONF_OPTS += --enable-glx

Do all OpenGL implementation provide GLX support ? I would assume that in most practical cases, yes, but I'm wondering.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libva: switch to virtual opengl provider

Am Sat, 12 Oct 2019 21:45:04 +0200 schrieb Thomas Petazzoni:

Quoted 2 lines

Do all OpenGL implementation provide GLX support ? I would assume that in most practical cases, yes, but I'm wondering.

Hi Thomas,

three packages contain "select BR2_PACKAGE_HAS_LIBGL":

- amd-catalyst
- mesa3d
- nvidia-driver

Building libva with glx support was successful with these defconfigs:

BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XSERVER_XORG_SERVER=y
BR2_PACKAGE_XSERVER_XORG_SERVER_V_1_17=y
BR2_PACKAGE_AMD_CATALYST=y
BR2_PACKAGE_LIBVA=y

BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_XORG7=y
BR2_PACKAGE_XSERVER_XORG_SERVER=y
BR2_PACKAGE_NVIDIA_DRIVER=y
BR2_PACKAGE_LIBVA=y

Regards, Bernd

#3 lore raw

PATCH 1/1 package/libva: switch to virtual opengl provider

In reply to Bernd Kuhls
Quoted 6 lines · On Sat, 12 Oct 2019 17:39:31 +0200 Bernd Kuhls <[email protected]> wrote:

This allows to use libva without mesa3d.

---
 package/libva/libva.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com