Skip to contentSkip to conversation

iio:adc:stmpe-adc: Cleanup endian type of local variable

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Oct 18, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio:adc:stmpe-adc: Cleanup endian type of local variable

From: Jonathan Cameron <[email protected]>

Nothing stops data being of type __be16, which fixes the warning:

CHECK drivers/iio/adc/stmpe-adc.c
drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16

Cc Philippe Schenker <[email protected]>
---
 drivers/iio/adc/stmpe-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/stmpe-adc.c +1 -1
index bd72727fc417..0f88048ea48f 100644
@@ -175,7 +175,7 @@ static int stmpe_read_raw(struct iio_dev *indio_dev,
 static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
 {
 	struct stmpe_adc *info = (struct stmpe_adc *)dev_id;
-	u16 data;
+	__be16 data;
 
 	if (info->channel <= STMPE_ADC_LAST_NR) {
 		int int_sta;
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Sun, 2019-10-13 at 10:15 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Nothing stops data being of type __be16, which fixes the warning:

Quoted 8 lines

CHECK drivers/iio/adc/stmpe-adc.c
drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16

Cc Philippe Schenker <[email protected]>

Thanks for fixing that.

Quoted 18 lines
---
 drivers/iio/adc/stmpe-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/stmpe-adc.c +1 -1
index bd72727fc417..0f88048ea48f 100644
@@ -175,7 +175,7 @@ static int stmpe_read_raw(struct iio_dev
 *indio_dev,
 static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
 {
 	struct stmpe_adc *info = (struct stmpe_adc *)dev_id;
-	u16 data;
+	__be16 data;
 
 	if (info->channel <= STMPE_ADC_LAST_NR) {

int int_sta;

author maintainer
#2 lore raw
Quoted 11 lines · On Mon, 14 Oct 2019 07:50:33 +0000 Philippe Schenker…
Quoted 10 lines · On Sun, 2019-10-13 at 10:15 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Nothing stops data being of type __be16, which fixes the warning:

CHECK drivers/iio/adc/stmpe-adc.c
drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16 drivers/iio/adc/stmpe-adc.c:202:29: warning: cast to restricted __be16

Quoted 6 lines
Quoted 2 lines
Cc Philippe Schenker <[email protected]>

Thanks for fixing that.

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 19 lines
Quoted 19 lines
---
 drivers/iio/adc/stmpe-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/adc/stmpe-adc.c +1 -1
index bd72727fc417..0f88048ea48f 100644
@@ -175,7 +175,7 @@ static int stmpe_read_raw(struct iio_dev
 *indio_dev,
 static irqreturn_t stmpe_adc_isr(int irq, void *dev_id)
 {
 	struct stmpe_adc *info = (struct stmpe_adc *)dev_id;
-	u16 data;
+	__be16 data;
 
 	if (info->channel <= STMPE_ADC_LAST_NR) {

int int_sta;