iio: proximity: pulsedlight v2: Tidy up an endian issue
[email protected]
maintainerPATCH 1/1 iio: proximity: pulsedlight v2: Tidy up an endian issue
From: Jonathan Cameron <[email protected]>
Sparse identified the following
CHECK drivers/iio/proximity/pulsedlight-lidar-lite-v2.cdrivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16 drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16 drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16 drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted __be16
This cleans up by adding a local variable to hold the value whilst it is __be16 before applying endian converstion into eventual destination.
--- drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c +3 -2
@@ -136,12 +136,13 @@ static inline int lidar_write_power(struct lidar_data *data, int val)static int lidar_read_measurement (struct lidar_data *data,u16 *reg) { +__be16 value;int ret = data->xfer (data,LIDAR_REG_DATA_HBYTE | (data->i2c_enabled ?LIDAR_REG_DATA_WORD_READ :0 ), - (u8 *) reg,2 ); + (u8 *) &value,2 );if (!ret) - *reg =be16_to_cpu (*reg); + *reg =be16_to_cpu (value);return ret; }
Signature · 1 line
2.23.0
Quoted 10 lines · On Sun, Oct 13, 2019 at 1:28 PM <[email protected]> wrote:
From: Jonathan Cameron <[email protected]>
Sparse identified the following
CHECKdrivers/iio/proximity/pulsedlight-lidar-lite-v2.cdrivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16
Quoted 5 lines
This cleans up by adding a local variable to hold the value whilst it is
__be16before applying endian converstion into eventual destination.Signed-off-by Jonathan Cameron <[email protected]>Cc Matt Ranostay <[email protected]>
Quoted 27 lines
--- drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/proximity/pulsedlight-lidar-lite-v2.c +3
-3@@ -136,12 +136,13 @@ static inline int lidar_write_power(struct lidar_data *data, int val)static int lidar_read_measurement (struct lidar_data *data,u16 *reg) { +__be16 value;int ret = data->xfer (data,LIDAR_REG_DATA_HBYTE | (data->i2c_enabled ?LIDAR_REG_DATA_WORD_READ :0 ), - (u8 *) reg,2 ); + (u8 *) &value,2 );if (!ret) - *reg =be16_to_cpu (*reg); + *reg =be16_to_cpu (value);return ret; } --2.23.0
Quoted 11 lines · On Sun, 13 Oct 2019 20:58:26 +0300 Matt Ranostay <[email protected]>…
Quoted 10 lines · On Sun, Oct 13, 2019 at 1:28 PM <[email protected]> wrote:
From: Jonathan Cameron <[email protected]>
Sparse identified the following
CHECKdrivers/iio/proximity/pulsedlight-lidar-lite-v2.cdrivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16drivers/iio/proximity/pulsedlight-lidar-lite-v2.c:144:24: warning: cast to restricted__be16
Quoted 7 lines
Quoted 5 lines
This cleans up by adding a local variable to hold the value whilst it is
__be16before applying endian converstion into eventual destination.Signed-off-by Jonathan Cameron <[email protected]>Cc Matt Ranostay <[email protected]>Acked-by Matt Ranostay <[email protected]>
Applied. Thanks,
Jonathan
Quoted 28 lines
Quoted 28 lines
--- drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)drivers/iio/proximity/pulsedlight-lidar-lite-v2.c +3
-3@@ -136,12 +136,13 @@ static inline int lidar_write_power(struct lidar_data *data, int val)static int lidar_read_measurement (struct lidar_data *data,u16 *reg) { +__be16 value;int ret = data->xfer (data,LIDAR_REG_DATA_HBYTE | (data->i2c_enabled ?LIDAR_REG_DATA_WORD_READ :0 ), - (u8 *) reg,2 ); + (u8 *) &value,2 );if (!ret) - *reg =be16_to_cpu (*reg); + *reg =be16_to_cpu (value);return ret; } --2.23.0