Skip to contentSkip to conversation

iio: adc: spear_adc: Use devm_platform_ioremap_resource

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Nov 9, 2019 IIO

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: adc: spear_adc: Use devm_platform_ioremap_resource

From: Jonathan Cameron <[email protected]>

Avoids local boilerplate doing the same thing.
Suggested by coccinelle

CHECK drivers/iio/adc/spear_adc.c
drivers/iio/adc/spear_adc.c:283:1-22: WARNING: Use devm_platform_ioremap_resource for st -> adc_base_spear6xx

---
 drivers/iio/adc/spear_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/spear_adc.c +1 -3
index 592b97c464da..0ad536494e8f 100644
@@ -260,7 +260,6 @@ static int spear_adc_probe(struct platform_device *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	struct device *dev = &pdev->dev;
 	struct spear_adc_state *st;
-	struct resource *res;
 	struct iio_dev *indio_dev = NULL;
 	int ret = -ENODEV;
 	int irq;
@@ -279,8 +278,7 @@ static int spear_adc_probe(struct platform_device *pdev)
 	 * (e.g. SPEAr3xx). Let's provide two register base addresses
 	 * to support multi-arch kernels.
 	 */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	st->adc_base_spear6xx = devm_ioremap_resource(&pdev->dev, res);
+	st->adc_base_spear6xx = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(st->adc_base_spear6xx))
 		return PTR_ERR(st->adc_base_spear6xx);
 
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · On Sun, 2019-10-13 at 16:52 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Avoids local boilerplate doing the same thing.
Suggested by coccinelle

CHECK drivers/iio/adc/spear_adc.c
drivers/iio/adc/spear_adc.c:283:1-22: WARNING: Use devm_platform_ioremap_resource for st -> adc_base_spear6xx

Quoted 29 lines
---
 drivers/iio/adc/spear_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/spear_adc.c +0 -1
index 592b97c464da..0ad536494e8f 100644
@@ -260,7 +260,6 @@ static int spear_adc_probe(struct platform_device
 *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	struct device *dev = &pdev->dev;
 	struct spear_adc_state *st;
-	struct resource *res;
 	struct iio_dev *indio_dev = NULL;
 	int ret = -ENODEV;
drivers/iio/adc/spear_adc.c +1 -2
 	int irq;
@@ -279,8 +278,7 @@ static int spear_adc_probe(struct platform_device
 *pdev)
 	 * (e.g. SPEAr3xx). Let's provide two register base addresses
 	 * to support multi-arch kernels.
 	 */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	st->adc_base_spear6xx = devm_ioremap_resource(&pdev->dev, res);
+	st->adc_base_spear6xx = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(st->adc_base_spear6xx))
 		return PTR_ERR(st->adc_base_spear6xx);
author maintainer Applied
#2 lore raw
Quoted 6 lines · Alexandru
Quoted 5 lines · On Sun, 2019-10-13 at 16:52 +0100, [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Avoids local boilerplate doing the same thing.
Suggested by coccinelle

Quoted 6 lines
Quoted 4 lines

CHECK drivers/iio/adc/spear_adc.c
drivers/iio/adc/spear_adc.c:283:1-22: WARNING: Use devm_platform_ioremap_resource for st -> adc_base_spear6xx

Applied,

Thanks for sanity checking all these :)

Jonathan

Quoted 30 lines
Quoted 30 lines
---
 drivers/iio/adc/spear_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/spear_adc.c +0 -1
index 592b97c464da..0ad536494e8f 100644
@@ -260,7 +260,6 @@ static int spear_adc_probe(struct platform_device
 *pdev)
 	struct device_node *np = pdev->dev.of_node;
 	struct device *dev = &pdev->dev;
 	struct spear_adc_state *st;
-	struct resource *res;
 	struct iio_dev *indio_dev = NULL;
 	int ret = -ENODEV;
drivers/iio/adc/spear_adc.c +1 -2
 	int irq;
@@ -279,8 +278,7 @@ static int spear_adc_probe(struct platform_device
 *pdev)
 	 * (e.g. SPEAr3xx). Let's provide two register base addresses
 	 * to support multi-arch kernels.
 	 */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	st->adc_base_spear6xx = devm_ioremap_resource(&pdev->dev, res);
+	st->adc_base_spear6xx = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(st->adc_base_spear6xx))
 		return PTR_ERR(st->adc_base_spear6xx);