Skip to contentSkip to conversation

iio: light: adux1020: Drop an unwanted semicolon.

PATCH In review [email protected] 2 participants 3 messages Oct 13, 2019 – Oct 16, 2019

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 iio: light: adux1020: Drop an unwanted semicolon.

From: Jonathan Cameron <[email protected]>

Suggested by coccinelle

CHECK drivers/iio/light/adux1020.c
drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon

Cc Manivannan Sadhasivam <[email protected]>
---
 drivers/iio/light/adux1020.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/light/adux1020.c +1 -1
index 830e5e95d58f..b07797ac10d7 100644
@@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data)
 	if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) {
 		dev_err(&client->dev, "invalid chip id 0x%04x\n", val);
 		return -ENODEV;
-	};
+	}
 
 	dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);
 
Signature · 1 line
2.23.0
author maintainer
#1 lore raw
Quoted 9 lines · On Sun, 13 Oct 2019 18:38:52 +0100 [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Suggested by coccinelle

CHECK drivers/iio/light/adux1020.c
drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon

Cc Manivannan Sadhasivam <[email protected]>

0-day sent me the same patch as well.

I've rolled it into the original code as that was still on testing only which was getting rebased anyway.

Thanks,

Jonathan

Quoted 17 lines
---
 drivers/iio/light/adux1020.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/light/adux1020.c +1 -1
index 830e5e95d58f..b07797ac10d7 100644
@@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data)
 	if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) {
 		dev_err(&client->dev, "invalid chip id 0x%04x\n", val);
 		return -ENODEV;
-	};
+	}
 
 	dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);
 
#2 lore raw

Hi Jonathan,

Quoted 10 lines · Jonathan Cameron
Quoted 7 lines · On Sun, 13 Oct 2019 18:38:52 +0100 [email protected] wrote:

From: Jonathan Cameron <[email protected]>

Suggested by coccinelle

CHECK drivers/iio/light/adux1020.c
drivers/iio/light/adux1020.c:747:2-3: Unneeded semicolon

Quoted 7 lines
Quoted 2 lines
Cc Manivannan Sadhasivam <[email protected]>

0-day sent me the same patch as well.

I've rolled it into the original code as that was still on testing only which was getting rebased anyway.

Makes sense!

Thanks,
Mani

Quoted 22 lines

Thanks,

Jonathan

Quoted 17 lines
---
 drivers/iio/light/adux1020.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/light/adux1020.c +1 -1
index 830e5e95d58f..b07797ac10d7 100644
@@ -744,7 +744,7 @@ static int adux1020_chip_init(struct adux1020_data *data)
 	if ((val & ADUX1020_CHIP_ID_MASK) != ADUX1020_CHIP_ID) {
 		dev_err(&client->dev, "invalid chip id 0x%04x\n", val);
 		return -ENODEV;
-	};
+	}
 
 	dev_dbg(&client->dev, "Detected ADUX1020 with chip id: 0x%04x\n", val);