Skip to contentSkip to conversation

Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y

PATCH In review [email protected] 3 participants 5 messages Oct 13, 2019 – Oct 14, 2019 EFI

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y

From: Narendra K <[email protected]>

For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user for input on platforms where the option may not be applicable. This patch modifies the kconfig option to ask the user for input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y.

Reported-by Geert Uytterhoeven <[email protected]>
Fix-suggested-by Geert Uytterhoeven <[email protected]>
Signed-off-by Narendra K <[email protected]>
---
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/efi/Kconfig +1 -0
index 178ee8106828..b248870a9806 100644
@@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
 
 config EFI_RCI2_TABLE
 	bool "EFI Runtime Configuration Interface Table Version 2 Support"
+	depends on X86 || COMPILE_TEST
 	help
 	  Displays the content of the Runtime Configuration Interface
 	  Table version 2 on Dell EMC PowerEdge systems as a binary
Signature · 5 lines
2.18.1

-- 
With regards,
Narendra K
author
#1 lore raw

Hi Ard,

Quoted 11 lines · Narendra

From: Narendra K <[email protected]>

For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user for input on platforms where the option may not be applicable. This patch modifies the kconfig option to ask the user for input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y.

Reported-by Geert Uytterhoeven <[email protected]>
Fix-suggested-by Geert Uytterhoeven <[email protected]>
Signed-off-by Narendra K <[email protected]>

---

I missed mentioning the following details -

This patch is created on kernel version 5.4-rc2

Changes in v1:
- dropped following changes
'depends on EFI' as it is implied
'default n' as 'n' is the default if not mentioned splitting 'bool' to 'bool + prompt'
- added dependency on X86 || COMPILE_TEST
- added the 'Reported-by:' and 'Fix-suggested-by:' to give credit to Geert Uytterhoeven who reported the issue and suggested the fix

Quoted 21 lines
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/efi/Kconfig +1 -0
index 178ee8106828..b248870a9806 100644
@@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
 
 config EFI_RCI2_TABLE
 	bool "EFI Runtime Configuration Interface Table Version 2 Support"
+	depends on X86 || COMPILE_TEST
 	help
 	  Displays the content of the Runtime Configuration Interface
 	  Table version 2 on Dell EMC PowerEdge systems as a binary
Signature · 5 lines
2.18.1

-- 
With regards,
Narendra K
Signature · 2 lines
With regards,
Narendra K
Tested-by on v1 1/1
#2 lore raw
In reply to [email protected]

Hi Narendra,

Quoted 9 lines · On Sun, Oct 13, 2019 at 8:57 PM <[email protected]> wrote:

From: Narendra K <[email protected]>

For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user for input on platforms where the option may not be applicable. This patch modifies the kconfig option to ask the user for input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y.

Reported-by Geert Uytterhoeven <[email protected]>
Fix-suggested-by Geert Uytterhoeven <[email protected]>
Suggested-by ...?
Quoted 1 line
Signed-off-by Narendra K <[email protected]>

Thanks for your patch!

Tested-by Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#3 lore raw
Quoted 11 lines · Geert Uytterhoeven

Hi Narendra,

Quoted 7 lines · On Sun, Oct 13, 2019 at 8:57 PM <[email protected]> wrote:

From: Narendra K <[email protected]>

For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user for input on platforms where the option may not be applicable. This patch modifies the kconfig option to ask the user for input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y.

Quoted 5 lines
Quoted 2 lines
Reported-by Geert Uytterhoeven <[email protected]>
Fix-suggested-by Geert Uytterhoeven <[email protected]>
Suggested-by ...?

Indeed

Quoted 6 lines
Quoted 1 line
Signed-off-by Narendra K <[email protected]>

Thanks for your patch!

Tested-by Geert Uytterhoeven <[email protected]>

Thanks all. I'll get this queued as a fix.

author
#4 lore raw
Quoted 15 lines · Ard Biesheuvel

[EXTERNAL EMAIL]

Quoted 11 lines · Geert Uytterhoeven

Hi Narendra,

Quoted 7 lines · On Sun, Oct 13, 2019 at 8:57 PM <[email protected]> wrote:

From: Narendra K <[email protected]>

For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user for input on platforms where the option may not be applicable. This patch modifies the kconfig option to ask the user for input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Reported-by Geert Uytterhoeven <[email protected]>
Fix-suggested-by Geert Uytterhoeven <[email protected]>
Suggested-by ...?

Indeed

Hi Ard/Geert,

Thank you for correcting this. Should the patch be resubmitted with the above change made ?

Quoted 9 lines
Quoted 7 lines
Quoted 2 lines
Signed-off-by Narendra K <[email protected]>

Thanks for your patch!

Tested-by Geert Uytterhoeven <[email protected]>

Thanks all. I'll get this queued as a fix.

Thank you for review comments.

Signature · 2 lines
With regards,
Narendra K