drm/dp-mst: remove unused variable
Subsystems (2)
PATCH 1/1 drm/dp-mst: remove unused variable
The variable 'dev' is no longer used and the compiler rightly complains that it should be removed.
../drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_atomic_get_mst_topology_state’:../drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable ‘dev’ [-Wunused-variable]
struct drm_device *dev = mgr->dev;
^~~Rework to remove the unused variable.
--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/drm_dp_mst_topology.c +0 -2
@@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state (struct drm_atomic_state *state,struct drm_dp_mst_topology_mgr *mgr) { -struct drm_device *dev = mgr->dev; -return to_dp_mst_topology_state (drm_atomic_get_private_obj_state (state, &mgr->base)); }EXPORT_SYMBOL (drm_atomic_get_mst_topology_state);
Signature · 1 line
2.20.1
Quoted 6 lines · Anders Roxell
The variable 'dev' is no longer used and the compiler rightly complains that it should be removed.
../drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_atomic_get_mst_topology_state’:../drivers/gpu/drm/drm_dp_mst_topology.c:4187:21: warning: unused variable ‘dev’ [-Wunused-variable]
Quoted 7 lines
struct drm_device *dev = mgr->dev; ^~~Rework to remove the unused variable.
Fixes 83fa9842afe7 ("drm/dp-mst: Drop connection_mutex check")Signed-off-by Anders Roxell <[email protected]>
Hi Anders,
Thank you for your patch! Manasi has already posted a patch for this:
https://patchwork.freedesktop.org/patch/335358/
It's reviewed, so we're just waiting for it to land.
Sean
Quoted 18 lines
--- drivers/gpu/drm/drm_dp_mst_topology.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/drm_dp_mst_topology.c +0
-3@@ -4184,8 +4184,6 @@ EXPORT_SYMBOL(drm_dp_mst_topology_state_funcs);struct drm_dp_mst_topology_state *drm_atomic_get_mst_topology_state (struct drm_atomic_state *state,struct drm_dp_mst_topology_mgr *mgr) { -struct drm_device *dev = mgr->dev; -return to_dp_mst_topology_state (drm_atomic_get_private_obj_state (state, &mgr->base)); }EXPORT_SYMBOL (drm_atomic_get_mst_topology_state); --
Quoted 2 lines
2.20.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel