net: dsa: sja1105: Use the correct style for SPDX License Identifier
PATCH 1/1 net: dsa: sja1105: Use the correct style for SPDX License Identifier
This patch corrects the SPDX License Identifier style in header files related to Distributed Switch Architecture drivers for NXP SJA1105 series Ethernet switch support. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used)
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
--- drivers/net/dsa/sja1105/sja1105.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_dynamic_config.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_ptp.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_static_config.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_tas.h | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)
drivers/net/dsa/sja1105/sja1105.h +2 -2
@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH * Copyright (c) 2018-2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_H
drivers/net/dsa/sja1105/sja1105_dynamic_config.h +2 -2
@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2019, Vladimir Oltean <[email protected]> +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_DYNAMIC_CONFIG_H#define _SJA1105_DYNAMIC_CONFIG_H
drivers/net/dsa/sja1105/sja1105_ptp.h +2 -2
@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2019, Vladimir Oltean <[email protected]> +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_PTP_H#define _SJA1105_PTP_H
drivers/net/dsa/sja1105/sja1105_static_config.h +2 -2
@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: BSD-3-Clause -* Copyright (c) 2016-2018, NXP Semiconductors +/* SPDX-License-Identifier: BSD-3-Clause */ +/* Copyright (c) 2016-2018, NXP Semiconductors * Copyright (c) 2018-2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_STATIC_CONFIG_H
drivers/net/dsa/sja1105/sja1105_tas.h +2 -2
@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2019, Vladimir Oltean <[email protected]> +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_TAS_H#define _SJA1105_TAS_H
Signature · 1 line
2.17.1
Hi Nishad,
Quoted 8 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header files related to Distributed Switch Architecture drivers for NXP SJA1105 series Ethernet switch support. For C header files
Documentation/process/license-rules.rstmandates C-like comments (opposed to C source files where C++ style should be used)
Quoted 6 lines
Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>---
Your commit message has nothing to do with what you're fixing, but whatever. The SPDX identifiers _are_ using C-like comments.
Quoted 70 lines
drivers/net/dsa/sja1105/sja1105.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_dynamic_config.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_ptp.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_static_config.h | 4 ++-- drivers/net/dsa/sja1105/sja1105_tas.h | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)drivers/net/dsa/sja1105/sja1105.h +2
-2@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2018, Sensor-Technik Wiedemann GmbH * Copyright (c) 2018-2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_Hdrivers/net/dsa/sja1105/sja1105_dynamic_config.h +2
-2@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2019, Vladimir Oltean <[email protected]> +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_DYNAMIC_CONFIG_H#define _SJA1105_DYNAMIC_CONFIG_Hdrivers/net/dsa/sja1105/sja1105_ptp.h +2
-2@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2019, Vladimir Oltean <[email protected]> +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_PTP_H#define _SJA1105_PTP_Hdrivers/net/dsa/sja1105/sja1105_static_config.h +2
-2@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: BSD-3-Clause -* Copyright (c) 2016-2018, NXP Semiconductors +/* SPDX-License-Identifier: BSD-3-Clause */ +/* Copyright (c) 2016-2018, NXP Semiconductors * Copyright (c) 2018-2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_STATIC_CONFIG_Hdrivers/net/dsa/sja1105/sja1105_tas.h +2
-3@@ -1,5 +1,5 @@ -/* SPDX-License-Identifier: GPL-2.0 -* Copyright (c) 2019, Vladimir Oltean <[email protected]> +/* SPDX-License-Identifier: GPL-2.0 */ +/* Copyright (c) 2019, Vladimir Oltean <[email protected]> */ #ifndef _SJA1105_TAS_H#define _SJA1105_TAS_H --2.17.1
Andrew Lunn
maintainerQuoted 14 lines · Vladimir Oltean
Hi Nishad,
Quoted 11 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header files related to Distributed Switch Architecture drivers for NXP SJA1105 series Ethernet switch support. For C header files
Documentation/process/license-rules.rstmandates C-like comments (opposed to C source files where C++ style should be used)Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.
Quoted 6 lines
Quoted 3 lines
Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>---
Your commit message has nothing to do with what you're fixing, but whatever. The SPDX identifiers _are_ using C-like comments.
Agreed. Please fix the commit message, and maybe make the script generating the commit message, so future uses of it will get the message correct.
Thanks
Andrew
Quoted 22 lines · Andrew Lunn
Quoted 14 lines · Vladimir Oltean
Hi Nishad,
Quoted 11 lines · Nishad Kamdar
This patch corrects the SPDX License Identifier style in header files related to Distributed Switch Architecture drivers for NXP SJA1105 series Ethernet switch support. For C header files
Documentation/process/license-rules.rstmandates C-like comments (opposed to C source files where C++ style should be used)Changes made by using a script provided by Joe Perches here:
https://lkml.org/lkml/2019/2/7/46.Quoted 6 lines
Quoted 3 lines
Suggested-by Joe Perches <[email protected]>Signed-off-by Nishad Kamdar <[email protected]>---
Your commit message has nothing to do with what you're fixing, but whatever. The SPDX identifiers _are_ using C-like comments.
Quoted 6 lines
Agreed. Please fix the commit message, and maybe make the script generating the commit message, so future uses of it will get the message correct.
Thanks
Andrew
Hello Andrew and Vladimir,
I understand your comments.
I will change the commit message in the next version of the patch.
Thanks for the review.
Regards,
Nishad