Skip to contentSkip to conversation

splash screen on the stm32f769 & stm32mp1 boards

PATCH New Yannick Fertré 4 participants 38 messages Oct 7, 2019 – Oct 25, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v5 cover splash screen on the stm32f769 & stm32mp1 boards

Version 1:
- Initial commit.

Version 2:
- swap patches to avoid compilation issue.
- remove panel timings from device tree.

Version 3:
- Share same include file mipi_display.h with kernel linux.
- Rework ltdc driver with last comments of Anatolij Gustshin.
- Check ordering (file dw_mipi_dsi.c).
- Rename mipi_display.c to mipi_dsi.c.

Version 4:
- Add physical set mode operation
- Improve debug trace (display controller ltdc)
- Refresh timings of panels
- Add regulator (dsi controller)
- Add new class DSI_HOST
- Support of panels OTM800A & RM68200

Version 5:
- Rework dsi host patch with last comments of Simon Glass.

This serie contains all patchsets needed for displaying a splash screen on the stm32f769 & stm32mp1 boards.
A new config has been created configs/stm32f769-disco_defconfig. This is necessary due to the difference of panels between stm32f769-disco, stm32f746-disco boards & stm32mp1 boards.
A new class DSI_HOST have been created to manage a dsi host between the dsi controller & display controller.

Yannick Fertré (15):
video: bmp: check resolutions of panel/bitmap
video: stm32: stm32_ltdc: add bridge to display controller
include: Add new DCS commands in the enum list
video: add support of MIPI DSI interface
dm: Add a dsi host uclass
video: add MIPI DSI host controller bridge
video: add support of STM32 MIPI DSI controller driver
video: add support of panel OTM8009A
video: add support of panel RM68200
board: Add STM32F769 SoC, discovery board support
ARM: dts: stm32f769: add display for STM32F769 disco board
ARM: dts: stm32mp1: add dsi host for stm32mp157c-ev1 board
ARM: dts: stm32mp1: add dsi host for stm32mp157c-dk2 board
stm32mp1: configs: update video
stm32mp1: configs: add display devices

 arch/arm/dts/stm32f769-disco-u-boot.dtsi |  62 +++
 arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi |   7 +
 arch/arm/dts/stm32mp157c-ev1-u-boot.dtsi |   5 +
 arch/sandbox/dts/sandbox.dts             |   6 +-
 configs/sandbox_defconfig                |   1 +
 configs/stm32f769-disco_defconfig        |  63 +++
 configs/stm32mp15_basic_defconfig        |   6 +
 configs/stm32mp15_optee_defconfig        |   6 +
 configs/stm32mp15_trusted_defconfig      |   6 +
 drivers/video/Kconfig                    |  47 ++
 drivers/video/Makefile                   |   6 +
 drivers/video/dsi-host-uclass.c          |  39 ++
 drivers/video/dw_mipi_dsi.c              | 838 +++++++++++++++++++++++++++++++
 drivers/video/mipi_dsi.c                 | 828 ++++++++++++++++++++++++++++++
 drivers/video/orisetech_otm8009a.c       | 379 ++++++++++++++
 drivers/video/raydium-rm68200.c          | 351 +++++++++++++
 drivers/video/sandbox_dsi_host.c         |  90 ++++
 drivers/video/stm32/Kconfig              |   9 +
 drivers/video/stm32/Makefile             |   1 +
 drivers/video/stm32/stm32_dsi.c          | 490 ++++++++++++++++++
 drivers/video/stm32/stm32_ltdc.c         | 143 +++---
 drivers/video/video_bmp.c                |   7 +
 include/configs/stm32mp1.h               |   7 +
 include/dm/uclass-id.h                   |   1 +
 include/dsi_host.h                       |  73 +++
 include/mipi_display.h                   |   8 +
 include/mipi_dsi.h                       | 466 +++++++++++++++++
 test/dm/Makefile                         |   1 +
 test/dm/dsi_host.c                       |  58 +++
 29 files changed, 3943 insertions(+), 61 deletions(-)
 create mode 100644 configs/stm32f769-disco_defconfig
 create mode 100644 drivers/video/dsi-host-uclass.c
 create mode 100644 drivers/video/dw_mipi_dsi.c
 create mode 100644 drivers/video/mipi_dsi.c
 create mode 100644 drivers/video/orisetech_otm8009a.c
 create mode 100644 drivers/video/raydium-rm68200.c
 create mode 100644 drivers/video/sandbox_dsi_host.c
 create mode 100644 drivers/video/stm32/stm32_dsi.c
 create mode 100644 include/dsi_host.h
 create mode 100644 include/mipi_dsi.h
 create mode 100644 test/dm/dsi_host.c
Signature · 1 line
2.7.4
#1 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

If the size of the bitmap is bigger than the size of the panel then errors appear when calculating axis alignment and the copy of bitmap is done outside of framebuffer.

---
 drivers/video/video_bmp.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/video/video_bmp.c +7 -0
index 193f37d..4af1fb4 100644
@@ -249,6 +249,13 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 
 	padded_width = (width & 0x3 ? (width & ~0x3) + 4 : width);
 
+	/* check if picture size exceeds panel size */
+	if ((pwidth < width) || (priv->ysize < height)) {
+		printf("Error: BMP size %d x %d is bigger than panel size %d x %d\n",
+		       (int)width, (int)height, priv->xsize, priv->ysize);
+		return -EINVAL;
+	}
+
 	if (align) {
 		video_splash_align_axis(&x, priv->xsize, width);
 		video_splash_align_axis(&y, priv->ysize, height);
Signature · 1 line
2.7.4
#2 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

Quoted 17 lines · Yannick Fertré

If the size of the bitmap is bigger than the size of the panel then errors appear when calculating axis alignment and the copy of bitmap is done outside of framebuffer.

---
  drivers/video/video_bmp.c | 7 +++++++
  1 file changed, 7 insertions(+)
drivers/video/video_bmp.c +0 -0
index 193f37d..4af1fb4 100644
@@ -249,6 +249,13 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 
  	padded_width = (width & 0x3 ? (width & ~0x3) + 4 : width);
 

drivers/video/video_bmp.c int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y, · line 261

Quoted 10 lines
drivers/video/video_bmp.c +7 -0
+	/* check if picture size exceeds panel size */
+	if ((pwidth < width) || (priv->ysize < height)) {
+		printf("Error: BMP size %d x %d is bigger than panel size %d x %d\n",
+		       (int)width, (int)height, priv->xsize, priv->ysize);
+		return -EINVAL;
+	}
+
  	if (align) {
  		video_splash_align_axis(&x, priv->xsize, width);
  		video_splash_align_axis(&y, priv->ysize, height);

This is followed by:

        if ((x + width) > pwidth)
                width = pwidth - x;
        if ((y + height) > priv->ysize)
                height = priv->ysize - y;

These lines will clip a bitmap that given the left upper corner x, y does not fit onto the screen.

So isn't this patch superfluous?

What is missing are checks for x and y.

For testing I have used qemu_x86 and added

     #define CONFIG_BMP_24BPP y

to the top of drivers/video/video_bmp.c and loaded a 24bit bitmap.

Clipping works as expected. But passing a value of x exceeding the screen width lead to a crash.

What I really dislike in the existing coding is that CONFIG_BMP_*BPP is defined in includes instead of using Kconfig but that is a different story.

Best regards

Heinrich

#3 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

Hi Heinrich, all

Quoted 52 lines · Heinrich Schuchardt
Quoted 17 lines · Yannick Fertré

If the size of the bitmap is bigger than the size of the panel then errors appear when calculating axis alignment and the copy of bitmap is done outside of framebuffer.

---
  drivers/video/video_bmp.c | 7 +++++++

  1 file changed, 7 insertions(+)
drivers/video/video_bmp.c +0 -0
index 193f37d..4af1fb4 100644
@@ -249,6 +249,13 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 
       padded_width = (width & 0x3 ? (width & ~0x3) + 4 : width);
 

drivers/video/video_bmp.c int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y, · line 261

Quoted 10 lines
drivers/video/video_bmp.c +7 -0
+    /* check if picture size exceeds panel size */
+    if ((pwidth < width) || (priv->ysize < height)) {
+        printf("Error: BMP size %d x %d is bigger than panel size %d x %d\n",
+               (int)width, (int)height, priv->xsize, priv->ysize);
+        return -EINVAL;
+    }
+
       if (align) {
           video_splash_align_axis(&x, priv->xsize, width);
           video_splash_align_axis(&y, priv->ysize, height);

This is followed by:

        if ((x + width) > pwidth)
                width = pwidth - x;
        if ((y + height) > priv->ysize)
                height = priv->ysize - y;

These lines will clip a bitmap that given the left upper corner x, y does not fit onto the screen.

So isn't this patch superfluous?

What is missing are checks for x and y.

For testing I have used qemu_x86 and added

    #define CONFIG_BMP_24BPP y

to the top of drivers/video/video_bmp.c and loaded a 24bit bitmap.

Clipping works as expected. But passing a value of x exceeding the screen width lead to a crash.

Quoted 6 lines

What I really dislike in the existing coding is that CONFIG_BMP_*BPP is defined in includes instead of using Kconfig but that is a different story.

Best regards

Heinrich

For information all this series patches have been applied on u-boot/master excepts  this one.

Unfortunately, without this patch, stm32f746-discovery board doesn't boot anymore.

Heinrich, could this patch be merged, waiting for a clean patch from Yannick ?

Regards

Patrice

#4 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

Hi Patrice,

On Thu, 24 Oct 2019 14:05:41 +0000
Patrice CHOTARD patrice.chotard at st.com wrote:
...

Quoted 2 lines

For information all this series patches have been applied on u-boot/master excepts  this one.

Yes, I skipped this patch when applying the series since it was under discussion.

Quoted 3 lines

Unfortunately, without this patch, stm32f746-discovery board doesn't boot anymore.

Heinrich, could this patch be merged, waiting for a clean patch from Yannick ?

As far as I can see, Yannick didn't respond to questions from Heinrich yet.

--
Anatolij

#5 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

In reply to Patrice CHOTARD
Quoted 58 lines · Patrice CHOTARD

Hi Heinrich, all

Quoted 55 lines · Heinrich Schuchardt
Quoted 17 lines · Yannick Fertré

If the size of the bitmap is bigger than the size of the panel then errors appear when calculating axis alignment and the copy of bitmap is done outside of framebuffer.

---
   drivers/video/video_bmp.c | 7 +++++++
   1 file changed, 7 insertions(+)
drivers/video/video_bmp.c +0 -0
index 193f37d..4af1fb4 100644
@@ -249,6 +249,13 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 
       padded_width = (width & 0x3 ? (width & ~0x3) + 4 : width);
 

drivers/video/video_bmp.c int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y, · line 261

Quoted 10 lines
drivers/video/video_bmp.c +7 -0
+    /* check if picture size exceeds panel size */
+    if ((pwidth < width) || (priv->ysize < height)) {
+        printf("Error: BMP size %d x %d is bigger than panel size %d x %d\n",
+               (int)width, (int)height, priv->xsize, priv->ysize);
+        return -EINVAL;
+    }
+
       if (align) {
           video_splash_align_axis(&x, priv->xsize, width);
           video_splash_align_axis(&y, priv->ysize, height);

This is followed by:

        if ((x + width) > pwidth)
                width = pwidth - x;
        if ((y + height) > priv->ysize)
                height = priv->ysize - y;

These lines will clip a bitmap that given the left upper corner x, y does not fit onto the screen.

So isn't this patch superfluous?

What is missing are checks for x and y.

For testing I have used qemu_x86 and added

    #define CONFIG_BMP_24BPP y

to the top of drivers/video/video_bmp.c and loaded a 24bit bitmap.

Clipping works as expected. But passing a value of x exceeding the screen width lead to a crash.

What I really dislike in the existing coding is that CONFIG_BMP_*BPP is defined in includes instead of using Kconfig but that is a different story.

Quoted 7 lines
Quoted 3 lines

Best regards

Heinrich

For information all this series patches have been applied on u-boot/master excepts  this one.

Unfortunately, without this patch, stm32f746-discovery board doesn't boot anymore.

I still do not understand why this patch is needed.

Could you, please, try to analyze why the board does not boot.

What is wrong with the existing code for clipping?
Or is the non-booting just coincidence but the bug is somewhere else?

What are the values of the parameters passed to video_bmp_display()? Which bitmap file are you using?
What is the size of the display?

Best regards

Heinrich

Quoted 7 lines

Heinrich, could this patch be merged, waiting for a clean patch from Yannick ?

Regards

Patrice

#6 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

Hi Heinrich

Quoted 69 lines · Heinrich Schuchardt
Quoted 58 lines · Patrice CHOTARD

Hi Heinrich, all

Quoted 55 lines · Heinrich Schuchardt
Quoted 17 lines · Yannick Fertré

If the size of the bitmap is bigger than the size of the panel then errors appear when calculating axis alignment and the copy of bitmap is done outside of framebuffer.

---
   drivers/video/video_bmp.c | 7 +++++++

   1 file changed, 7 insertions(+)
drivers/video/video_bmp.c +0 -0
index 193f37d..4af1fb4 100644
@@ -249,6 +249,13 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 
        padded_width = (width & 0x3 ? (width & ~0x3) + 4 : width);
 

drivers/video/video_bmp.c int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y, · line 261

Quoted 10 lines
drivers/video/video_bmp.c +7 -0
+    /* check if picture size exceeds panel size */
+    if ((pwidth < width) || (priv->ysize < height)) {
+        printf("Error: BMP size %d x %d is bigger than panel size %d x %d\n",
+               (int)width, (int)height, priv->xsize, priv->ysize);
+        return -EINVAL;
+    }
+
        if (align) {
            video_splash_align_axis(&x, priv->xsize, width);
            video_splash_align_axis(&y, priv->ysize, height);

This is followed by:

         if ((x + width) > pwidth)
                 width = pwidth - x;
         if ((y + height) > priv->ysize)
                 height = priv->ysize - y;

These lines will clip a bitmap that given the left upper corner x, y does not fit onto the screen.

So isn't this patch superfluous?

What is missing are checks for x and y.

For testing I have used qemu_x86 and added

     #define CONFIG_BMP_24BPP y

to the top of drivers/video/video_bmp.c and loaded a 24bit bitmap.

Clipping works as expected. But passing a value of x exceeding the screen width lead to a crash.

What I really dislike in the existing coding is that CONFIG_BMP_*BPP is defined in includes instead of using Kconfig but that is a different story.

Quoted 7 lines
Quoted 3 lines

Best regards

Heinrich

For information all this series patches have been applied on u-boot/master excepts  this one.

Unfortunately, without this patch, stm32f746-discovery board doesn't boot anymore.

I still do not understand why this patch is needed.

Quoted 8 lines

Could you, please, try to analyze why the board does not boot.

What is wrong with the existing code for clipping?
Or is the non-booting just coincidence but the bug is somewhere else?

What are the values of the parameters passed to video_bmp_display()? Which bitmap file are you using?
What is the size of the display?

To sum-up, on all STM32 boards, the same BMP splashcreen is used.

In the particular case of STM32F746-Disco board, the panel size is smaller then the BMP size.

So, some size check must be done to avoid overflow when writing inside the framebuffer.

If needed, Yannick, which is multimedia expert, can give you more precise details.

Thanks

Patrice

Quoted 13 lines

Best regards

Heinrich

Quoted 7 lines

Heinrich, could this patch be merged, waiting for a clean patch from Yannick ?

Regards

Patrice

#7 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

Quoted 82 lines · Patrice CHOTARD

Hi Heinrich

Quoted 69 lines · Heinrich Schuchardt
Quoted 58 lines · Patrice CHOTARD

Hi Heinrich, all

Quoted 55 lines · Heinrich Schuchardt
Quoted 17 lines · Yannick Fertré

If the size of the bitmap is bigger than the size of the panel then errors appear when calculating axis alignment and the copy of bitmap is done outside of framebuffer.

---
   drivers/video/video_bmp.c | 7 +++++++

   1 file changed, 7 insertions(+)
drivers/video/video_bmp.c +0 -0
index 193f37d..4af1fb4 100644
@@ -249,6 +249,13 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 
        padded_width = (width & 0x3 ? (width & ~0x3) + 4 : width);
 

drivers/video/video_bmp.c int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y, · line 261

Quoted 10 lines
drivers/video/video_bmp.c +7 -0
+    /* check if picture size exceeds panel size */
+    if ((pwidth < width) || (priv->ysize < height)) {
+        printf("Error: BMP size %d x %d is bigger than panel size %d x %d\n",
+               (int)width, (int)height, priv->xsize, priv->ysize);
+        return -EINVAL;
+    }
+
        if (align) {
            video_splash_align_axis(&x, priv->xsize, width);
            video_splash_align_axis(&y, priv->ysize, height);

This is followed by:

         if ((x + width) > pwidth)
                 width = pwidth - x;
         if ((y + height) > priv->ysize)
                 height = priv->ysize - y;

These lines will clip a bitmap that given the left upper corner x, y does not fit onto the screen.

So isn't this patch superfluous?

What is missing are checks for x and y.

For testing I have used qemu_x86 and added

     #define CONFIG_BMP_24BPP y

to the top of drivers/video/video_bmp.c and loaded a 24bit bitmap.

Clipping works as expected. But passing a value of x exceeding the screen width lead to a crash.

What I really dislike in the existing coding is that CONFIG_BMP_*BPP is defined in includes instead of using Kconfig but that is a different story.

Quoted 7 lines
Quoted 3 lines

Best regards

Heinrich

For information all this series patches have been applied on u-boot/master excepts  this one.

Unfortunately, without this patch, stm32f746-discovery board doesn't boot anymore.

I still do not understand why this patch is needed.

Quoted 8 lines

Could you, please, try to analyze why the board does not boot.

What is wrong with the existing code for clipping?
Or is the non-booting just coincidence but the bug is somewhere else?

What are the values of the parameters passed to video_bmp_display()? Which bitmap file are you using?
What is the size of the display?

Quoted 5 lines

To sum-up, on all STM32 boards, the same BMP splashcreen is used.

In the particular case of STM32F746-Disco board, the panel size is smaller then the BMP size.

So, some size check must be done to avoid overflow when writing inside the framebuffer.

That is why we have lines to clip images:

          if ((x + width) > pwidth)
                  width = pwidth - x;
          if ((y + height) > priv->ysize)
                  height = priv->ysize - y;

Why is this not working in you case?

Best regards

Heinrich

Quoted 22 lines

If needed, Yannick, which is multimedia expert, can give you more precise details.

Thanks

Patrice

Quoted 13 lines

Best regards

Heinrich

Quoted 7 lines

Heinrich, could this patch be merged, waiting for a clean patch from Yannick ?

Regards

Patrice

#8 lore raw

PATCH v5 1/15 video: bmp: check resolutions of panel/bitmap

In reply to Heinrich Schuchardt

Hello Heinrich,

Sorry for the delay.

This match is not superfluous. On the STM32F746 board, a bitmap larger than the panel resolution is embedded.

Without this patch, the board does not boot.

I propose to send an additional patch that checks the coordinates.

Best regards

Signature · 2 lines
Yannick Fertré Microcontrollers and Digital ICs Group | 
Microcontrolleurs Division
Quoted 95 lines · Heinrich Schuchardt
Quoted 63 lines · Patrice CHOTARD

Hi Heinrich, all

Quoted 60 lines · Heinrich Schuchardt
Quoted 27 lines · Yannick Fertré

If the size of the bitmap is bigger than the size of the panel then errors appear when calculating axis alignment and the copy of bitmap is done outside of framebuffer.

---
   drivers/video/video_bmp.c | 7 +++++++

   1 file changed, 7 insertions(+)
drivers/video/video_bmp.c +7 -0
index 193f37d..4af1fb4 100644
@@ -249,6 +249,13 @@ int video_bmp_display(struct udevice *dev, 
 ulong bmp_image, int x, int y,
 
        padded_width = (width & 0x3 ? (width & ~0x3) + 4 : width);
 
+    /* check if picture size exceeds panel size */
+    if ((pwidth < width) || (priv->ysize < height)) {
+        printf("Error: BMP size %d x %d is bigger than panel size 
 %d x %d\n",
+               (int)width, (int)height, priv->xsize, priv->ysize);
+        return -EINVAL;
+    }
+
        if (align) {
Quoted 2 lines

           video_splash_align_axis(&x, priv->xsize, width); video_splash_align_axis(&y, priv->ysize, height);

This is followed by:

         if ((x + width) > pwidth)
                 width = pwidth - x;
         if ((y + height) > priv->ysize)
                 height = priv->ysize - y;

These lines will clip a bitmap that given the left upper corner x, y does not fit onto the screen.

So isn't this patch superfluous?

What is missing are checks for x and y.

For testing I have used qemu_x86 and added

     #define CONFIG_BMP_24BPP y

to the top of drivers/video/video_bmp.c and loaded a 24bit bitmap.

Clipping works as expected. But passing a value of x exceeding the screen width lead to a crash.

What I really dislike in the existing coding is that CONFIG_BMP_*BPP is defined in includes instead of using Kconfig but that is a different story.

Best regards

Quoted 7 lines
Quoted 1 line

Heinrich

For information all this series patches have been applied on u-boot/master excepts  this one.

Unfortunately, without this patch, stm32f746-discovery board doesn't boot anymore.

I still do not understand why this patch is needed.

Could you, please, try to analyze why the board does not boot.

What is wrong with the existing code for clipping?
Or is the non-booting just coincidence but the bug is somewhere else?

What are the values of the parameters passed to video_bmp_display()? Which bitmap file are you using?
What is the size of the display?

Best regards

Heinrich

Quoted 8 lines

Heinrich, could this patch be merged, waiting for a clean patch from Yannick ?

Regards

Patrice

#9 lore raw

PATCH v5 2/15 video: stm32: stm32_ltdc: add bridge to display controller

In reply to Yannick Fertré

Manage a bridge insert between the display controller & a panel.

---
 drivers/video/stm32/stm32_ltdc.c | 143 +++++++++++++++++++++++----------------
 1 file changed, 83 insertions(+), 60 deletions(-)
drivers/video/stm32/stm32_ltdc.c +83 -60
index dc6c889..59ff692 100644
@@ -7,19 +7,18 @@
 
 #include <common.h>
 #include <clk.h>
+#include <display.h>
 #include <dm.h>
 #include <panel.h>
 #include <reset.h>
 #include <video.h>
+#include <video_bridge.h>
 #include <asm/io.h>
 #include <asm/arch/gpio.h>
 #include <dm/device-internal.h>
 
-DECLARE_GLOBAL_DATA_PTR;
-
 struct stm32_ltdc_priv {
 	void __iomem *regs;
-	struct display_timing timing;
 	enum video_log2_bpp l2bpp;
 	u32 bg_col_argb;
 	u32 crop_x, crop_y, crop_w, crop_h;
@@ -174,8 +173,8 @@ static u32 stm32_ltdc_get_pixel_format(enum video_log2_bpp l2bpp)
 	case VIDEO_BPP2:
 	case VIDEO_BPP4:
 	default:
-		debug("%s: warning %dbpp not supported yet, %dbpp instead\n",
-		      __func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16));
+		pr_warn("%s: warning %dbpp not supported yet, %dbpp instead\n",
+			__func__, VNBITS(l2bpp), VNBITS(VIDEO_BPP16));
 		pf = PF_RGB565;
 		break;
 	}
@@ -209,23 +208,23 @@ static void stm32_ltdc_enable(struct stm32_ltdc_priv *priv)
 	setbits_le32(priv->regs + LTDC_GCR, GCR_LTDCEN);
 }
 
-static void stm32_ltdc_set_mode(struct stm32_ltdc_priv *priv)
+static void stm32_ltdc_set_mode(struct stm32_ltdc_priv *priv,
+				struct display_timing *timings)
 {
 	void __iomem *regs = priv->regs;
-	struct display_timing *timing = &priv->timing;
 	u32 hsync, vsync, acc_hbp, acc_vbp, acc_act_w, acc_act_h;
 	u32 total_w, total_h;
 	u32 val;
 
 	/* Convert video timings to ltdc timings */
-	hsync = timing->hsync_len.typ - 1;
-	vsync = timing->vsync_len.typ - 1;
-	acc_hbp = hsync + timing->hback_porch.typ;
-	acc_vbp = vsync + timing->vback_porch.typ;
-	acc_act_w = acc_hbp + timing->hactive.typ;
-	acc_act_h = acc_vbp + timing->vactive.typ;
-	total_w = acc_act_w + timing->hfront_porch.typ;
-	total_h = acc_act_h + timing->vfront_porch.typ;
+	hsync = timings->hsync_len.typ - 1;
+	vsync = timings->vsync_len.typ - 1;
+	acc_hbp = hsync + timings->hback_porch.typ;
+	acc_vbp = vsync + timings->vback_porch.typ;
+	acc_act_w = acc_hbp + timings->hactive.typ;
+	acc_act_h = acc_vbp + timings->vactive.typ;
+	total_w = acc_act_w + timings->hfront_porch.typ;
+	total_h = acc_act_h + timings->vfront_porch.typ;
 
 	/* Synchronization sizes */
 	val = (hsync << 16) | vsync;
@@ -247,14 +246,14 @@ static void stm32_ltdc_set_mode(struct stm32_ltdc_priv *priv)
 
 	/* Signal polarities */
 	val = 0;
-	debug("%s: timing->flags 0x%08x\n", __func__, timing->flags);
-	if (timing->flags & DISPLAY_FLAGS_HSYNC_HIGH)
+	debug("%s: timing->flags 0x%08x\n", __func__, timings->flags);
+	if (timings->flags & DISPLAY_FLAGS_HSYNC_HIGH)
 		val |= GCR_HSPOL;
-	if (timing->flags & DISPLAY_FLAGS_VSYNC_HIGH)
+	if (timings->flags & DISPLAY_FLAGS_VSYNC_HIGH)
 		val |= GCR_VSPOL;
-	if (timing->flags & DISPLAY_FLAGS_DE_HIGH)
+	if (timings->flags & DISPLAY_FLAGS_DE_HIGH)
 		val |= GCR_DEPOL;
-	if (timing->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
+	if (timings->flags & DISPLAY_FLAGS_PIXDATA_NEGEDGE)
 		val |= GCR_PCPOL;
 	clrsetbits_le32(regs + LTDC_GCR,
 			GCR_HSPOL | GCR_VSPOL | GCR_DEPOL | GCR_PCPOL, val);
@@ -330,96 +329,120 @@ static int stm32_ltdc_probe(struct udevice *dev)
 	struct video_uc_platdata *uc_plat = dev_get_uclass_platdata(dev);
 	struct video_priv *uc_priv = dev_get_uclass_priv(dev);
 	struct stm32_ltdc_priv *priv = dev_get_priv(dev);
-	struct udevice *panel;
+	struct udevice *bridge = NULL;
+	struct udevice *panel = NULL;
+	struct display_timing timings;
 	struct clk pclk;
 	struct reset_ctl rst;
-	int rate, ret;
+	int ret;
 
 	priv->regs = (void *)dev_read_addr(dev);
 	if ((fdt_addr_t)priv->regs == FDT_ADDR_T_NONE) {
-		debug("%s: ltdc dt register address error\n", __func__);
+		dev_err(dev, "ltdc dt register address error\n");
 		return -EINVAL;
 	}
 
 	ret = clk_get_by_index(dev, 0, &pclk);
 	if (ret) {
-		debug("%s: peripheral clock get error %d\n", __func__, ret);
+		dev_err(dev, "peripheral clock get error %d\n", ret);
 		return ret;
 	}
 
 	ret = clk_enable(&pclk);
 	if (ret) {
-		debug("%s: peripheral clock enable error %d\n",
-		      __func__, ret);
+		dev_err(dev, "peripheral clock enable error %d\n", ret);
 		return ret;
 	}
 
-	ret = reset_get_by_index(dev, 0, &rst);
+	ret = uclass_first_device_err(UCLASS_PANEL, &panel);
 	if (ret) {
-		debug("%s: missing ltdc hardware reset\n", __func__);
-		return -ENODEV;
+		if (ret != -ENODEV)
+			dev_err(dev, "panel device error %d\n", ret);
+		return ret;
 	}
 
-	/* Reset */
-	reset_deassert(&rst);
-
-	ret = uclass_first_device(UCLASS_PANEL, &panel);
+	ret = panel_get_display_timing(panel, &timings);
 	if (ret) {
-		debug("%s: panel device error %d\n", __func__, ret);
-		return ret;
+		ret = fdtdec_decode_display_timing(gd->fdt_blob,
+						   dev_of_offset(panel),
+						   0, &timings);
+		if (ret) {
+			dev_err(dev, "decode display timing error %d\n", ret);
+			return ret;
+		}
 	}
 
-	ret = panel_enable_backlight(panel);
+	ret = clk_set_rate(&pclk, timings.pixelclock.typ);
+	if (ret)
+		dev_warn(dev, "fail to set pixel clock %d hz\n",
+			 timings.pixelclock.typ);
+
+	debug("%s: Set pixel clock req %d hz get %ld hz\n", __func__,
+	      timings.pixelclock.typ, clk_get_rate(&pclk));
+
+	ret = reset_get_by_index(dev, 0, &rst);
 	if (ret) {
-		debug("%s: panel %s enable backlight error %d\n",
-		      __func__, panel->name, ret);
+		dev_err(dev, "missing ltdc hardware reset\n");
 		return ret;
 	}
 
-	ret = fdtdec_decode_display_timing(gd->fdt_blob,
-					   dev_of_offset(dev), 0,
-					   &priv->timing);
-	if (ret) {
-		debug("%s: decode display timing error %d\n",
-		      __func__, ret);
-		return -EINVAL;
-	}
+	/* Reset */
+	reset_deassert(&rst);
 
-	rate = clk_set_rate(&pclk, priv->timing.pixelclock.typ);
-	if (rate < 0) {
-		debug("%s: fail to set pixel clock %d hz %d hz\n",
-		      __func__, priv->timing.pixelclock.typ, rate);
-		return rate;
+	if (IS_ENABLED(CONFIG_VIDEO_BRIDGE)) {
+		ret = uclass_get_device(UCLASS_VIDEO_BRIDGE, 0, &bridge);
+		if (ret)
+			debug("No video bridge, or no backlight on bridge\n");
+
+		if (bridge) {
+			ret = video_bridge_attach(bridge);
+			if (ret) {
+				dev_err(dev, "fail to attach bridge\n");
+				return ret;
+			}
+		}
 	}
 
-	debug("%s: Set pixel clock req %d hz get %d hz\n", __func__,
-	      priv->timing.pixelclock.typ, rate);
-
 	/* TODO Below parameters are hard-coded for the moment... */
 	priv->l2bpp = VIDEO_BPP16;
 	priv->bg_col_argb = 0xFFFFFFFF; /* white no transparency */
 	priv->crop_x = 0;
 	priv->crop_y = 0;
-	priv->crop_w = priv->timing.hactive.typ;
-	priv->crop_h = priv->timing.vactive.typ;
+	priv->crop_w = timings.hactive.typ;
+	priv->crop_h = timings.vactive.typ;
 	priv->alpha = 0xFF;
 
 	debug("%s: %dx%d %dbpp frame buffer at 0x%lx\n", __func__,
-	      priv->timing.hactive.typ, priv->timing.vactive.typ,
+	      timings.hactive.typ, timings.vactive.typ,
 	      VNBITS(priv->l2bpp), uc_plat->base);
 	debug("%s: crop %d,%d %dx%d bg 0x%08x alpha %d\n", __func__,
 	      priv->crop_x, priv->crop_y, priv->crop_w, priv->crop_h,
 	      priv->bg_col_argb, priv->alpha);
 
 	/* Configure & start LTDC */
-	stm32_ltdc_set_mode(priv);
+	stm32_ltdc_set_mode(priv, &timings);
 	stm32_ltdc_set_layer1(priv, uc_plat->base);
 	stm32_ltdc_enable(priv);
 
-	uc_priv->xsize = priv->timing.hactive.typ;
-	uc_priv->ysize = priv->timing.vactive.typ;
+	uc_priv->xsize = timings.hactive.typ;
+	uc_priv->ysize = timings.vactive.typ;
 	uc_priv->bpix = priv->l2bpp;
 
+	if (!bridge) {
+		ret = panel_enable_backlight(panel);
+		if (ret) {
+			dev_err(dev, "panel %s enable backlight error %d\n",
+				panel->name, ret);
+			return ret;
+		}
+	} else if (IS_ENABLED(CONFIG_VIDEO_BRIDGE)) {
+		ret = video_bridge_set_backlight(bridge, 80);
+		if (ret) {
+			dev_err(dev, "fail to set backlight\n");
+			return ret;
+		}
+	}
+
 	video_set_flush_dcache(dev, true);
 
 	return 0;
Signature · 1 line
2.7.4
#10 lore raw

PATCH v5 2/15 video: stm32: stm32_ltdc: add bridge to display controller

Quoted 6 lines · On Mon, 7 Oct 2019 15:29:02 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Manage a bridge insert between the display controller & a panel.

---
 drivers/video/stm32/stm32_ltdc.c | 143 +++++++++++++++++++++++----------------
 1 file changed, 83 insertions(+), 60 deletions(-)

Applied to u-boot-video/master, thanks!

--
Anatolij

#11 lore raw

PATCH v5 3/15 include: Add new DCS commands in the enum list

In reply to Yannick Fertré

Adding new DCS commands which are specified in the DCS 1.3 spec related to CABC.

---
 include/mipi_display.h | 8 ++++++++
 1 file changed, 8 insertions(+)
include/mipi_display.h +8 -0
index ddcc8ca..19aa65a 100644
@@ -115,6 +115,14 @@ enum {
 	MIPI_DCS_READ_MEMORY_CONTINUE	= 0x3E,
 	MIPI_DCS_SET_TEAR_SCANLINE	= 0x44,
 	MIPI_DCS_GET_SCANLINE		= 0x45,
+	MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51,		/* MIPI DCS 1.3 */
+	MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52,		/* MIPI DCS 1.3 */
+	MIPI_DCS_WRITE_CONTROL_DISPLAY  = 0x53,		/* MIPI DCS 1.3 */
+	MIPI_DCS_GET_CONTROL_DISPLAY	= 0x54,		/* MIPI DCS 1.3 */
+	MIPI_DCS_WRITE_POWER_SAVE	= 0x55,		/* MIPI DCS 1.3 */
+	MIPI_DCS_GET_POWER_SAVE		= 0x56,		/* MIPI DCS 1.3 */
+	MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E,	/* MIPI DCS 1.3 */
+	MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F,	/* MIPI DCS 1.3 */
 	MIPI_DCS_READ_DDB_START		= 0xA1,
 	MIPI_DCS_READ_DDB_CONTINUE	= 0xA8,
 };
Signature · 1 line
2.7.4
#12 lore raw

PATCH v5 3/15 include: Add new DCS commands in the enum list

Quoted 7 lines · On Mon, 7 Oct 2019 15:29:03 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Adding new DCS commands which are specified in the DCS 1.3 spec related to CABC.

---
 include/mipi_display.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Applied to u-boot-video/master, thanks!

--
Anatolij

#13 lore raw

PATCH v5 4/15 video: add support of MIPI DSI interface

In reply to Yannick Fertré

Mipi_display.c contains a set of dsi helpers. This file is a copy of file drm_mipi_dsi.c (linux kernel).

---
 drivers/video/Kconfig    |   8 +
 drivers/video/Makefile   |   1 +
 drivers/video/mipi_dsi.c | 828 +++++++++++++++++++++++++++++++++++++++++++++++
 include/mipi_dsi.h       | 466 ++++++++++++++++++++++++++
 4 files changed, 1303 insertions(+)
 create mode 100644 drivers/video/mipi_dsi.c
 create mode 100644 include/mipi_dsi.h
drivers/video/Kconfig +8 -0
index 261fa98..36f666e 100644
@@ -73,6 +73,14 @@ config VIDEO_ANSI
 	  Enable ANSI escape sequence decoding for a more fully functional
 	  console.
 
+config VIDEO_MIPI_DSI
+	bool "Support MIPI DSI interface"
+	depends on DM_VIDEO
+	help
+	  Support MIPI DSI interface for driving a MIPI compatible device.
+	  The MIPI Display Serial Interface (MIPI DSI) defines a high-speed
+	  serial interface between a host processor and a display module.
+
 config CONSOLE_NORMAL
 	bool "Support a simple text console"
 	depends on DM_VIDEO
drivers/video/Makefile +1 -0
index 349a207..7df9b0b 100644
@@ -53,6 +53,7 @@ obj-$(CONFIG_VIDEO_LCD_HITACHI_TX18D42VM) += hitachi_tx18d42vm_lcd.o
 obj-$(CONFIG_VIDEO_LCD_SSD2828) += ssd2828.o
 obj-$(CONFIG_VIDEO_MB862xx) += mb862xx.o videomodes.o
 obj-${CONFIG_VIDEO_MESON} += meson/
+obj-${CONFIG_VIDEO_MIPI_DSI} += mipi_dsi.o
 obj-$(CONFIG_VIDEO_MVEBU) += mvebu_lcd.o
 obj-$(CONFIG_VIDEO_MX3) += mx3fb.o videomodes.o
 obj-$(CONFIG_VIDEO_MXS) += mxsfb.o videomodes.o
drivers/video/mipi_dsi.c new file +828 -0

828 lines not on this page · raw message

include/mipi_dsi.h new file +466 -0

466 lines not on this page · raw message

Signature · 1 line
2.7.4
#14 lore raw

PATCH v5 4/15 video: add support of MIPI DSI interface

Quoted 4 lines · On Mon, 7 Oct 2019 15:29:04 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Mipi_display.c contains a set of dsi helpers. This file is a copy of file drm_mipi_dsi.c (linux kernel).

Quoted 8 lines
---
 drivers/video/Kconfig    |   8 +
 drivers/video/Makefile   |   1 +
 drivers/video/mipi_dsi.c | 828 +++++++++++++++++++++++++++++++++++++++++++++++
 include/mipi_dsi.h       | 466 ++++++++++++++++++++++++++
 4 files changed, 1303 insertions(+)
 create mode 100644 drivers/video/mipi_dsi.c
 create mode 100644 include/mipi_dsi.h

Applied to u-boot-video/master, thanks!

--
Anatolij

#15 lore raw

PATCH v5 5/15 dm: Add a dsi host uclass

In reply to Yannick Fertré

Display Serial Interface (DSI) host can usefully be modelled as their own uclass.
DSI defines a serial bus and a communication protocol between the host and the device (panel, bridge).

---
 arch/sandbox/dts/sandbox.dts     |  6 ++-
 configs/sandbox_defconfig        |  1 +
 drivers/video/Kconfig            | 11 +++++
 drivers/video/Makefile           |  2 +
 drivers/video/dsi-host-uclass.c  | 39 +++++++++++++++++
 drivers/video/sandbox_dsi_host.c | 90 ++++++++++++++++++++++++++++++++++++++++
 include/dm/uclass-id.h           |  1 +
 include/dsi_host.h               | 73 ++++++++++++++++++++++++++++++++
 test/dm/Makefile                 |  1 +
 test/dm/dsi_host.c               | 58 ++++++++++++++++++++++++++
 10 files changed, 281 insertions(+), 1 deletion(-)
 create mode 100644 drivers/video/dsi-host-uclass.c
 create mode 100644 drivers/video/sandbox_dsi_host.c
 create mode 100644 include/dsi_host.h
 create mode 100644 test/dm/dsi_host.c
arch/sandbox/dts/sandbox.dts +5 -1
index 16a33db..f1637c8 100644
@@ -25,6 +25,11 @@
 		compatible = "google,cros-ec-sandbox";
 	};
 
+	dsi_host: dsi_host {
+		compatible = "sandbox,dsi-host";
+		status = "okay";
+	};
+
 	ethrawbus {
 		compatible = "sandbox,eth-raw-bus";
 		skip-localhost = <0>;
@@ -63,7 +68,6 @@
 		compatible = "sandbox,spi";
 		cs-gpios = <0>, <&gpio_a 0>;
 	};
-
 };
 
 #include "sandbox.dtsi"
configs/sandbox_defconfig +1 -0
index f77b9e8..3f2dc99 100644
@@ -206,6 +206,7 @@ CONFIG_CONSOLE_ROTATION=y
 CONFIG_CONSOLE_TRUETYPE=y
 CONFIG_CONSOLE_TRUETYPE_CANTORAONE=y
 CONFIG_VIDEO_SANDBOX_SDL=y
+CONFIG_VIDEO_DSI_HOST_SANDBOX=y
 CONFIG_OSD=y
 CONFIG_SANDBOX_OSD=y
 CONFIG_W1=y
drivers/video/Kconfig +11 -0
index 36f666e..cdaf616 100644
@@ -686,6 +686,17 @@ config VIDEO_DW_HDMI
 	  rather requires a SoC-specific glue driver to call it), it
 	  can not be enabled from the configuration menu.
 
+config VIDEO_DSI_HOST_SANDBOX
+	bool "Enable sandbox for dsi host"
+	depends on SANDBOX
+	select VIDEO_MIPI_DSI
+	help
+	  Enable support for sandbox dsi host device used for testing
+	  purposes.
+	  Display Serial Interface (DSI) defines a serial bus and
+	  a communication protocol between the host and the device
+	  (panel, bridge).
+
 config VIDEO_SIMPLE
 	bool "Simple display driver for preconfigured display"
 	help
drivers/video/Makefile +2 -0
index 7df9b0b..07aaca9 100644
@@ -11,6 +11,7 @@ obj-$(CONFIG_CONSOLE_ROTATION) += console_rotate.o
 obj-$(CONFIG_CONSOLE_TRUETYPE) += console_truetype.o fonts/
 obj-$(CONFIG_DISPLAY) += display-uclass.o
 obj-$(CONFIG_DM_VIDEO) += backlight-uclass.o
+obj-$(CONFIG_VIDEO_MIPI_DSI) += dsi-host-uclass.o
 obj-$(CONFIG_DM_VIDEO) += panel-uclass.o simple_panel.o
 obj-$(CONFIG_DM_VIDEO) += video-uclass.o vidconsole-uclass.o
 obj-$(CONFIG_DM_VIDEO) += video_bmp.o
@@ -58,6 +59,7 @@ obj-$(CONFIG_VIDEO_MVEBU) += mvebu_lcd.o
 obj-$(CONFIG_VIDEO_MX3) += mx3fb.o videomodes.o
 obj-$(CONFIG_VIDEO_MXS) += mxsfb.o videomodes.o
 obj-$(CONFIG_VIDEO_OMAP3) += omap3_dss.o
+obj-$(CONFIG_VIDEO_DSI_HOST_SANDBOX) += sandbox_dsi_host.o
 obj-$(CONFIG_VIDEO_SANDBOX_SDL) += sandbox_sdl.o
 obj-$(CONFIG_VIDEO_SIMPLE) += simplefb.o
 obj-$(CONFIG_VIDEO_TEGRA20) += tegra.o
drivers/video/dsi-host-uclass.c new file +39 -0
new file mode 100644
index 0000000..1db1f88
@@ -0,0 +1,39 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 STMicroelectronics - All Rights Reserved
+ * Author(s): Yannick Fertre <[email protected]> for STMicroelectronics.
+ *
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <dsi_host.h>
+
+int dsi_host_init(struct udevice *dev,
+		  struct mipi_dsi_device *device,
+		  struct display_timing *timings,
+		  unsigned int max_data_lanes,
+		  const struct mipi_dsi_phy_ops *phy_ops)
+{
+	struct dsi_host_ops *ops = dsi_host_get_ops(dev);
+
+	if (!ops->init)
+		return -ENOSYS;
+
+	return ops->init(dev, device, timings, max_data_lanes, phy_ops);
+}
+
+int dsi_host_enable(struct udevice *dev)
+{
+	struct dsi_host_ops *ops = dsi_host_get_ops(dev);
+
+	if (!ops->enable)
+		return -ENOSYS;
+
+	return ops->enable(dev);
+}
+
+UCLASS_DRIVER(dsi_host) = {
+	.id		= UCLASS_DSI_HOST,
+	.name		= "dsi_host",
+};
drivers/video/sandbox_dsi_host.c new file +90 -0

90 lines not on this page · raw message

include/dm/uclass-id.h +1 -0
index d4d9610..d3e9b47 100644
@@ -39,6 +39,7 @@ enum uclass_id {
 	UCLASS_CPU,		/* CPU, typically part of an SoC */
 	UCLASS_CROS_EC,		/* Chrome OS EC */
 	UCLASS_DISPLAY,		/* Display (e.g. DisplayPort, HDMI) */
+	UCLASS_DSI_HOST,	/* Display Serial Interface host */
 	UCLASS_DMA,		/* Direct Memory Access */
 	UCLASS_EFI,		/* EFI managed devices */
 	UCLASS_ETH,		/* Ethernet device */
include/dsi_host.h new file +73 -0

73 lines not on this page · raw message

test/dm/Makefile +1 -0
index 55a7940..0c2fd5c 100644
@@ -18,6 +18,7 @@ obj-$(CONFIG_BLK) += blk.o
 obj-$(CONFIG_BOARD) += board.o
 obj-$(CONFIG_DM_BOOTCOUNT) += bootcount.o
 obj-$(CONFIG_CLK) += clk.o clk_ccf.o
+obj-$(CONFIG_VIDEO_MIPI_DSI) += dsi_host.o
 obj-$(CONFIG_DM_ETH) += eth.o
 obj-$(CONFIG_FIRMWARE) += firmware.o
 obj-$(CONFIG_DM_GPIO) += gpio.o
test/dm/dsi_host.c new file +58 -0

58 lines not on this page · raw message

Signature · 1 line
2.7.4
#16 lore raw

PATCH v5 5/15 dm: Add a dsi host uclass

Quoted 6 lines · On Mon, 7 Oct 2019 15:29:05 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Display Serial Interface (DSI) host can usefully be modelled as their own uclass.
DSI defines a serial bus and a communication protocol between the host and the device (panel, bridge).

Quoted 16 lines
---
 arch/sandbox/dts/sandbox.dts     |  6 ++-
 configs/sandbox_defconfig        |  1 +
 drivers/video/Kconfig            | 11 +++++
 drivers/video/Makefile           |  2 +
 drivers/video/dsi-host-uclass.c  | 39 +++++++++++++++++
 drivers/video/sandbox_dsi_host.c | 90 ++++++++++++++++++++++++++++++++++++++++
 include/dm/uclass-id.h           |  1 +
 include/dsi_host.h               | 73 ++++++++++++++++++++++++++++++++
 test/dm/Makefile                 |  1 +
 test/dm/dsi_host.c               | 58 ++++++++++++++++++++++++++
 10 files changed, 281 insertions(+), 1 deletion(-)
 create mode 100644 drivers/video/dsi-host-uclass.c
 create mode 100644 drivers/video/sandbox_dsi_host.c
 create mode 100644 include/dsi_host.h
 create mode 100644 test/dm/dsi_host.c

Fixed test (./u-boot --fdt arch/sandbox/dts/test.dtb --command "ut dm dsi_host") and applied to u-boot-video/master, thanks!

--
Anatolij

#17 lore raw

PATCH v5 6/15 video: add MIPI DSI host controller bridge

In reply to Yannick Fertré

Add a Synopsys Designware MIPI DSI host bridge driver, based on the Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.

---
 drivers/video/Kconfig       |  10 +
 drivers/video/Makefile      |   1 +
 drivers/video/dw_mipi_dsi.c | 838 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 849 insertions(+)
 create mode 100644 drivers/video/dw_mipi_dsi.c
drivers/video/Kconfig +10 -0
index cdaf616..fdcb03c 100644
@@ -697,6 +697,16 @@ config VIDEO_DSI_HOST_SANDBOX
 	  a communication protocol between the host and the device
 	  (panel, bridge).
 
+config VIDEO_DW_MIPI_DSI
+	bool
+	select VIDEO_MIPI_DSI
+	help
+	  Enables the common driver code for the Synopsis Designware
+	  MIPI DSI block found in SoCs from various vendors.
+	  As this does not provide any functionality by itself (but
+	  rather requires a SoC-specific glue driver to call it), it
+	  can not be enabled from the configuration menu.
+
 config VIDEO_SIMPLE
 	bool "Simple display driver for preconfigured display"
 	help
drivers/video/Makefile +1 -0
index 07aaca9..0d35470 100644
@@ -45,6 +45,7 @@ obj-$(CONFIG_VIDEO_BROADWELL_IGD) += broadwell_igd.o
 obj-$(CONFIG_VIDEO_COREBOOT) += coreboot.o
 obj-$(CONFIG_VIDEO_DA8XX) += da8xx-fb.o videomodes.o
 obj-$(CONFIG_VIDEO_DW_HDMI) += dw_hdmi.o
+obj-$(CONFIG_VIDEO_DW_MIPI_DSI) += dw_mipi_dsi.o
 obj-$(CONFIG_VIDEO_EFI) += efi.o
 obj-$(CONFIG_VIDEO_FSL_DCU_FB) += fsl_dcu_fb.o videomodes.o
 obj-$(CONFIG_VIDEO_IPUV3) += imx/
drivers/video/dw_mipi_dsi.c new file +838 -0

838 lines not on this page · raw message

Signature · 1 line
2.7.4
#18 lore raw

PATCH v5 6/15 video: add MIPI DSI host controller bridge

Quoted 10 lines · On Mon, 7 Oct 2019 15:29:06 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Add a Synopsys Designware MIPI DSI host bridge driver, based on the Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.

---
 drivers/video/Kconfig       |  10 +
 drivers/video/Makefile      |   1 +
 drivers/video/dw_mipi_dsi.c | 838 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 849 insertions(+)
 create mode 100644 drivers/video/dw_mipi_dsi.c

Applied to u-boot-video/master, thanks!

--
Anatolij

#19 lore raw

PATCH v5 7/15 video: add support of STM32 MIPI DSI controller driver

In reply to Yannick Fertré

Add the STM32 DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge.

---
 drivers/video/stm32/Kconfig     |   9 +
 drivers/video/stm32/Makefile    |   1 +
 drivers/video/stm32/stm32_dsi.c | 490 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 500 insertions(+)
 create mode 100644 drivers/video/stm32/stm32_dsi.c
drivers/video/stm32/Kconfig +9 -0
index 78b1fac..95d51bb 100644
@@ -13,6 +13,15 @@ menuconfig VIDEO_STM32
 	  DSI. This option enables these supports which can be used on
 	  devices which have RGB TFT or DSI display connected.
 
+config VIDEO_STM32_DSI
+	bool "Enable STM32 DSI video support"
+	depends on VIDEO_STM32
+	select VIDEO_BRIDGE
+	select VIDEO_DW_MIPI_DSI
+	help
+	  This option enables support DSI internal bridge which can be used on
+	  devices which have DSI devices connected.
+
 config VIDEO_STM32_MAX_XRES
 	int "Maximum horizontal resolution (for memory allocation purposes)"
 	depends on VIDEO_STM32
drivers/video/stm32/Makefile +1 -0
index 7297e5f..f8b42d1 100644
@@ -6,3 +6,4 @@
 #          Yannick Fertre <[email protected]>
 
 obj-${CONFIG_VIDEO_STM32} = stm32_ltdc.o
+obj-${CONFIG_VIDEO_STM32_DSI} += stm32_dsi.o
drivers/video/stm32/stm32_dsi.c new file +490 -0

490 lines not on this page · raw message

Signature · 1 line
2.7.4
#20 lore raw

PATCH v5 7/15 video: add support of STM32 MIPI DSI controller driver

Quoted 10 lines · On Mon, 7 Oct 2019 15:29:07 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Add the STM32 DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge.

---
 drivers/video/stm32/Kconfig     |   9 +
 drivers/video/stm32/Makefile    |   1 +
 drivers/video/stm32/stm32_dsi.c | 490 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 500 insertions(+)
 create mode 100644 drivers/video/stm32/stm32_dsi.c

Applied to u-boot-video/master, thanks!

--
Anatolij

#21 lore raw

PATCH v5 8/15 video: add support of panel OTM8009A

In reply to Yannick Fertré

Support for Orise Tech otm8009a 480p dsi 2dl video mode panel.

---
 drivers/video/Kconfig              |   9 +
 drivers/video/Makefile             |   1 +
 drivers/video/orisetech_otm8009a.c | 379 +++++++++++++++++++++++++++++++++++++
 3 files changed, 389 insertions(+)
 create mode 100644 drivers/video/orisetech_otm8009a.c
drivers/video/Kconfig +9 -0
index fdcb03c..5cc2d9f 100644
@@ -328,6 +328,15 @@ config VIDEO_LCD_ANX9804
 	from a parallel LCD interface and translate it on the fy into a DP
 	interface for driving eDP TFT displays. It uses I2C for configuration.
 
+config VIDEO_LCD_ORISETECH_OTM8009A
+	bool "OTM8009A DSI LCD panel support"
+	depends on DM_VIDEO
+	select VIDEO_MIPI_DSI
+	default n
+	help
+	Say Y here if you want to enable support for Orise Technology
+	otm8009a 480x800 dsi 2dl panel.
+
 config VIDEO_LCD_SSD2828
 	bool "SSD2828 bridge chip"
 	default n
drivers/video/Makefile +1 -0
index 0d35470..0dd8ea0 100644
@@ -52,6 +52,7 @@ obj-$(CONFIG_VIDEO_IPUV3) += imx/
 obj-$(CONFIG_VIDEO_IVYBRIDGE_IGD) += ivybridge_igd.o
 obj-$(CONFIG_VIDEO_LCD_ANX9804) += anx9804.o
 obj-$(CONFIG_VIDEO_LCD_HITACHI_TX18D42VM) += hitachi_tx18d42vm_lcd.o
+obj-$(CONFIG_VIDEO_LCD_ORISETECH_OTM8009A) += orisetech_otm8009a.o
 obj-$(CONFIG_VIDEO_LCD_SSD2828) += ssd2828.o
 obj-$(CONFIG_VIDEO_MB862xx) += mb862xx.o videomodes.o
 obj-${CONFIG_VIDEO_MESON} += meson/
drivers/video/orisetech_otm8009a.c new file +379 -0

379 lines not on this page · raw message

Signature · 1 line
2.7.4
#22 lore raw

PATCH v5 8/15 video: add support of panel OTM8009A

Quoted 9 lines · On Mon, 7 Oct 2019 15:29:08 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Support for Orise Tech otm8009a 480p dsi 2dl video mode panel.

---
 drivers/video/Kconfig              |   9 +
 drivers/video/Makefile             |   1 +
 drivers/video/orisetech_otm8009a.c | 379 +++++++++++++++++++++++++++++++++++++
 3 files changed, 389 insertions(+)
 create mode 100644 drivers/video/orisetech_otm8009a.c

Applied to u-boot-video/master, thanks!

--
Anatolij

Viele Grüße,

Anatolij Gustschin

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-50 Fax: +49-8142-66989-80 Email: agust at denx.de

#23 lore raw

PATCH v5 9/15 video: add support of panel RM68200

In reply to Yannick Fertré

Support for Raydium RM68200 720p dsi 2dl video mode panel. This rm68200 panel driver is based on the Linux Kernel driver from drivers/gpu/drm/panel/panel-raydium-rm68200.c.

---
 drivers/video/Kconfig           |   9 ++
 drivers/video/Makefile          |   1 +
 drivers/video/raydium-rm68200.c | 351 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 361 insertions(+)
 create mode 100644 drivers/video/raydium-rm68200.c
drivers/video/Kconfig +9 -0
index 5cc2d9f..805713c 100644
@@ -337,6 +337,15 @@ config VIDEO_LCD_ORISETECH_OTM8009A
 	Say Y here if you want to enable support for Orise Technology
 	otm8009a 480x800 dsi 2dl panel.
 
+config VIDEO_LCD_RAYDIUM_RM68200
+	bool "RM68200 DSI LCD panel support"
+	depends on DM_VIDEO
+	select VIDEO_MIPI_DSI
+	default n
+	help
+	Say Y here if you want to enable support for Raydium RM68200
+	720x1280 DSI video mode panel.
+
 config VIDEO_LCD_SSD2828
 	bool "SSD2828 bridge chip"
 	default n
drivers/video/Makefile +1 -0
index 0dd8ea0..df7119d 100644
@@ -53,6 +53,7 @@ obj-$(CONFIG_VIDEO_IVYBRIDGE_IGD) += ivybridge_igd.o
 obj-$(CONFIG_VIDEO_LCD_ANX9804) += anx9804.o
 obj-$(CONFIG_VIDEO_LCD_HITACHI_TX18D42VM) += hitachi_tx18d42vm_lcd.o
 obj-$(CONFIG_VIDEO_LCD_ORISETECH_OTM8009A) += orisetech_otm8009a.o
+obj-$(CONFIG_VIDEO_LCD_RAYDIUM_RM68200) += raydium-rm68200.o
 obj-$(CONFIG_VIDEO_LCD_SSD2828) += ssd2828.o
 obj-$(CONFIG_VIDEO_MB862xx) += mb862xx.o videomodes.o
 obj-${CONFIG_VIDEO_MESON} += meson/
drivers/video/raydium-rm68200.c new file +351 -0

351 lines not on this page · raw message

Signature · 1 line
2.7.4
#24 lore raw

PATCH v5 9/15 video: add support of panel RM68200

Quoted 11 lines · On Mon, 7 Oct 2019 15:29:09 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Support for Raydium RM68200 720p dsi 2dl video mode panel. This rm68200 panel driver is based on the Linux Kernel driver from drivers/gpu/drm/panel/panel-raydium-rm68200.c.

---
 drivers/video/Kconfig           |   9 ++
 drivers/video/Makefile          |   1 +
 drivers/video/raydium-rm68200.c | 351 ++++++++++++++++++++++++++++++++++++++++
 3 files changed, 361 insertions(+)
 create mode 100644 drivers/video/raydium-rm68200.c

Applied to u-boot-video/master, thanks!

--
Anatolij

#25 lore raw

PATCH v5 10/15 board: Add STM32F769 SoC, discovery board support

In reply to Yannick Fertré
---
 configs/stm32f769-disco_defconfig | 63 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100644 configs/stm32f769-disco_defconfig
configs/stm32f769-disco_defconfig new file +63 -0
new file mode 100644
index 0000000..887e2d5
@@ -0,0 +1,63 @@
+CONFIG_ARM=y
+CONFIG_STM32=y
+CONFIG_SYS_TEXT_BASE=0x08008000
+CONFIG_SYS_MALLOC_F_LEN=0xE00
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_STM32F7=y
+CONFIG_TARGET_STM32F746_DISCO=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_BOOTDELAY=3
+CONFIG_USE_BOOTARGS=y
+CONFIG_BOOTARGS="console=ttyS0,115200 earlyprintk consoleblank=0 ignore_loglevel"
+# CONFIG_USE_BOOTCOMMAND is not set
+# CONFIG_DISPLAY_CPUINFO is not set
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_SPL_TEXT_BASE=0x8000000
+CONFIG_SYS_PROMPT="U-Boot > "
+CONFIG_AUTOBOOT_KEYED=y
+CONFIG_AUTOBOOT_PROMPT="Hit SPACE in %d seconds to stop autoboot.\n"
+CONFIG_AUTOBOOT_STOP_STR=" "
+CONFIG_CMD_GPT=y
+# CONFIG_RANDOM_UUID is not set
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SNTP=y
+CONFIG_CMD_DNS=y
+CONFIG_CMD_LINK_LOCAL=y
+CONFIG_CMD_BMP=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_TIMER=y
+# CONFIG_SPL_DOS_PARTITION is not set
+# CONFIG_ISO_PARTITION is not set
+# CONFIG_SPL_EFI_PARTITION is not set
+CONFIG_OF_CONTROL=y
+CONFIG_DEFAULT_DEVICE_TREE="stm32f769-disco"
+CONFIG_NET_RANDOM_ETHADDR=y
+CONFIG_NETCONSOLE=y
+CONFIG_DM_MMC=y
+# CONFIG_SPL_DM_MMC is not set
+CONFIG_ARM_PL180_MMCI=y
+CONFIG_MTD=y
+CONFIG_MTD_NOR_FLASH=y
+CONFIG_DM_SPI_FLASH=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_MACRONIX=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_DM_ETH=y
+CONFIG_ETH_DESIGNWARE=y
+CONFIG_MII=y
+# CONFIG_PINCTRL_FULL is not set
+CONFIG_SPI=y
+CONFIG_DM_SPI=y
+CONFIG_STM32_QSPI=y
+CONFIG_DM_VIDEO=y
+CONFIG_BACKLIGHT_GPIO=y
+CONFIG_VIDEO_LCD_ORISETECH_OTM8009A=y
+CONFIG_VIDEO_STM32=y
+CONFIG_VIDEO_STM32_DSI=y
+CONFIG_VIDEO_STM32_MAX_XRES=480
+CONFIG_VIDEO_STM32_MAX_YRES=800
+CONFIG_OF_LIBFDT_OVERLAY=y
+# CONFIG_EFI_LOADER is not set
Signature · 1 line
2.7.4
#26 lore raw

PATCH v5 10/15 board: Add STM32F769 SoC, discovery board support

Quoted 5 lines · On Mon, 7 Oct 2019 15:29:10 +0200 Yannick Fertré yannick.fertre at st.com wrote:
---
 configs/stm32f769-disco_defconfig | 63 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100644 configs/stm32f769-disco_defconfig

Added defconfig entry to board/st/stm32f746-disco/MAINTAINERS and applied to u-boot-video/master, thanks!

--
Anatolij

#27 lore raw

PATCH v5 11/15 ARM: dts: stm32f769: add display for STM32F769 disco board

In reply to Yannick Fertré

Enable the display controller, mipi dsi bridge & panel. Set panel display timings.

---
 arch/arm/dts/stm32f769-disco-u-boot.dtsi | 62 ++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)
arch/arm/dts/stm32f769-disco-u-boot.dtsi +62 -0
index 209a82c..c1d7d6b 100644
@@ -28,10 +28,72 @@
 		button-gpio = <&gpioa 0 0>;
 	};
 
+	dsi_host: dsi_host {
+		compatible = "synopsys,dw-mipi-dsi";
+		status = "okay";
+	};
+
 	led1 {
 		compatible = "st,led1";
 		led-gpio = <&gpioj 5 0>;
 	};
+
+	panel: panel {
+		compatible = "orisetech,otm8009a";
+		reset-gpios = <&gpioj 15 1>;
+		status = "okay";
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&dsi_out>;
+			};
+		};
+	};
+
+	soc {
+		dsi: dsi at 40016c00 {
+			compatible = "st,stm32-dsi";
+			reg = <0x40016C00 0x800>;
+			resets = <&rcc STM32F7_APB2_RESET(DSI)>;
+			clocks =  <&rcc 0 STM32F7_APB2_CLOCK(DSI)>,
+				  <&rcc 0 STM32F7_APB2_CLOCK(LTDC)>,
+				  <&clk_hse>;
+			clock-names = "pclk", "px_clk", "ref";
+			u-boot,dm-pre-reloc;
+			status = "okay";
+
+			ports {
+				port at 0 {
+					dsi_out: endpoint {
+						remote-endpoint = <&panel_in>;
+					};
+				};
+				port at 1 {
+					dsi_in: endpoint {
+						remote-endpoint = <&dp_out>;
+					};
+				};
+			};
+		};
+
+		ltdc: display-controller at 40016800 {
+			compatible = "st,stm32-ltdc";
+			reg = <0x40016800 0x200>;
+			resets = <&rcc STM32F7_APB2_RESET(LTDC)>;
+			clocks = <&rcc 0 STM32F7_APB2_CLOCK(LTDC)>;
+
+			status = "okay";
+			u-boot,dm-pre-reloc;
+
+			ports {
+				port at 0 {
+					dp_out: endpoint {
+						remote-endpoint = <&dsi_in>;
+					};
+				};
+			};
+		};
+	};
 };
 
 &fmc {
Signature · 1 line
2.7.4
#28 lore raw

PATCH v5 11/15 ARM: dts: stm32f769: add display for STM32F769 disco board

Quoted 7 lines · On Mon, 7 Oct 2019 15:29:11 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Enable the display controller, mipi dsi bridge & panel. Set panel display timings.

---
 arch/arm/dts/stm32f769-disco-u-boot.dtsi | 62 ++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

Applied to u-boot-video/master, thanks!

--
Anatolij

#29 lore raw

PATCH v5 12/15 ARM: dts: stm32mp1: add dsi host for stm32mp157c-ev1 board

In reply to Yannick Fertré

The new class dsi host allows the management of the bridge DPI to DSI. This bridge is embedded in the chipset mp1 (come from synopsys company).

---
 arch/arm/dts/stm32mp157c-ev1-u-boot.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/dts/stm32mp157c-ev1-u-boot.dtsi +5 -0
index ec60486..af5945d 100644
@@ -14,6 +14,11 @@
 		spi0 = &qspi;
 		usb0 = &usbotg_hs;
 	};
+
+	dsi_host: dsi_host {
+		compatible = "synopsys,dw-mipi-dsi";
+		status = "okay";
+	};
 };
 
 &flash0 {
Signature · 1 line
2.7.4
#30 lore raw

PATCH v5 12/15 ARM: dts: stm32mp1: add dsi host for stm32mp157c-ev1 board

Quoted 7 lines · On Mon, 7 Oct 2019 15:29:12 +0200 Yannick Fertré yannick.fertre at st.com wrote:

The new class dsi host allows the management of the bridge DPI to DSI. This bridge is embedded in the chipset mp1 (come from synopsys company).

---
 arch/arm/dts/stm32mp157c-ev1-u-boot.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Applied to u-boot-video/master, thanks!

--
Anatolij

#31 lore raw

PATCH v5 13/15 ARM: dts: stm32mp1: add dsi host for stm32mp157c-dk2 board

In reply to Yannick Fertré

The new class dsi host allows the management of the bridge DPI to DSI. This bridge is embedded in the chipset mp1 (come from synopsys company).

---
 arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi +7 -0
index 18ac1e3..cd9947f 100644
@@ -5,6 +5,13 @@
 
 #include "stm32mp157a-dk1-u-boot.dtsi"
 
+/ {
+	dsi_host: dsi_host {
+		compatible = "synopsys,dw-mipi-dsi";
+		status = "okay";
+	};
+};
+
 &i2c1 {
 	hdmi-transmitter at 39 {
 		reset-gpios = <&gpioa 10 GPIO_ACTIVE_LOW>;
Signature · 1 line
2.7.4
#32 lore raw

PATCH v5 13/15 ARM: dts: stm32mp1: add dsi host for stm32mp157c-dk2 board

Quoted 7 lines · On Mon, 7 Oct 2019 15:29:13 +0200 Yannick Fertré yannick.fertre at st.com wrote:

The new class dsi host allows the management of the bridge DPI to DSI. This bridge is embedded in the chipset mp1 (come from synopsys company).

---
 arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Applied to u-boot-video/master, thanks!

--
Anatolij

#33 lore raw

PATCH v5 14/15 stm32mp1: configs: update video

In reply to Yannick Fertré

Update video configs to support bitmap 16bpp, 24bpp, 32bpp & RLE8.

---
 include/configs/stm32mp1.h | 7 +++++++
 1 file changed, 7 insertions(+)
include/configs/stm32mp1.h +7 -0
index 92660fe..988992b 100644
@@ -83,6 +83,13 @@
 #define CONFIG_SYS_MTDPARTS_RUNTIME
 #endif
 
+#ifdef CONFIG_DM_VIDEO
+#define CONFIG_VIDEO_BMP_RLE8
+#define CONFIG_BMP_16BPP
+#define CONFIG_BMP_24BPP
+#define CONFIG_BMP_32BPP
+#endif
+
 /*****************************************************************************/
 #ifdef CONFIG_DISTRO_DEFAULTS
 /*****************************************************************************/
Signature · 1 line
2.7.4
#34 lore raw

PATCH v5 14/15 stm32mp1: configs: update video

Quoted 7 lines · On Mon, 7 Oct 2019 15:29:14 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Update video configs to support bitmap 16bpp, 24bpp, 32bpp & RLE8.

---
 include/configs/stm32mp1.h | 7 +++++++
 1 file changed, 7 insertions(+)

Applied to u-boot-video/master, thanks!

--
Anatolij

#35 lore raw

PATCH v5 15/15 stm32mp1: configs: add display devices

In reply to Yannick Fertré

Add support of panels otm8009A, RM68200 & DSI controller. Limit resolution to 1280x800.

---
 configs/stm32mp15_basic_defconfig   | 6 ++++++
 configs/stm32mp15_optee_defconfig   | 6 ++++++
 configs/stm32mp15_trusted_defconfig | 6 ++++++
 3 files changed, 18 insertions(+)
configs/stm32mp15_basic_defconfig +6 -0
index f6c68fe..c54feb0 100644
@@ -124,4 +124,10 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x5720
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_DM_VIDEO=y
 CONFIG_BACKLIGHT_GPIO=y
+CONFIG_VIDEO_LCD_ORISETECH_OTM8009A=y
+CONFIG_VIDEO_LCD_RAYDIUM_RM68200=y
+CONFIG_VIDEO_STM32=y
+CONFIG_VIDEO_STM32_DSI=y
+CONFIG_VIDEO_STM32_MAX_XRES=1280
+CONFIG_VIDEO_STM32_MAX_YRES=800
 CONFIG_FDT_FIXUP_PARTITIONS=y
configs/stm32mp15_optee_defconfig +6 -0
index 177cbc7..491174f 100644
@@ -109,4 +109,10 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x5720
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_DM_VIDEO=y
 CONFIG_BACKLIGHT_GPIO=y
+CONFIG_VIDEO_LCD_ORISETECH_OTM8009A=y
+CONFIG_VIDEO_LCD_RAYDIUM_RM68200=y
+CONFIG_VIDEO_STM32=y
+CONFIG_VIDEO_STM32_DSI=y
+CONFIG_VIDEO_STM32_MAX_XRES=1280
+CONFIG_VIDEO_STM32_MAX_YRES=800
 CONFIG_FDT_FIXUP_PARTITIONS=y
configs/stm32mp15_trusted_defconfig +6 -0
index 71ad115..a8a7eec 100644
@@ -108,4 +108,10 @@ CONFIG_USB_GADGET_PRODUCT_NUM=0x5720
 CONFIG_USB_GADGET_DWC2_OTG=y
 CONFIG_DM_VIDEO=y
 CONFIG_BACKLIGHT_GPIO=y
+CONFIG_VIDEO_LCD_ORISETECH_OTM8009A=y
+CONFIG_VIDEO_LCD_RAYDIUM_RM68200=y
+CONFIG_VIDEO_STM32=y
+CONFIG_VIDEO_STM32_DSI=y
+CONFIG_VIDEO_STM32_MAX_XRES=1280
+CONFIG_VIDEO_STM32_MAX_YRES=800
 CONFIG_FDT_FIXUP_PARTITIONS=y
Signature · 1 line
2.7.4
#36 lore raw

PATCH v5 15/15 stm32mp1: configs: add display devices

Quoted 9 lines · On Mon, 7 Oct 2019 15:29:15 +0200 Yannick Fertré yannick.fertre at st.com wrote:

Add support of panels otm8009A, RM68200 & DSI controller. Limit resolution to 1280x800.

---
 configs/stm32mp15_basic_defconfig   | 6 ++++++
 configs/stm32mp15_optee_defconfig   | 6 ++++++
 configs/stm32mp15_trusted_defconfig | 6 ++++++
 3 files changed, 18 insertions(+)

Applied to u-boot-video/master, thanks!

--
Anatolij

#37 lore raw

v5 cover splash screen on the stm32f769 & stm32mp1 boards

In reply to Yannick Fertré

Ok pour moi

Quoted 91 lines · Yannick Fertré

Version 1:
- Initial commit.

Version 2:
- swap patches to avoid compilation issue.
- remove panel timings from device tree.

Version 3:
- Share same include file mipi_display.h with kernel linux.
- Rework ltdc driver with last comments of Anatolij Gustshin.
- Check ordering (file dw_mipi_dsi.c).
- Rename mipi_display.c to mipi_dsi.c.

Version 4:
- Add physical set mode operation
- Improve debug trace (display controller ltdc)
- Refresh timings of panels
- Add regulator (dsi controller)
- Add new class DSI_HOST
- Support of panels OTM800A & RM68200

Version 5:
- Rework dsi host patch with last comments of Simon Glass.

This serie contains all patchsets needed for displaying a splash screen on the stm32f769 & stm32mp1 boards.
A new config has been created configs/stm32f769-disco_defconfig. This is necessary due to the difference of panels between stm32f769-disco, stm32f746-disco boards & stm32mp1 boards.
A new class DSI_HOST have been created to manage a dsi host between the dsi controller & display controller.

Yannick Fertré (15):
video: bmp: check resolutions of panel/bitmap
video: stm32: stm32_ltdc: add bridge to display controller
include: Add new DCS commands in the enum list
video: add support of MIPI DSI interface
dm: Add a dsi host uclass
video: add MIPI DSI host controller bridge
video: add support of STM32 MIPI DSI controller driver
video: add support of panel OTM8009A
video: add support of panel RM68200
board: Add STM32F769 SoC, discovery board support
ARM: dts: stm32f769: add display for STM32F769 disco board
ARM: dts: stm32mp1: add dsi host for stm32mp157c-ev1 board
ARM: dts: stm32mp1: add dsi host for stm32mp157c-dk2 board
stm32mp1: configs: update video
stm32mp1: configs: add display devices

 arch/arm/dts/stm32f769-disco-u-boot.dtsi |  62 +++
 arch/arm/dts/stm32mp157c-dk2-u-boot.dtsi |   7 +
 arch/arm/dts/stm32mp157c-ev1-u-boot.dtsi |   5 +
 arch/sandbox/dts/sandbox.dts             |   6 +-
 configs/sandbox_defconfig                |   1 +
 configs/stm32f769-disco_defconfig        |  63 +++
 configs/stm32mp15_basic_defconfig        |   6 +
 configs/stm32mp15_optee_defconfig        |   6 +
 configs/stm32mp15_trusted_defconfig      |   6 +
 drivers/video/Kconfig                    |  47 ++
 drivers/video/Makefile                   |   6 +
 drivers/video/dsi-host-uclass.c          |  39 ++
 drivers/video/dw_mipi_dsi.c              | 838 +++++++++++++++++++++++++++++++
 drivers/video/mipi_dsi.c                 | 828 ++++++++++++++++++++++++++++++
 drivers/video/orisetech_otm8009a.c       | 379 ++++++++++++++
 drivers/video/raydium-rm68200.c          | 351 +++++++++++++
 drivers/video/sandbox_dsi_host.c         |  90 ++++
 drivers/video/stm32/Kconfig              |   9 +
 drivers/video/stm32/Makefile             |   1 +
 drivers/video/stm32/stm32_dsi.c          | 490 ++++++++++++++++++
 drivers/video/stm32/stm32_ltdc.c         | 143 +++---
 drivers/video/video_bmp.c                |   7 +
 include/configs/stm32mp1.h               |   7 +
 include/dm/uclass-id.h                   |   1 +
 include/dsi_host.h                       |  73 +++
 include/mipi_display.h                   |   8 +
 include/mipi_dsi.h                       | 466 +++++++++++++++++
 test/dm/Makefile                         |   1 +
 test/dm/dsi_host.c                       |  58 +++
 29 files changed, 3943 insertions(+), 61 deletions(-)
 create mode 100644 configs/stm32f769-disco_defconfig
 create mode 100644 drivers/video/dsi-host-uclass.c
 create mode 100644 drivers/video/dw_mipi_dsi.c
 create mode 100644 drivers/video/mipi_dsi.c
 create mode 100644 drivers/video/orisetech_otm8009a.c
 create mode 100644 drivers/video/raydium-rm68200.c
 create mode 100644 drivers/video/sandbox_dsi_host.c
 create mode 100644 drivers/video/stm32/stm32_dsi.c
 create mode 100644 include/dsi_host.h
 create mode 100644 include/mipi_dsi.h
 create mode 100644 test/dm/dsi_host.c