crypto/ccp: max queue pair and max burst sizes changes
Subsystems (2)
PATCH 2/6 crypto/ccp: max queue pair and max burst sizes changes
From: Amaranath Somalapuram <[email protected]>
issue occurred during VPP testing, crash's issue in VPP when ccp used. vpp max burst size is 256, and minimum queue pair required is 3.
Cc: [email protected]
--- drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/crypto/ccp/ccp_pmd_private.h +2 -2
@@ -31,9 +31,9 @@#endif /**< Maximum queue pairs supported by CCP PMD */ -#define CCP_PMD_MAX_QUEUE_PAIRS 1 +#define CCP_PMD_MAX_QUEUE_PAIRS 8#define CCP_NB_MAX_DESCRIPTORS 1024 -#define CCP_MAX_BURST 64 +#define CCP_MAX_BURST 256#include "ccp_dev.h"
Signature · 1 line
2.17.1
Title should be: crypto/ccp: update max qp and burst size.
Quoted 5 lines
From: Amaranath Somalapuram <[email protected]>
issue occurred during VPP testing, crash's issue in VPP when ccp used. vpp max burst size is 256, and minimum queue pair required is 3.
Please explain the issue appropriately in the description. Does that mean, without VPP, this issue cannot be reproduced.
Add a fixes line with the commit which introduces this issue.
Quoted 26 lines
Signed-off-by Amaranath Somalapuram <[email protected]>--- drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/crypto/ccp/ccp_pmd_private.h +2
-3@@ -31,9 +31,9 @@#endif /**< Maximum queue pairs supported by CCP PMD */ -#define CCP_PMD_MAX_QUEUE_PAIRS 1 +#define CCP_PMD_MAX_QUEUE_PAIRS 8#define CCP_NB_MAX_DESCRIPTORS 1024 -#define CCP_MAX_BURST 64 +#define CCP_MAX_BURST 256#include "ccp_dev.h" --2.17.1
We can reproduce this issue in l2fwd by changing MAX_PKT_BURST 32 to 256
-----Original Message-----
From: Akhil Goyal <[email protected]>
Sent: Tuesday, October 15, 2019 4:28 PM
To: Somalapuram, Amaranath <[email protected]>; [email protected]
Cc: [email protected]
Subject: RE: [dpdk-dev] [PATCH v1 2/6] crypto/ccp: max queue pair and max burst sizes changes
[CAUTION: External Email]
Title should be: crypto/ccp: update max qp and burst size.
Quoted 5 lines
From: Amaranath Somalapuram <[email protected]>
issue occurred during VPP testing, crash's issue in VPP when ccp used. vpp max burst size is 256, and minimum queue pair required is 3.
Please explain the issue appropriately in the description. Does that mean, without VPP, this issue cannot be reproduced.
Add a fixes line with the commit which introduces this issue.
Quoted 26 lines
Signed-off-by Amaranath Somalapuram <[email protected]>--- drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/crypto/ccp/ccp_pmd_private.h +2
-3@@ -31,9 +31,9 @@#endif /**< Maximum queue pairs supported by CCP PMD */ -#define CCP_PMD_MAX_QUEUE_PAIRS 1 +#define CCP_PMD_MAX_QUEUE_PAIRS 8#define CCP_NB_MAX_DESCRIPTORS 1024 -#define CCP_MAX_BURST 64 +#define CCP_MAX_BURST 256#include "ccp_dev.h" --2.17.1
Quoted 6 lines
We can reproduce this issue in l2fwd by changing
MAX_PKT_BURST32 to 256
Description should have appropriate information explaining what the issue is and What is done in the patch to fix the issue.
Quoted 41 lines
Title should be:
crypto/ccp: update max qp and burst size.Quoted 5 lines
From: Amaranath Somalapuram <[email protected]>
issue occurred during VPP testing, crash's issue in VPP when ccp used. vpp max burst size is 256, and minimum queue pair required is 3.
Please explain the issue appropriately in the description. Does that mean, without VPP, this issue cannot be reproduced.
Add a fixes line with the commit which introduces this issue.
Quoted 26 lines
Signed-off-by Amaranath Somalapuram <[email protected]>--- drivers/crypto/ccp/ccp_pmd_private.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/crypto/ccp/ccp_pmd_private.h +2
-3@@ -31,9 +31,9 @@#endif /**< Maximum queue pairs supported by CCP PMD */ -#define CCP_PMD_MAX_QUEUE_PAIRS 1 +#define CCP_PMD_MAX_QUEUE_PAIRS 8#define CCP_NB_MAX_DESCRIPTORS 1024 -#define CCP_MAX_BURST 64 +#define CCP_MAX_BURST 256#include "ccp_dev.h" --2.17.1