crypto/ccp: scheduling multiple CCP within single burst
Subsystems (2)
PATCH 6/6 crypto/ccp: scheduling multiple CCP within single burst
From: Amaranath Somalapuram <[email protected]>
ccp driver was scheduling only one CCP in a single burst. Effective throughput was limited to 1 CCP performance. Scheduling multiple ccp within one burst will increase the ccp performance. this changes will divide the enqueue packets equally among the multiple CCP
Cc: [email protected]
--- drivers/crypto/ccp/ccp_crypto.c | 22 +++++++---- drivers/crypto/ccp/ccp_crypto.h | 7 +++- drivers/crypto/ccp/ccp_pmd_private.h | 2 + drivers/crypto/ccp/rte_ccp_pmd.c | 57 +++++++++++++++++++--------- 4 files changed, 62 insertions(+), 26 deletions(-)
drivers/crypto/ccp/ccp_crypto.c +15 -7
@@ -2803,7 +2803,9 @@ process_ops_to_enqueue(struct ccp_qp *qp,struct rte_crypto_op **op, struct ccp_queue *cmd_q, uint16_t nb_ops, - int slots_req) + uint16_t total_nb_ops, + int slots_req, + uint16_t b_idx) { int i, result = 0;struct ccp_batch_info *b_info;
@@ -2824,6 +2826,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,/* populate batch info necessary for dequeue */ b_info->op_idx =0 ; + b_info->b_idx =0 ; b_info->lsb_buf_idx =0 ; b_info->desccnt =0 ; b_info->cmd_q = cmd_q;
@@ -2839,7 +2842,7 @@ process_ops_to_enqueue(struct ccp_qp *qp, b_info->head_offset = (uint32_t )(cmd_q->qbase_phys_addr + cmd_q->qidx *Q_DESC_SIZE ); -for (i =0 ; i < nb_ops; i++) { +for (i = b_idx; i < (nb_ops+b_idx); i++) { session = (struct ccp_session *)get_sym_session_private_data ( op[i]->sym->session, ccp_cryptodev_driver_id);
@@ -2891,6 +2894,8 @@ process_ops_to_enqueue(struct ccp_qp *qp, } b_info->opcnt = i; + b_info->b_idx = b_idx; + b_info->total_nb_ops = total_nb_ops; b_info->tail_offset = (uint32_t )(cmd_q->qbase_phys_addr + cmd_q->qidx *Q_DESC_SIZE );
@@ -2905,7 +2910,7 @@ process_ops_to_enqueue(struct ccp_qp *qp,rte_ring_enqueue (qp->processed_pkts, (void *)b_info);EVP_MD_CTX_destroy (auth_ctx); -return i; +return i-b_idx; }static inline void ccp_auth_dq_prepare (struct rte_crypto_op *op)
@@ -2990,8 +2995,8 @@ ccp_prepare_ops(struct ccp_qp *qp, } min_ops =RTE_MIN (nb_ops, b_info->opcnt); -for (i =0 ; i < min_ops; i++) { - op_d[i] = b_info->op[b_info->op_idx++]; +for (i = b_info->b_idx; i < min_ops; i++) { + op_d[i] = b_info->op[b_info->b_idx + b_info->op_idx++]; session = (struct ccp_session *)get_sym_session_private_data ( op_d[i]->sym->session, ccp_cryptodev_driver_id);
@@ -3032,7 +3037,8 @@ ccp_prepare_ops(struct ccp_qp *qp,int process_ops_to_dequeue (struct ccp_qp *qp,struct rte_crypto_op **op, -uint16_t nb_ops) +uint16_t nb_ops, +uint16_t *total_nb_ops) {struct ccp_batch_info *b_info;uint32_t cur_head_offset;
@@ -3047,6 +3053,7 @@ process_ops_to_dequeue(struct ccp_qp *qp,if (b_info->auth_ctr == b_info->opcnt) goto success; + *total_nb_ops = b_info->total_nb_ops; cur_head_offset =CCP_READ_REG (b_info->cmd_q->reg_base,CMD_Q_HEAD_LO_BASE );
@@ -3056,7 +3063,7 @@ process_ops_to_dequeue(struct ccp_qp *qp, qp->b_info = b_info;return 0 ; } - }else { + }else if (b_info->tail_offset != b_info->head_offset) {if ((cur_head_offset >= b_info->head_offset) || (cur_head_offset < b_info->tail_offset)) { qp->b_info = b_info;
@@ -3066,6 +3073,7 @@ process_ops_to_dequeue(struct ccp_qp *qp, success: + *total_nb_ops = b_info->total_nb_ops; nb_ops =ccp_prepare_ops (qp, op, b_info, nb_ops);rte_atomic64_add (&b_info->cmd_q->free_slots, b_info->desccnt); b_info->desccnt =0 ;
drivers/crypto/ccp/ccp_crypto.h +5 -2
@@ -353,7 +353,9 @@ int process_ops_to_enqueue(struct ccp_qp *qp,struct rte_crypto_op **op, struct ccp_queue *cmd_q, uint16_t nb_ops, - int slots_req); + uint16_t total_nb_ops, + int slots_req, + uint16_t b_idx);/** * process crypto ops to be dequeued
@@ -365,7 +367,8 @@ int process_ops_to_enqueue(struct ccp_qp *qp,*/ int process_ops_to_dequeue (struct ccp_qp *qp,struct rte_crypto_op **op, -uint16_t nb_ops); +uint16_t nb_ops, +uint16_t *total_nb_ops);/**
drivers/crypto/ccp/ccp_pmd_private.h +2 -0
@@ -50,8 +50,10 @@ struct ccp_batch_info {struct rte_crypto_op *op[CCP_MAX_BURST ];/**< optable populated at enque time from app*/ int op_idx; +uint16_t b_idx;struct ccp_queue *cmd_q;uint16_t opcnt; +uint16_t total_nb_ops;/**< no. of crypto ops in batch*/ int desccnt;/**< no. of ccp queue descriptors*/
drivers/crypto/ccp/rte_ccp_pmd.c +40 -17
85 lines not on this page · raw message
Signature · 1 line
2.17.1
Title: crypto/ccp: schedule multiple devs within single burst Or
Crypto/ccp: improve performance.
Quoted 8 lines
From: Amaranath Somalapuram <[email protected]>
ccp driver was scheduling only one CCP in a single burst. Effective throughput was limited to 1 CCP performance. Scheduling multiple ccp within one burst will increase the ccp performance. this changes will divide the enqueue packets equally among the multiple CCP
Cc: [email protected]
This patch also doesn't look like a fix, rather a performance improvement. Not sure if this need to be backported?
If yes, then a fixes line is required and title would be "crypto/ccp: fix performance"
Quoted 3 lines
Signed-off-by Amaranath Somalapuram <[email protected]>---
Also please include CCP maintainer in cc list for v2. @Ravi Kumar: could you please review this series.
Quoted 29 lines
-----Original Message-----
From: Akhil Goyal
Sent: Tuesday, October 15, 2019 4:43 PM
To: [email protected]; [email protected]
Cc: [email protected]
Subject: RE: [PATCH v1 6/6]crypto/ccp: scheduling multiple CCP within single burstTitle:
crypto/ccp: schedule multiple devs within single burst Or
Crypto/ccp: improve performance.Quoted 8 lines
From: Amaranath Somalapuram <[email protected]>
ccp driver was scheduling only one CCP in a single burst. Effective throughput was limited to 1 CCP performance. Scheduling multiple ccp within one burst will increase the ccp performance. this changes will divide the enqueue packets equally among the multiple CCP
Cc: [email protected]This patch also doesn't look like a fix, rather a performance improvement. Not sure if this need to be backported?
If yes, then a fixes line is required and title would be "crypto/ccp: fix performance"Quoted 3 lines
Signed-off-by Amaranath Somalapuram <[email protected]>---