Skip to contentSkip to conversation

base.bbclass: add dependency on pseudo from do_prepare_recipe_sysroot

PATCH In review Mattias Hansson 2 participants 3 messages Oct 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 base.bbclass: add dependency on pseudo from do_prepare_recipe_sysroot

do_prepare_recipe_sysroot may perform groupadd, which requires pseudo. However, do_prepare_recipe_sysroot does not depend on pseudo explicitly, which sometimes causes a build error when building a recipe that adds groups.

This issue only occurs when executing do_prepare_recipe_sysroot for a recipe that adds groups before finishing a task that depends on pseudo for a recipe that doesn't add groups.

---
 meta/classes/base.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/base.bbclass +1 -0
index d3184ecf7b..1cea3a2213 100644
@@ -482,6 +482,7 @@ python () {
     # If we're building a target package we need to use fakeroot (pseudo)
     # in order to capture permissions, owners, groups and special files
     if not bb.data.inherits_class('native', d) and not bb.data.inherits_class('cross', d):
+        d.appendVarFlag('do_prepare_recipe_sysroot', 'depends', ' virtual/fakeroot-native:do_populate_sysroot')
         d.setVarFlag('do_unpack', 'umask', '022')
         d.setVarFlag('do_configure', 'umask', '022')
         d.setVarFlag('do_compile', 'umask', '022')
Signature · 1 line
2.11.0
#1 lore raw
Quoted 19 lines · Mattias Hansson

do_prepare_recipe_sysroot may perform groupadd, which requires pseudo. However, do_prepare_recipe_sysroot does not depend on pseudo explicitly, which sometimes causes a build error when building a recipe that adds groups.

This issue only occurs when executing do_prepare_recipe_sysroot for a recipe that adds groups before finishing a task that depends on pseudo for a recipe that doesn't add groups.

---
 meta/classes/base.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/base.bbclass +0 -0
index d3184ecf7b..1cea3a2213 100644

meta/classes/base.bbclass python () { · line 488

Quoted 7 lines
meta/classes/base.bbclass +1 -0
@@ -482,6 +482,7 @@ python () {
     # If we're building a target package we need to use fakeroot (pseudo)
     # in order to capture permissions, owners, groups and special files
     if not bb.data.inherits_class('native', d) and not bb.data.inherits_class('cross', d):
+        d.appendVarFlag('do_prepare_recipe_sysroot', 'depends', ' virtual/fakeroot-native:do_populate_sysroot')
         d.setVarFlag('do_unpack', 'umask', '022')
         d.setVarFlag('do_configure', 'umask', '022')
         d.setVarFlag('do_compile', 'umask', '022')

This was posted once already and the answer is still no, we do not want to add pseudo as a dependency for all sysroot construction. IO under pseudo is much slower and this is a very IO intensive task so it would hurt performance and isn't necessary in most cases.

I appreciate its harder but we need to find a better more targeted way to solve this and some of the other related pseudo issues for inter dependent user/groups.

Cheers,

RIchard

#2 lore raw
Quoted 33 lines · Richard Purdie
Quoted 19 lines · Mattias Hansson

do_prepare_recipe_sysroot may perform groupadd, which requires pseudo. However, do_prepare_recipe_sysroot does not depend on pseudo explicitly, which sometimes causes a build error when building a recipe that adds groups.

This issue only occurs when executing do_prepare_recipe_sysroot for a recipe that adds groups before finishing a task that depends on pseudo for a recipe that doesn't add groups.

---
 meta/classes/base.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/base.bbclass +0 -0
index d3184ecf7b..1cea3a2213 100644

meta/classes/base.bbclass python () { · line 488

Quoted 7 lines
meta/classes/base.bbclass +1 -0
@@ -482,6 +482,7 @@ python () {
     # If we're building a target package we need to use fakeroot (pseudo)
     # in order to capture permissions, owners, groups and special files
     if not bb.data.inherits_class('native', d) and not bb.data.inherits_class('cross', d):
+        d.appendVarFlag('do_prepare_recipe_sysroot', 'depends', ' virtual/fakeroot-native:do_populate_sysroot')
         d.setVarFlag('do_unpack', 'umask', '022')
         d.setVarFlag('do_configure', 'umask', '022')
         d.setVarFlag('do_compile', 'umask', '022')

This was posted once already and the answer is still no, we do not want to add pseudo as a dependency for all sysroot construction. IO under pseudo is much slower and this is a very IO intensive task so it would hurt performance and isn't necessary in most cases.

Quoted 8 lines

I appreciate its harder but we need to find a better more targeted way to solve this and some of the other related pseudo issues for inter dependent user/groups.

Cheers,

RIchard

Sorry for the confusion, but this is a different patch. The previous forced do_prepare_recipe_sysroot to run in a fakerooted environment. This caused a performance degrade and was therefore rejected, if I understood you correctly.

This patch will only declare fakeroot-native as a dependency and only cause pseudo to be available during do_prepare_recipe_sysroot. This should not cause the task to run in a fakerooted environment, is this a valid assumption?

/Mattias