Skip to contentSkip to conversation

app/testpmd: fix CRC strip config error

PATCH In review Ting Xu 3 participants 9 messages Oct 12, 2019 – Oct 15, 2019

lore
Share & tools
lore

Ting Xu

author
#0 lore raw

PATCH 1/1 app/testpmd: fix CRC strip config error

This patch fixed the bug that an error appears when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed previously. However, the current command does not enable "crc_strip" option properly, so that testpmd returns error when config crc_strip.

In this patch, an additional operation is added to recognize "crc_strip" option, since "crc_strip" and "keep_crc" are using the same flag "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config <port_id> rx_offload crc_strip on|off".

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")
---
 app/test-pmd/cmdline.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c +9 -1
index def471d97..31dbe4a07 100644
@@ -18084,6 +18084,9 @@ search_rx_offload(const char *name)
 	int found = 0;
 	unsigned int bit;
 
+	if (!strcmp(name, "crc_strip"))
+		name = "keep_crc";
+
 	single_offload = 1;
 	for (bit = 0; bit < sizeof(single_offload) * CHAR_BIT; bit++) {
 		single_name = rte_eth_dev_rx_offload_name(single_offload);
@@ -18113,6 +18116,7 @@ cmd_config_per_port_rx_offload_parsed(void *parsed_result,
 	uint16_t nb_rx_queues;
 	int q;
 	int ret;
+	int res_on_off = 1;
 
 	if (port->port_status != RTE_PORT_STOPPED) {
 		printf("Error: Can't config offload when Port %d "
@@ -18131,7 +18135,11 @@ cmd_config_per_port_rx_offload_parsed(void *parsed_result,
 		return;
 
 	nb_rx_queues = dev_info.nb_rx_queues;
-	if (!strcmp(res->on_off, "on")) {
+	res_on_off = strcmp(res->on_off, "on");
+
+	if (!strcmp(res->offload, "crc_strip"))
+		res_on_off = ~res_on_off;
+	if (!res_on_off) {
 		port->dev_conf.rxmode.offloads |= single_offload;
 		for (q = 0; q < nb_rx_queues; q++)
 			port->rx_conf[q].offloads |= single_offload;
Signature · 1 line
2.17.1
#1 lore raw

Hi Ting,

Quoted 54 lines

-----Original Message-----
From: Xu, Ting
Sent: Saturday, October 12, 2019 1:19 PM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>; [email protected]
Subject: [PATCH v1] app/testpmd: fix CRC strip config error

This patch fixed the bug that an error appears when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed previously. However, the current command does not enable "crc_strip" option properly, so that testpmd returns error when config crc_strip.

In this patch, an additional operation is added to recognize "crc_strip" option, since "crc_strip" and "keep_crc" are using the same flag "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config <port_id> rx_offload crc_strip on|off".

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload

commands")
Cc: [email protected]

---
 app/test-pmd/cmdline.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c index renamed from app/test-pmd/cmdline.c +0 -0

def471d97..31dbe4a07 100644

app/test-pmd/cmdline.c +3 -0
@@ -18084,6 +18084,9 @@ search_rx_offload(const char *name)
 	int found = 0;
 	unsigned int bit;
 
+	if (!strcmp(name, "crc_strip"))
+		name = "keep_crc";
+
 	single_offload = 1;
 	for (bit = 0; bit < sizeof(single_offload) * CHAR_BIT; bit++) {
 		single_name =

rte_eth_dev_rx_offload_name(single_offload);

app/test-pmd/cmdline.c +1 -0
@@ -18113,6 +18116,7 @@ cmd_config_per_port_rx_offload_parsed(void
 *parsed_result,
 	uint16_t nb_rx_queues;
 	int q;
 	int ret;
+	int res_on_off = 1;
 
 	if (port->port_status != RTE_PORT_STOPPED) {
app/test-pmd/cmdline.c +0 -0
 		printf("Error: Can't config offload when Port %d "

app/test-pmd/cmdline.c cmd_config_per_port_rx_offload_parsed(void · line 18142

Quoted 9 lines
app/test-pmd/cmdline.c +4 -1
@@ -18131,7 +18135,11 @@ cmd_config_per_port_rx_offload_parsed(void
 *parsed_result,
 		return;
 
 	nb_rx_queues = dev_info.nb_rx_queues;
-	if (!strcmp(res->on_off, "on")) {
+	res_on_off = strcmp(res->on_off, "on");
+
+	if (!strcmp(res->offload, "crc_strip"))
+		res_on_off = ~res_on_off;

It looks as if res_on_off is intended to have a value of 0 or 1. The above line gives it a value of -1, is this intended ?

Quoted 6 lines
app/test-pmd/cmdline.c +1 -0
+	if (!res_on_off) {
 		port->dev_conf.rxmode.offloads |= single_offload;
 		for (q = 0; q < nb_rx_queues; q++)

port->rx_conf[q].offloads |= single_offload;
--
2.17.1

Regards,

Bernard.

#2 lore raw

Hi Ting,

Quoted 47 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Iremonger, Bernard
Sent: Monday, October 14, 2019 12:26 PM
To: Xu, Ting <[email protected]>; [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix CRC strip config error

Hi Ting,

Quoted 37 lines

-----Original Message-----
From: Xu, Ting
Sent: Saturday, October 12, 2019 1:19 PM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>; [email protected]
Subject: [PATCH v1] app/testpmd: fix CRC strip config error

This patch fixed the bug that an error appears when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed previously. However, the current command does not enable "crc_strip" option properly, so that testpmd returns error when config crc_strip.

In this patch, an additional operation is added to recognize "crc_strip" option, since "crc_strip" and "keep_crc" are using the same flag "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config <port_id> rx_offload crc_strip on|off".

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload

commands")
Cc: [email protected]

---
 app/test-pmd/cmdline.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c index renamed from app/test-pmd/cmdline.c +0 -0

def471d97..31dbe4a07 100644

app/test-pmd/cmdline.c +0 -0
@@ -18084,6 +18084,9 @@ search_rx_offload(const char *name)
 	int found = 0;
 	unsigned int bit;
 
Quoted 3 lines

app/test-pmd/cmdline.c search_rx_offload(const char *name) · line 18089

Quoted 3 lines
app/test-pmd/cmdline.c +3 -0
+	if (!strcmp(name, "crc_strip"))
+		name = "keep_crc";
+

I don't understand why the name is being changed from "crc_strip" to "keep_crc" here?

Quoted 37 lines

app/test-pmd/cmdline.c

Quoted 14 lines
app/test-pmd/cmdline.c +0 -0
 	single_offload = 1;
 	for (bit = 0; bit < sizeof(single_offload) * CHAR_BIT; bit++) {
 		single_name =

rte_eth_dev_rx_offload_name(single_offload);

app/test-pmd/cmdline.c +1 -0
@@ -18113,6 +18116,7 @@ cmd_config_per_port_rx_offload_parsed(void
 *parsed_result,
 	uint16_t nb_rx_queues;
 	int q;
 	int ret;
+	int res_on_off = 1;
 
 	if (port->port_status != RTE_PORT_STOPPED) {
app/test-pmd/cmdline.c +0 -0
 		printf("Error: Can't config offload when Port %d "
@@ -18131,7 +18135,11 @@

cmd_config_per_port_rx_offload_parsed(void

app/test-pmd/cmdline.c cmd_config_per_port_rx_offload_parsed(void *parsed_result, · line 18141

Quoted 9 lines
app/test-pmd/cmdline.c +4 -1
 *parsed_result,
 		return;
 
 	nb_rx_queues = dev_info.nb_rx_queues;
-	if (!strcmp(res->on_off, "on")) {
+	res_on_off = strcmp(res->on_off, "on");
+
+	if (!strcmp(res->offload, "crc_strip"))
+		res_on_off = ~res_on_off;

It looks as if res_on_off is intended to have a value of 0 or 1. The above line gives it a value of -1, is this intended ?

Quoted 6 lines
app/test-pmd/cmdline.c +1 -0
+	if (!res_on_off) {
 		port->dev_conf.rxmode.offloads |= single_offload;
 		for (q = 0; q < nb_rx_queues; q++)

port->rx_conf[q].offloads |= single_offload;
--
2.17.1

Regards,

Quoted 1 line

Bernard.

Regards,

Bernard.

author
#3 lore raw

Hi, Bernard,

In the previous version, the command 'crc_strip' and 'keep_crc' used the same macro DEV_RX_OFFLOAD_KEEP_CRC. After Commit e5db17a1e54e, "port config all crc-strip on|off" is removed and the new command does not enable 'crc_strip'. So I wanted to change the name to 'keep_crc' to use DEV_RX_OFFLOAD_KEEP_CRC for 'crc_strip'.

However, since Ferruh said that the command 'crc_strip' is removed, I will rework the code totally. Thanks!

-----Original Message-----
From: Iremonger, Bernard
Sent: Monday, October 14, 2019 7:42 PM
To: Iremonger, Bernard <[email protected]>; Xu, Ting <[email protected]>; [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]
Subject: RE: [PATCH v1] app/testpmd: fix CRC strip config error

Hi Ting,

Quoted 49 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Iremonger, Bernard
Sent: Monday, October 14, 2019 12:26 PM
To: Xu, Ting <[email protected]>; [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; [email protected]
Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix CRC strip config error

Hi Ting,

Quoted 37 lines

-----Original Message-----
From: Xu, Ting
Sent: Saturday, October 12, 2019 1:19 PM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>; [email protected]
Subject: [PATCH v1] app/testpmd: fix CRC strip config error

This patch fixed the bug that an error appears when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed previously. However, the current command does not enable "crc_strip" option properly, so that testpmd returns error when config crc_strip.

In this patch, an additional operation is added to recognize "crc_strip" option, since "crc_strip" and "keep_crc" are using the same flag "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config <port_id> rx_offload crc_strip on|off".

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload

commands")
Cc: [email protected]

---
 app/test-pmd/cmdline.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
app/test-pmd/cmdline.c index renamed from app/test-pmd/cmdline.c +0 -0

def471d97..31dbe4a07 100644

app/test-pmd/cmdline.c +0 -0
@@ -18084,6 +18084,9 @@ search_rx_offload(const char *name)
 	int found = 0;
 	unsigned int bit;
 
Quoted 3 lines

app/test-pmd/cmdline.c search_rx_offload(const char *name) · line 18089

Quoted 3 lines
app/test-pmd/cmdline.c +3 -0
+	if (!strcmp(name, "crc_strip"))
+		name = "keep_crc";
+

I don't understand why the name is being changed from "crc_strip" to "keep_crc" here?

Quoted 37 lines

app/test-pmd/cmdline.c

Quoted 14 lines
app/test-pmd/cmdline.c +0 -0
 	single_offload = 1;
 	for (bit = 0; bit < sizeof(single_offload) * CHAR_BIT; bit++) {
 		single_name =

rte_eth_dev_rx_offload_name(single_offload);

app/test-pmd/cmdline.c +1 -0
@@ -18113,6 +18116,7 @@ cmd_config_per_port_rx_offload_parsed(void
 *parsed_result,
 	uint16_t nb_rx_queues;
 	int q;
 	int ret;
+	int res_on_off = 1;
 
 	if (port->port_status != RTE_PORT_STOPPED) {
app/test-pmd/cmdline.c +0 -0
 		printf("Error: Can't config offload when Port %d "
@@ -18131,7 +18135,11 @@

cmd_config_per_port_rx_offload_parsed(void

app/test-pmd/cmdline.c cmd_config_per_port_rx_offload_parsed(void *parsed_result, · line 18141

Quoted 9 lines
app/test-pmd/cmdline.c +4 -1
 *parsed_result,
 		return;
 
 	nb_rx_queues = dev_info.nb_rx_queues;
-	if (!strcmp(res->on_off, "on")) {
+	res_on_off = strcmp(res->on_off, "on");
+
+	if (!strcmp(res->offload, "crc_strip"))
+		res_on_off = ~res_on_off;

It looks as if res_on_off is intended to have a value of 0 or 1. The above line gives it a value of -1, is this intended ?

Quoted 6 lines
app/test-pmd/cmdline.c +1 -0
+	if (!res_on_off) {
 		port->dev_conf.rxmode.offloads |= single_offload;
 		for (q = 0; q < nb_rx_queues; q++)

port->rx_conf[q].offloads |= single_offload;
--
2.17.1

Regards,

Quoted 1 line

Bernard.

Regards,

Bernard.

#4 lore raw
In reply to Ting Xu
Quoted 5 lines · Ting Xu

This patch fixed the bug that an error appears when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed previously. However, the current command does not enable "crc_strip" option properly, so that testpmd returns error when config crc_strip.

"port config all crc-strip ..." is already removed,
Commit e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")

And 'crc_strip' seems left over for the "port config <id> rx_offload ..." command, instead of fixing it should be removed, and 'keep_crc' should be used, "port config <id> rx_offload keep_crc on|off"

Did you observe any problem on 'keep_crc' ?

Quoted 10 lines

In this patch, an additional operation is added to recognize "crc_strip" option, since "crc_strip" and "keep_crc" are using the same flag "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config <port_id> rx_offload crc_strip on|off".

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")

<...>

author
#5 lore raw

Hi, Ferruh,

From the log in Commit e5db17a1e54e, I thought crc_strip was still available in command "port config <id> rx_offload ...", so I did such modification. Since it was removed, I will rework on it.
There is no problem on 'keep_crc'.

Thanks!

-----Original Message-----
From: Yigit, Ferruh
Sent: Monday, October 14, 2019 8:29 PM
To: Xu, Ting <[email protected]>; [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>; [email protected]
Subject: Re: [dpdk-stable] [PATCH v1] app/testpmd: fix CRC strip config error

Quoted 5 lines · Ting Xu

This patch fixed the bug that an error appears when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed previously. However, the current command does not enable "crc_strip" option properly, so that testpmd returns error when config crc_strip.

"port config all crc-strip ..." is already removed, Commit e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")

And 'crc_strip' seems left over for the "port config <id> rx_offload ..."
command, instead of fixing it should be removed, and 'keep_crc' should be used, "port config <id> rx_offload keep_crc on|off"

Did you observe any problem on 'keep_crc' ?

Quoted 11 lines

In this patch, an additional operation is added to recognize "crc_strip" option, since "crc_strip" and "keep_crc" are using the same flag "DEV_RX_OFFLOAD_KEEP_CRC". The current command is "port config <port_id> rx_offload crc_strip on|off".

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload

commands")
Cc: [email protected]

<...>

author
#6 lore raw

PATCH v2 1/1 app/testpmd: fix CRC strip command failure

In reply to Ting Xu

This patch fixed the bug that a failure appeared when config rx_offload crc_strip using command "port config all crc-strip on|off". The reason is that this command was removed in Commit e5db17a1e54e. The current command is "port config <port_id> rx_offload keep_crc on|off" instead.

In this patch, some codes left over about 'crc_strip' are removed to make the current command clearer.

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")
---
 app/test-pmd/cmdline.c                      | 12 ++++++------
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  4 ++--
 2 files changed, 8 insertions(+), 8 deletions(-)
app/test-pmd/cmdline.c +6 -6
index 427eb308d..dde2660e9 100644
@@ -860,7 +860,7 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"port config <port_id> rx_offload vlan_strip|"
 			"ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|"
 			"outer_ipv4_cksum|macsec_strip|header_split|"
-			"vlan_filter|vlan_extend|jumbo_frame|crc_strip|"
+			"vlan_filter|vlan_extend|jumbo_frame|"
 			"scatter|timestamp|security|keep_crc on|off\n"
 			"     Enable or disable a per port Rx offloading"
 			" on all Rx queues of a port\n\n"
@@ -868,7 +868,7 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"port (port_id) rxq (queue_id) rx_offload vlan_strip|"
 			"ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|"
 			"outer_ipv4_cksum|macsec_strip|header_split|"
-			"vlan_filter|vlan_extend|jumbo_frame|crc_strip|"
+			"vlan_filter|vlan_extend|jumbo_frame|"
 			"scatter|timestamp|security|keep_crc on|off\n"
 			"    Enable or disable a per queue Rx offloading"
 			" only on a specific Rx queue\n\n"
@@ -18080,7 +18080,7 @@ cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_offload =
 		 offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
 			   "qinq_strip#outer_ipv4_cksum#macsec_strip#"
 			   "header_split#vlan_filter#vlan_extend#jumbo_frame#"
-			   "crc_strip#scatter#timestamp#security#keep_crc");
+			   "scatter#timestamp#security#keep_crc");
 cmdline_parse_token_string_t cmd_config_per_port_rx_offload_result_on_off =
 	TOKEN_STRING_INITIALIZER
 		(struct cmd_config_per_port_rx_offload_result,
@@ -18160,7 +18160,7 @@ cmdline_parse_inst_t cmd_config_per_port_rx_offload = {
 	.help_str = "port config <port_id> rx_offload vlan_strip|ipv4_cksum|"
 		    "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
 		    "macsec_strip|header_split|vlan_filter|vlan_extend|"
-		    "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
+		    "jumbo_frame|scatter|timestamp|security|keep_crc "
 		    "on|off",
 	.tokens = {
 		(void *)&cmd_config_per_port_rx_offload_result_port,
@@ -18210,7 +18210,7 @@ cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_offload =
 		 offload, "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#"
 			   "qinq_strip#outer_ipv4_cksum#macsec_strip#"
 			   "header_split#vlan_filter#vlan_extend#jumbo_frame#"
-			   "crc_strip#scatter#timestamp#security#keep_crc");
+			   "scatter#timestamp#security#keep_crc");
 cmdline_parse_token_string_t cmd_config_per_queue_rx_offload_result_on_off =
 	TOKEN_STRING_INITIALIZER
 		(struct cmd_config_per_queue_rx_offload_result,
@@ -18266,7 +18266,7 @@ cmdline_parse_inst_t cmd_config_per_queue_rx_offload = {
 		    "vlan_strip|ipv4_cksum|"
 		    "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|"
 		    "macsec_strip|header_split|vlan_filter|vlan_extend|"
-		    "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc "
+		    "jumbo_frame|scatter|timestamp|security|keep_crc "
 		    "on|off",
 	.tokens = {
 		(void *)&cmd_config_per_queue_rx_offload_result_port,
doc/guides/testpmd_app_ug/testpmd_funcs.rst +2 -2
index 494440cda..3af22dac7 100644
@@ -1670,7 +1670,7 @@ Enable or disable a per port Rx offloading on all Rx queues of a port::
                   vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro,
                   qinq_strip, outer_ipv4_cksum, macsec_strip,
                   header_split, vlan_filter, vlan_extend, jumbo_frame,
-                  crc_strip, scatter, timestamp, security, keep_crc
+                  scatter, timestamp, security, keep_crc
 
 This command should be run when the port is stopped, or else it will fail.
 
@@ -1685,7 +1685,7 @@ Enable or disable a per queue Rx offloading only on a specific Rx queue::
                   vlan_strip, ipv4_cksum, udp_cksum, tcp_cksum, tcp_lro,
                   qinq_strip, outer_ipv4_cksum, macsec_strip,
                   header_split, vlan_filter, vlan_extend, jumbo_frame,
-                  crc_strip, scatter, timestamp, security, keep_crc
+                  scatter, timestamp, security, keep_crc
 
 This command should be run when the port is stopped, or else it will fail.
 
Signature · 1 line
2.17.1
#7 lore raw

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix CRC strip command failure

Quoted 17 lines

-----Original Message-----
From: Xu, Ting
Sent: Tuesday, October 15, 2019 10:14 AM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>; Mcnamara, John <[email protected]>; Kovacevic, Marko <[email protected]>; [email protected]
Subject: [PATCH v2] app/testpmd: fix CRC strip command failure

This patch fixed the bug that a failure appeared when config rx_offload crc_strip using command "port config all crc-strip
on|off". The reason is that this command was removed in Commit e5db17a1e54e. The current command is "port config <port_id> rx_offload keep_crc on|off" instead.

Quoted 8 lines

In this patch, some codes left over about 'crc_strip' are removed to make the current command clearer.

Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload

commands")
Cc: [email protected]

Acked by: Bernard Iremonger <[email protected]>

Applied
#8 lore raw

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix CRC strip command failure

Quoted 20 lines · Bernard
Quoted 20 lines

-----Original Message-----
From: Xu, Ting
Sent: Tuesday, October 15, 2019 10:14 AM
To: [email protected]
Cc: Lu, Wenzhuo <[email protected]>; Wu, Jingjing <[email protected]>; Iremonger, Bernard <[email protected]>; Mcnamara, John <[email protected]>; Kovacevic, Marko <[email protected]>; [email protected]
Subject: [PATCH v2] app/testpmd: fix CRC strip command failure

This patch fixed the bug that a failure appeared when config rx_offload crc_strip using command "port config all crc-strip
on|off". The reason is that this command was removed in Commit e5db17a1e54e. The current command is "port config <port_id> rx_offload keep_crc on|off" instead.

In this patch, some codes left over about 'crc_strip' are removed to make the current command clearer.

Quoted 8 lines
Quoted 5 lines
Fixes e5db17a1e54e ("app/testpmd: remove duplicated Rx offload

commands")
Cc: [email protected]

Acked by: Bernard Iremonger <[email protected]>

Applied to dpdk-next-net/master, thanks.