Skip to contentSkip to conversation

perf annotate: ensure objdump argv is NULL terminated

PATCH In review Ian Rogers 2 participants 2 messages Oct 15, 2019 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf annotate: ensure objdump argv is NULL terminated

Provide null termination.

---
 tools/perf/util/annotate.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/util/annotate.c +1 -0
index f7c620e0099b..a9089e64046d 100644
@@ -1921,6 +1921,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
 		NULL, /* Will be the objdump command to run. */
 		"--",
 		NULL, /* Will be the symfs path. */
+		NULL,
 	};
 	struct child_process objdump_process;
 	int err = dso__disassemble_filename(dso, symfs_filename, sizeof(symfs_filename));
Signature · 1 line
2.23.0.700.g56cf767bdb-goog
#1 lore raw

Em Mon, Oct 14, 2019 at 05:34:18PM -0700, Ian Rogers escreveu:

Quoted 1 line

Provide null termination.

Since this hasn't been pushed upstream yet I folded it into the patch where it should've been, to keep bisection.

Thanks,

- Arnaldo

Quoted 19 lines
---
 tools/perf/util/annotate.c | 1 +
 1 file changed, 1 insertion(+)
tools/perf/util/annotate.c +1 -0
index f7c620e0099b..a9089e64046d 100644
@@ -1921,6 +1921,7 @@ static int symbol__disassemble(struct symbol *sym, struct annotate_args *args)
 		NULL, /* Will be the objdump command to run. */
 		"--",
 		NULL, /* Will be the symfs path. */
+		NULL,
 	};
 	struct child_process objdump_process;
 	int err = dso__disassemble_filename(dso, symfs_filename, sizeof(symfs_filename));
Signature · 1 line
2.23.0.700.g56cf767bdb-goog
Signature · 1 line
- Arnaldo