mnl: Don't use nftnl_set_set()
Phil Sutter
reviewerPATCH 1/1 mnl: Don't use nftnl_set_set()
The function is unsafe to use as it effectively bypasses data length checks. Instead use nftnl_set_set_str() which at least asserts a const char pointer is passed.
Signed-off-by Phil Sutter <[email protected]>
--- src/mnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/mnl.c +1 -1
@@ -945,7 +945,7 @@ mnl_nft_set_dump(struct netlink_ctx *ctx, int family, const char *table) nlh =nftnl_nlmsg_build_hdr (buf,NFT_MSG_GETSET , family,NLM_F_DUMP , ctx->seqnum);if (table !=NULL ) -nftnl_set_set (s,NFTNL_SET_TABLE , table); +nftnl_set_set_str (s,NFTNL_SET_TABLE , table);nftnl_set_nlmsg_build_payload (nlh, s);nftnl_set_free (s);
Signature · 1 line
2.23.0
Quoted 5 lines · Phil Sutter
The function is unsafe to use as it effectively bypasses data length checks. Instead use
nftnl_set_set_str()which at least asserts a const char pointer is passed.Signed-off-by Phil Sutter <[email protected]>