xfs: change the seconds fields in xfs_bulkstat to signed
PATCH 1/1 xfs: change the seconds fields in xfs_bulkstat to signed
From: Darrick J. Wong <[email protected]>
64-bit time is a signed quantity in the kernel, so the bulkstat structure should reflect that.
--- fs/xfs/libxfs/xfs_fs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
fs/xfs/libxfs/xfs_fs.h +4 -4
@@ -368,11 +368,11 @@ struct xfs_bulkstat {uint64_t bs_blocks;/* number of blocks */ uint64_t bs_xflags;/* extended flags */ -uint64_t bs_atime;/* access time, seconds */ -uint64_t bs_mtime;/* modify time, seconds */ +int64_t bs_atime;/* access time, seconds */ +int64_t bs_mtime;/* modify time, seconds */ -uint64_t bs_ctime;/* inode change time, seconds */ -uint64_t bs_btime;/* creation time, seconds */ +int64_t bs_ctime;/* inode change time, seconds */ +int64_t bs_btime;/* creation time, seconds */ uint32_t bs_gen;/* generation count */ uint32_t bs_uid;/* user id */
Quoted 6 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
64-bit time is a signed quantity in the kernel, so the bulkstat structure should reflect that.
Signed-off-by Darrick J. Wong <[email protected]>
Quoted 24 lines
--- fs/xfs/libxfs/xfs_fs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)fs/xfs/libxfs/xfs_fs.h +4
-4@@ -368,11 +368,11 @@ struct xfs_bulkstat {uint64_t bs_blocks;/* number of blocks */ uint64_t bs_xflags;/* extended flags */ -uint64_t bs_atime;/* access time, seconds */ -uint64_t bs_mtime;/* modify time, seconds */ +int64_t bs_atime;/* access time, seconds */ +int64_t bs_mtime;/* modify time, seconds */ -uint64_t bs_ctime;/* inode change time, seconds */ -uint64_t bs_btime;/* creation time, seconds */ +int64_t bs_ctime;/* inode change time, seconds */ +int64_t bs_btime;/* creation time, seconds */ uint32_t bs_gen;/* generation count */ uint32_t bs_uid;/* user id */
Signature · 1 line
Carlos
Quoted 6 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
64-bit time is a signed quantity in the kernel, so the bulkstat structure should reflect that.
Signed-off-by Darrick J. Wong <[email protected]>
Strictly speaking this is a break of the userspace API, but I can't see how it causes problems in practice, so:
Quoted 10 lines · Christoph Hellwig
Quoted 6 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
64-bit time is a signed quantity in the kernel, so the bulkstat structure should reflect that.
Signed-off-by Darrick J. Wong <[email protected]>Strictly speaking this is a break of the userspace API, but I can't see how it causes problems in practice, so:
Yeah, I think I'll add a note to the changelog:
"Note that the structure size stays the same and that we have not yet published userspace headers for this new ioctl so there are no users to break."
Quoted 1 line
Reviewed-by Christoph Hellwig <[email protected]>