pci: iproc-msi: fix __iomem annotation in decode_msi_hwirq()
PATCH 1/1 pci: iproc-msi: fix __iomem annotation in decode_msi_hwirq()
Fix __iomem attribute on msg variable passed to readl() in the decode_msi_hwirq() function. Fixes the following sparse warning:
drivers/pci/controller/pcie-iproc-msi.c:301:17: warning: incorrect type in argument 1 (different address spaces)drivers/pci/controller/pcie-iproc-msi.c:301:17: expected void const volatile [noderef] <asn:2> *addrdrivers/pci/controller/pcie-iproc-msi.c:301:17: got unsigned int [usertype] *[assigned] msg
---
Cc: Lorenzo Pieralisi <[email protected]>
Cc: Andrew Murray <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Cc: Ray Jui <[email protected]>
Cc: Scott Branden <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
.. (open list)
--- drivers/pci/controller/pcie-iproc-msi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/pci/controller/pcie-iproc-msi.c +3 -2
@@ -293,11 +293,12 @@ static const struct irq_domain_ops msi_domain_ops = {static inline u32 decode_msi_hwirq (struct iproc_msi *msi,u32 eq,u32 head) { -u32 *msg, hwirq; +u32 __iomem *msg; +u32 hwirq;unsigned int offs; offs =iproc_msi_eq_offset (msi, eq) + head *sizeof (u32); - msg = (u32 *)(msi->eq_cpu + offs); + msg = (u32 __iomem *)(msi->eq_cpu + offs); hwirq =readl (msg); hwirq = (hwirq >>5 ) + (hwirq &0x1f );
Signature · 1 line
2.23.0
Lorenzo Pieralisi
AppliedQuoted 20 lines · Ben Dooks (Codethink)
Fix
__iomemattribute on msg variable passed toreadl()in thedecode_msi_hwirq()function. Fixes the following sparse warning:
drivers/pci/controller/pcie-iproc-msi.c:301:17: warning: incorrect type in argument 1 (different address spaces)drivers/pci/controller/pcie-iproc-msi.c:301:17: expected void const volatile [noderef] <asn:2> *addrdrivers/pci/controller/pcie-iproc-msi.c:301:17: got unsigned int [usertype] *[assigned] msgSigned-off-by Ben Dooks <[email protected]>---
Cc: Lorenzo Pieralisi <[email protected]>
Cc: Andrew Murray <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
Cc: Ray Jui <[email protected]>
Cc: Scott Branden <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
.. (open list)
Quoted 3 lines
--- drivers/pci/controller/pcie-iproc-msi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Applied to pci/misc, thanks.
Lorenzo
Quoted 22 lines
drivers/pci/controller/pcie-iproc-msi.c +3
-2@@ -293,11 +293,12 @@ static const struct irq_domain_ops msi_domain_ops = {static inline u32 decode_msi_hwirq (struct iproc_msi *msi,u32 eq,u32 head) { -u32 *msg, hwirq; +u32 __iomem *msg; +u32 hwirq;unsigned int offs; offs =iproc_msi_eq_offset (msi, eq) + head *sizeof (u32); - msg = (u32 *)(msi->eq_cpu + offs); + msg = (u32 __iomem *)(msi->eq_cpu + offs); hwirq =readl (msg); hwirq = (hwirq >>5 ) + (hwirq &0x1f );Signature · 1 line
2.23.0
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel